diff --git a/CHANGELOG.md b/CHANGELOG.md index c4581c6d2..2031051f3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,6 @@ - Add Monochrome icon for Android 13 - Improve first launch screen -- Move archive info from overflow menu to bottom of card list - Fidme import fixes ## v2.19.0 - 113 diff --git a/app/src/main/java/protect/card_locker/MainActivity.java b/app/src/main/java/protect/card_locker/MainActivity.java index ce6c83749..ec9a101dd 100644 --- a/app/src/main/java/protect/card_locker/MainActivity.java +++ b/app/src/main/java/protect/card_locker/MainActivity.java @@ -68,7 +68,6 @@ public class MainActivity extends CatimaAppCompatActivity implements LoyaltyCard private View mHelpSection; private View mNoMatchingCardsText; private View mNoGroupCardsText; - private TextView mOpenArchiveText; private boolean mArchiveMode; public static final String BUNDLE_ARCHIVE_MODE = "archiveMode"; @@ -287,22 +286,12 @@ public class MainActivity extends CatimaAppCompatActivity implements LoyaltyCard mHelpSection = findViewById(R.id.helpSection); mNoMatchingCardsText = findViewById(R.id.noMatchingCardsText); mNoGroupCardsText = findViewById(R.id.noGroupCardsText); - mOpenArchiveText = findViewById(R.id.openArchiveLinkText); mCardList = findViewById(R.id.list); mNoMatchingCardsText.setOnTouchListener(gestureTouchListener); mCardList.setOnTouchListener(gestureTouchListener); mNoGroupCardsText.setOnTouchListener(gestureTouchListener); - // Open archive on archive text click - mOpenArchiveText.setOnClickListener(view -> { - Intent i = new Intent(getApplicationContext(), MainActivity.class); - Bundle bundle = new Bundle(); - bundle.putBoolean("archiveMode", true); - i.putExtras(bundle); - startActivity(i); - }); - mAdapter = new LoyaltyCardCursorAdapter(this, null, this); mCardList.setAdapter(mAdapter); registerForContextMenu(mCardList); @@ -475,11 +464,7 @@ public class MainActivity extends CatimaAppCompatActivity implements LoyaltyCard mHelpSection.setVisibility(View.GONE); mNoGroupCardsText.setVisibility(View.GONE); - int archiveCount = - mArchiveMode ? 0 : - group != null ? DBHelper.getArchivedCardsCount(mDatabase, group._id) : DBHelper.getArchivedCardsCount(mDatabase); - - if (mAdapter.getItemCount() + archiveCount > 0) { + if (mAdapter.getItemCount() > 0) { mCardList.setVisibility(View.VISIBLE); mNoMatchingCardsText.setVisibility(View.GONE); } else { @@ -494,10 +479,13 @@ public class MainActivity extends CatimaAppCompatActivity implements LoyaltyCard mNoGroupCardsText.setVisibility(View.VISIBLE); } } - - mOpenArchiveText.setText(getResources().getQuantityString(R.plurals.viewArchivedCardsWithCount, archiveCount, archiveCount)); - mOpenArchiveText.setVisibility(archiveCount > 0 ? View.VISIBLE : View.GONE); } else { + if (mArchiveMode) { + // If an user deletes the last card in archive mode, we should close the activity + // This will move us back to the main view + finish(); + } + mCardList.setVisibility(View.GONE); mHelpSection.setVisibility(View.VISIBLE); @@ -585,6 +573,14 @@ public class MainActivity extends CatimaAppCompatActivity implements LoyaltyCard }); } + if(!mArchiveMode) { + if (DBHelper.getArchivedCardsCount(mDatabase) == 0) { + inputMenu.findItem(R.id.action_archived).setVisible(false); + } else { + inputMenu.findItem(R.id.action_archived).setVisible(true); + } + } + return super.onCreateOptionsMenu(inputMenu); } @@ -651,6 +647,15 @@ public class MainActivity extends CatimaAppCompatActivity implements LoyaltyCard return true; } + if (id == R.id.action_archived) { + Intent i = new Intent(getApplicationContext(), MainActivity.class); + Bundle bundle = new Bundle(); + bundle.putBoolean("archiveMode", true); + i.putExtras(bundle); + startActivity(i); + return true; + } + if (id == R.id.action_import_export) { Intent i = new Intent(getApplicationContext(), ImportExportActivity.class); startActivity(i); diff --git a/app/src/main/res/layout/content_main.xml b/app/src/main/res/layout/content_main.xml index ab02b2779..aa163fa9b 100644 --- a/app/src/main/res/layout/content_main.xml +++ b/app/src/main/res/layout/content_main.xml @@ -1,84 +1,69 @@ - + android:orientation="vertical" + android:visibility="gone"> - - - - - - - - + android:layout_height="184dp" + android:scaleType="fitCenter" + android:src="@drawable/ic_launcher_foreground" /> + android:text="@string/welcome" /> - - - - - - + android:text="@string/noGiftCards"/> - + + + + + + + + diff --git a/app/src/main/res/menu/main_menu.xml b/app/src/main/res/menu/main_menu.xml index b0e238a8a..a1f1c882e 100644 --- a/app/src/main/res/menu/main_menu.xml +++ b/app/src/main/res/menu/main_menu.xml @@ -26,6 +26,10 @@ android:icon="@drawable/ic_folder_white" android:title="@string/groups" app:showAsAction="never"/> +