From 1b0fd94a8c3d55805b933478b23b456eb5830c2b Mon Sep 17 00:00:00 2001
From: Marnes <leaumar@mailbox.org>
Date: Fri, 1 Nov 2024 18:27:33 +0100
Subject: [PATCH] misc. linting

---
 .../main/java/protect/card_locker/preferences/Settings.java | 6 ++++--
 app/src/main/res/values-nl/strings.xml                      | 2 +-
 app/src/main/res/xml/preferences.xml                        | 2 +-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/protect/card_locker/preferences/Settings.java b/app/src/main/java/protect/card_locker/preferences/Settings.java
index 52309886e..33949c573 100644
--- a/app/src/main/java/protect/card_locker/preferences/Settings.java
+++ b/app/src/main/java/protect/card_locker/preferences/Settings.java
@@ -4,6 +4,7 @@ import android.content.Context;
 import android.content.SharedPreferences;
 
 import androidx.annotation.IntegerRes;
+import androidx.annotation.Nullable;
 import androidx.annotation.StringRes;
 import androidx.appcompat.app.AppCompatDelegate;
 import androidx.preference.PreferenceManager;
@@ -15,7 +16,7 @@ import protect.card_locker.Utils;
 
 public class Settings {
     private final Context mContext;
-    private SharedPreferences mSettings;
+    private final SharedPreferences mSettings;
 
     public Settings(Context context) {
         mContext = context.getApplicationContext();
@@ -42,10 +43,11 @@ public class Settings {
         return mSettings.getBoolean(getResString(keyId), defaultValue);
     }
 
+    @Nullable
     public Locale getLocale() {
         String value = getString(R.string.settings_key_locale, "");
 
-        if (value.length() == 0) {
+        if (value.isEmpty()) {
             return null;
         }
 
diff --git a/app/src/main/res/values-nl/strings.xml b/app/src/main/res/values-nl/strings.xml
index cfdcc6a3c..318b4a930 100644
--- a/app/src/main/res/values-nl/strings.xml
+++ b/app/src/main/res/values-nl/strings.xml
@@ -294,4 +294,4 @@
     <string name="useBackImage">Gebruik achterzijde van kaart</string>
     <string name="settings_use_volume_keys_navigation">Verwissel kaart met de volume knoppen</string>
     <string name="settings_use_volume_keys_navigation_summary">Gebruik de volume knoppen om te wisselen van getoonde kaart</string>
-</resources>
\ No newline at end of file
+</resources>
diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml
index 554592d55..67dc50270 100644
--- a/app/src/main/res/xml/preferences.xml
+++ b/app/src/main/res/xml/preferences.xml
@@ -112,4 +112,4 @@
 
     </PreferenceCategory>
 
-</PreferenceScreen>
\ No newline at end of file
+</PreferenceScreen>