diff --git a/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java b/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java index b15c4f8f9..b13430e41 100644 --- a/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java +++ b/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java @@ -4,12 +4,16 @@ package protect.card_locker; import android.content.Intent; import android.content.pm.ActivityInfo; import android.graphics.Color; +import android.graphics.drawable.Drawable; import android.os.Build; import android.os.Bundle; +import android.support.v4.content.ContextCompat; import android.support.v4.graphics.ColorUtils; +import android.support.v4.graphics.drawable.DrawableCompat; import android.support.v4.widget.TextViewCompat; import android.support.v7.app.ActionBar; import android.support.v7.app.AppCompatActivity; +import android.support.v7.content.res.AppCompatResources; import android.support.v7.widget.Toolbar; import android.util.Log; import android.util.TypedValue; @@ -55,6 +59,22 @@ public class LoyaltyCardViewActivity extends AppCompatActivity Log.d(TAG, "View activity: id=" + loyaltyCardId); } + private Drawable getIcon(int icon, boolean dark) + { + Drawable unwrappedIcon = AppCompatResources.getDrawable(this, icon); + Drawable wrappedIcon = DrawableCompat.wrap(unwrappedIcon); + if(dark) + { + DrawableCompat.setTint(wrappedIcon, Color.BLACK); + } + else + { + DrawableCompat.setTintList(wrappedIcon, null); + } + + return wrappedIcon; + } + @Override protected void onCreate(Bundle savedInstanceState) { @@ -171,13 +191,10 @@ public class LoyaltyCardViewActivity extends AppCompatActivity // If the background is very bright, we should use dark icons backgroundNeedsDarkIcons = (ColorUtils.calculateLuminance(backgroundHeaderColor) > LUMINANCE_MIDPOINT); - if(backgroundNeedsDarkIcons) + ActionBar actionBar = getSupportActionBar(); + if(actionBar != null) { - ActionBar actionBar = getSupportActionBar(); - if(actionBar != null) - { - actionBar.setHomeAsUpIndicator(R.drawable.ic_arrow_back_black); - } + actionBar.setHomeAsUpIndicator(getIcon(R.drawable.ic_arrow_back_white, backgroundNeedsDarkIcons)); } if(barcodeImage.getHeight() == 0) @@ -227,11 +244,8 @@ public class LoyaltyCardViewActivity extends AppCompatActivity item.setVisible(false); } - if(backgroundNeedsDarkIcons) - { - menu.findItem(R.id.action_share).setIcon(R.drawable.ic_share_black); - menu.findItem(R.id.action_edit).setIcon(R.drawable.ic_mode_edit_black_24dp); - } + menu.findItem(R.id.action_share).setIcon(getIcon(R.drawable.ic_share_white, backgroundNeedsDarkIcons)); + menu.findItem(R.id.action_edit).setIcon(getIcon(R.drawable.ic_mode_edit_white_24dp, backgroundNeedsDarkIcons)); return super.onCreateOptionsMenu(menu); } @@ -281,27 +295,14 @@ public class LoyaltyCardViewActivity extends AppCompatActivity { if(lock) { - if(backgroundNeedsDarkIcons) - { - item.setIcon(R.drawable.ic_lock_outline_black_24dp); - } - else - { - item.setIcon(R.drawable.ic_lock_outline_white_24dp); - } + + item.setIcon(getIcon(R.drawable.ic_lock_outline_white_24dp, backgroundNeedsDarkIcons)); item.setTitle(R.string.unlockScreen); setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_NOSENSOR); } else { - if(backgroundNeedsDarkIcons) - { - item.setIcon(R.drawable.ic_lock_open_black_24dp); - } - else - { - item.setIcon(R.drawable.ic_lock_open_white_24dp); - } + item.setIcon(getIcon(R.drawable.ic_lock_open_white_24dp, backgroundNeedsDarkIcons)); item.setTitle(R.string.lockScreen); setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_SENSOR); } diff --git a/app/src/main/res/drawable-anydpi/ic_arrow_back_black.xml b/app/src/main/res/drawable-anydpi/ic_arrow_back_black.xml deleted file mode 100644 index 98478bec9..000000000 --- a/app/src/main/res/drawable-anydpi/ic_arrow_back_black.xml +++ /dev/null @@ -1,11 +0,0 @@ - - - diff --git a/app/src/main/res/drawable-anydpi/ic_lock_open_black_24dp.xml b/app/src/main/res/drawable-anydpi/ic_lock_open_black_24dp.xml deleted file mode 100644 index 6481a6ab2..000000000 --- a/app/src/main/res/drawable-anydpi/ic_lock_open_black_24dp.xml +++ /dev/null @@ -1,11 +0,0 @@ - - - diff --git a/app/src/main/res/drawable-anydpi/ic_lock_outline_black_24dp.xml b/app/src/main/res/drawable-anydpi/ic_lock_outline_black_24dp.xml deleted file mode 100644 index e79c7fa13..000000000 --- a/app/src/main/res/drawable-anydpi/ic_lock_outline_black_24dp.xml +++ /dev/null @@ -1,11 +0,0 @@ - - - diff --git a/app/src/main/res/drawable-anydpi/ic_mode_edit_black_24dp.xml b/app/src/main/res/drawable-anydpi/ic_mode_edit_black_24dp.xml deleted file mode 100644 index 0fcc94c3d..000000000 --- a/app/src/main/res/drawable-anydpi/ic_mode_edit_black_24dp.xml +++ /dev/null @@ -1,11 +0,0 @@ - - - diff --git a/app/src/main/res/drawable-anydpi/ic_share_black.xml b/app/src/main/res/drawable-anydpi/ic_share_black.xml deleted file mode 100644 index d6d88a382..000000000 --- a/app/src/main/res/drawable-anydpi/ic_share_black.xml +++ /dev/null @@ -1,11 +0,0 @@ - - - diff --git a/app/src/main/res/drawable-hdpi/ic_arrow_back_black.png b/app/src/main/res/drawable-hdpi/ic_arrow_back_black.png deleted file mode 100644 index ebdf58407..000000000 Binary files a/app/src/main/res/drawable-hdpi/ic_arrow_back_black.png and /dev/null differ diff --git a/app/src/main/res/drawable-hdpi/ic_arrow_back_white.png b/app/src/main/res/drawable-hdpi/ic_arrow_back_white.png new file mode 100644 index 000000000..f782543d3 Binary files /dev/null and b/app/src/main/res/drawable-hdpi/ic_arrow_back_white.png differ diff --git a/app/src/main/res/drawable-hdpi/ic_lock_open_black_24dp.png b/app/src/main/res/drawable-hdpi/ic_lock_open_black_24dp.png deleted file mode 100644 index 8e6a08971..000000000 Binary files a/app/src/main/res/drawable-hdpi/ic_lock_open_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-hdpi/ic_lock_outline_black_24dp.png b/app/src/main/res/drawable-hdpi/ic_lock_outline_black_24dp.png deleted file mode 100644 index 812d91271..000000000 Binary files a/app/src/main/res/drawable-hdpi/ic_lock_outline_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-hdpi/ic_mode_edit_black_24dp.png b/app/src/main/res/drawable-hdpi/ic_mode_edit_black_24dp.png deleted file mode 100644 index fdecd8f6c..000000000 Binary files a/app/src/main/res/drawable-hdpi/ic_mode_edit_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-hdpi/ic_share_black.png b/app/src/main/res/drawable-hdpi/ic_share_black.png deleted file mode 100644 index 7bfe54373..000000000 Binary files a/app/src/main/res/drawable-hdpi/ic_share_black.png and /dev/null differ diff --git a/app/src/main/res/drawable-mdpi/ic_arrow_back_black.png b/app/src/main/res/drawable-mdpi/ic_arrow_back_black.png deleted file mode 100644 index 24a492818..000000000 Binary files a/app/src/main/res/drawable-mdpi/ic_arrow_back_black.png and /dev/null differ diff --git a/app/src/main/res/drawable-mdpi/ic_arrow_back_white.png b/app/src/main/res/drawable-mdpi/ic_arrow_back_white.png new file mode 100644 index 000000000..222690b0b Binary files /dev/null and b/app/src/main/res/drawable-mdpi/ic_arrow_back_white.png differ diff --git a/app/src/main/res/drawable-mdpi/ic_lock_open_black_24dp.png b/app/src/main/res/drawable-mdpi/ic_lock_open_black_24dp.png deleted file mode 100644 index 7bef37b2a..000000000 Binary files a/app/src/main/res/drawable-mdpi/ic_lock_open_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-mdpi/ic_lock_outline_black_24dp.png b/app/src/main/res/drawable-mdpi/ic_lock_outline_black_24dp.png deleted file mode 100644 index 6bdbeeb4c..000000000 Binary files a/app/src/main/res/drawable-mdpi/ic_lock_outline_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-mdpi/ic_mode_edit_black_24dp.png b/app/src/main/res/drawable-mdpi/ic_mode_edit_black_24dp.png deleted file mode 100644 index fd08725aa..000000000 Binary files a/app/src/main/res/drawable-mdpi/ic_mode_edit_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-mdpi/ic_share_black.png b/app/src/main/res/drawable-mdpi/ic_share_black.png deleted file mode 100644 index d03e2495f..000000000 Binary files a/app/src/main/res/drawable-mdpi/ic_share_black.png and /dev/null differ diff --git a/app/src/main/res/drawable-xhdpi/ic_arrow_back_black.png b/app/src/main/res/drawable-xhdpi/ic_arrow_back_black.png deleted file mode 100644 index 77c9552e0..000000000 Binary files a/app/src/main/res/drawable-xhdpi/ic_arrow_back_black.png and /dev/null differ diff --git a/app/src/main/res/drawable-xhdpi/ic_arrow_back_white.png b/app/src/main/res/drawable-xhdpi/ic_arrow_back_white.png new file mode 100644 index 000000000..c4e8d91ba Binary files /dev/null and b/app/src/main/res/drawable-xhdpi/ic_arrow_back_white.png differ diff --git a/app/src/main/res/drawable-xhdpi/ic_lock_open_black_24dp.png b/app/src/main/res/drawable-xhdpi/ic_lock_open_black_24dp.png deleted file mode 100644 index 54fefc3e8..000000000 Binary files a/app/src/main/res/drawable-xhdpi/ic_lock_open_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xhdpi/ic_lock_outline_black_24dp.png b/app/src/main/res/drawable-xhdpi/ic_lock_outline_black_24dp.png deleted file mode 100644 index edff073bc..000000000 Binary files a/app/src/main/res/drawable-xhdpi/ic_lock_outline_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xhdpi/ic_mode_edit_black_24dp.png b/app/src/main/res/drawable-xhdpi/ic_mode_edit_black_24dp.png deleted file mode 100644 index 710d6cc0c..000000000 Binary files a/app/src/main/res/drawable-xhdpi/ic_mode_edit_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xhdpi/ic_share_black.png b/app/src/main/res/drawable-xhdpi/ic_share_black.png deleted file mode 100644 index eedcacb55..000000000 Binary files a/app/src/main/res/drawable-xhdpi/ic_share_black.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_arrow_back_black.png b/app/src/main/res/drawable-xxhdpi/ic_arrow_back_black.png deleted file mode 100644 index d7c6207da..000000000 Binary files a/app/src/main/res/drawable-xxhdpi/ic_arrow_back_black.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_arrow_back_white.png b/app/src/main/res/drawable-xxhdpi/ic_arrow_back_white.png new file mode 100644 index 000000000..575d5075c Binary files /dev/null and b/app/src/main/res/drawable-xxhdpi/ic_arrow_back_white.png differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_lock_open_black_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_lock_open_black_24dp.png deleted file mode 100644 index 4a74b1b31..000000000 Binary files a/app/src/main/res/drawable-xxhdpi/ic_lock_open_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_lock_outline_black_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_lock_outline_black_24dp.png deleted file mode 100644 index 1bb240a5e..000000000 Binary files a/app/src/main/res/drawable-xxhdpi/ic_lock_outline_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_mode_edit_black_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_mode_edit_black_24dp.png deleted file mode 100644 index c36f260fa..000000000 Binary files a/app/src/main/res/drawable-xxhdpi/ic_mode_edit_black_24dp.png and /dev/null differ diff --git a/app/src/main/res/drawable-xxhdpi/ic_share_black.png b/app/src/main/res/drawable-xxhdpi/ic_share_black.png deleted file mode 100644 index 2bc718cec..000000000 Binary files a/app/src/main/res/drawable-xxhdpi/ic_share_black.png and /dev/null differ