mirror/Android
1
0
Fork 0
mirror of https://github.com/CatimaLoyalty/Android.git synced 2026-03-04 23:27:09 -05:00
Code Issues Packages Projects Releases Wiki Activity

Protect against unexpected failures when encoding barcodes

Browse Source 
It was observed that some barcode encoders will fail if the
data passed to them is not valid for the format. For example,
the ITF encoder will throw an ArrayIndexOutOfBoundsException
on the input "this is a test".
This commit is contained in:
Branden Archer
2016-05-21 22:50:06 -04:00
parent 0aa1804258
commit 2f86de4c1b
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/src/main/java/protect/card_locker/BarcodeImageWriterTask.java
View File

@@ -45,7 +45,17 @@ class BarcodeImageWriterTask extends AsyncTask<Void, Void, Bitmap>
BitMatrix bitMatrix;
try
{
bitMatrix = writer.encode(cardId, format, imageWidth, imageHeight, null);
try
{
bitMatrix = writer.encode(cardId, format, imageWidth, imageHeight, null);
}
catch(Exception e)
{
// Cast a wider net here and catch any exception, as there are some
// cases where an encoder may fail if the data is invalid for the
// barcode type. If this happens, we want to fail gracefully.
throw new WriterException(e);
}
final int WHITE = 0xFFFFFFFF;
final int BLACK = 0xFF000000;
@@ -86,9 +96,9 @@ class BarcodeImageWriterTask extends AsyncTask<Void, Void, Bitmap>
return bitmap;
}
catch (WriterException | IllegalArgumentException e)
catch (WriterException e)
{
Log.e(TAG, "Failed to generate barcode", e);
Log.e(TAG, "Failed to generate barcode of type " + format + ": " + cardId, e);
}
return null;