From c5c2f702d0ef1f530c1ed76fe9311bb08da577db Mon Sep 17 00:00:00 2001 From: Sylvia van Os Date: Fri, 27 Dec 2019 17:14:07 +0100 Subject: [PATCH 1/9] Up targetSdk for Google Play --- app/build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 5c5b3621a..c6b7edb68 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -7,12 +7,12 @@ findbugs { } android { - compileSdkVersion 27 + compileSdkVersion 28 defaultConfig { applicationId "protect.card_locker" minSdkVersion 16 - targetSdkVersion 27 + targetSdkVersion 28 versionCode 35 versionName "0.25.4" } From 1a3dee2c2664c630ddda0ca0f85c955987c2ec2d Mon Sep 17 00:00:00 2001 From: Sylvia van Os Date: Fri, 27 Dec 2019 17:27:40 +0100 Subject: [PATCH 2/9] Update support libraries --- app/build.gradle | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index c6b7edb68..2d4a28c42 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -41,9 +41,9 @@ android { dependencies { compile fileTree(dir: 'libs', include: ['*.jar']) - compile 'com.android.support:appcompat-v7:27.0.2' - compile 'com.android.support:design:27.0.2' - compile 'com.android.support:support-v4:27.0.2' + compile 'com.android.support:appcompat-v7:28.0.0' + compile 'com.android.support:design:28.0.0' + compile 'com.android.support:support-v4:28.0.0' compile 'com.journeyapps:zxing-android-embedded:3.5.0@aar' compile 'com.google.zxing:core:3.3.0' compile 'org.apache.commons:commons-csv:1.5' From d9f97380d9cf2980a83b30f95c3ab159835ecb93 Mon Sep 17 00:00:00 2001 From: Sylvia van Os Date: Fri, 27 Dec 2019 17:34:58 +0100 Subject: [PATCH 3/9] Fix status bar being white --- .../main/java/protect/card_locker/LoyaltyCardViewActivity.java | 1 + app/src/main/res/values-v21/styles.xml | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java b/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java index 65b54000f..12340315e 100644 --- a/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java +++ b/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java @@ -198,6 +198,7 @@ public class LoyaltyCardViewActivity extends AppCompatActivity // Make notification area light if dark icons are needed window.getDecorView().setSystemUiVisibility(backgroundNeedsDarkIcons ? View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR : 0); + window.setStatusBarColor(Color.TRANSPARENT); // Set shadow colour of store text so even same color on same color would be readable storeName.setShadowLayer(1, 1, 1, backgroundNeedsDarkIcons ? Color.BLACK : Color.WHITE); diff --git a/app/src/main/res/values-v21/styles.xml b/app/src/main/res/values-v21/styles.xml index 251fb9fb7..7475e9d6f 100644 --- a/app/src/main/res/values-v21/styles.xml +++ b/app/src/main/res/values-v21/styles.xml @@ -4,6 +4,5 @@ false true true - @android:color/transparent From 32b417895072c6bff38fc748fbc1081ab6cc2a9d Mon Sep 17 00:00:00 2001 From: Sylvia van Os Date: Fri, 27 Dec 2019 17:40:12 +0100 Subject: [PATCH 4/9] Fix some warnings --- .../card_locker/LoyaltyCardViewActivity.java | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java b/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java index 12340315e..ea889a161 100644 --- a/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java +++ b/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java @@ -197,8 +197,14 @@ public class LoyaltyCardViewActivity extends AppCompatActivity } // Make notification area light if dark icons are needed - window.getDecorView().setSystemUiVisibility(backgroundNeedsDarkIcons ? View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR : 0); - window.setStatusBarColor(Color.TRANSPARENT); + if(Build.VERSION.SDK_INT >= 23) + { + window.getDecorView().setSystemUiVisibility(backgroundNeedsDarkIcons ? View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR : 0); + } + if(Build.VERSION.SDK_INT >= 21) + { + window.setStatusBarColor(Color.TRANSPARENT); + } // Set shadow colour of store text so even same color on same color would be readable storeName.setShadowLayer(1, 1, 1, backgroundNeedsDarkIcons ? Color.BLACK : Color.WHITE); @@ -217,14 +223,7 @@ public class LoyaltyCardViewActivity extends AppCompatActivity @Override public void onGlobalLayout() { - if (Build.VERSION.SDK_INT < 16) - { - barcodeImage.getViewTreeObserver().removeGlobalOnLayoutListener(this); - } - else - { - barcodeImage.getViewTreeObserver().removeOnGlobalLayoutListener(this); - } + barcodeImage.getViewTreeObserver().removeOnGlobalLayoutListener(this); Log.d(TAG, "ImageView size now known"); new BarcodeImageWriterTask(barcodeImage, cardIdString, format).execute(); From b9d158583b3840ccda92bc0f6363c3ee0c2f89d9 Mon Sep 17 00:00:00 2001 From: Branden Archer Date: Sat, 28 Dec 2019 10:46:52 -0800 Subject: [PATCH 5/9] Update to AndroidX This is mostly the work of Android Studio's Refactor > Migrate to AndroidX... option. That mostly worked. The two places which were manually updated were: - The reference to AppBarLayout$ScrollingViewBehavior in loyalty_card_edit_activity.xml - The suggested constraintlayout version, 2.0.0-beta4 caused build issues that 1.1.3 avoids --- app/build.gradle | 8 ++--- app/src/main/AndroidManifest.xml | 2 +- .../card_locker/BarcodeSelectorActivity.java | 6 ++-- .../card_locker/CardShortcutConfigure.java | 4 +-- .../card_locker/ImportExportActivity.java | 17 +++++---- .../java/protect/card_locker/LoyaltyCard.java | 2 +- .../card_locker/LoyaltyCardEditActivity.java | 10 +++--- .../LoyaltyCardLockerApplication.java | 2 +- .../card_locker/LoyaltyCardViewActivity.java | 14 ++++---- .../protect/card_locker/MainActivity.java | 12 +++---- .../card_locker/intro/IntroActivity.java | 2 +- .../card_locker/intro/IntroSlide1.java | 2 +- .../card_locker/intro/IntroSlide2.java | 2 +- .../card_locker/intro/IntroSlide3.java | 2 +- .../card_locker/intro/IntroSlide4.java | 2 +- .../card_locker/intro/IntroSlide5.java | 2 +- .../card_locker/intro/IntroSlide6.java | 2 +- .../card_locker/preferences/Settings.java | 6 ++-- .../preferences/SettingsActivity.java | 6 ++-- .../res/layout/barcode_selector_activity.xml | 18 +++++----- .../res/layout/import_export_activity.xml | 18 +++++----- .../res/layout/loyalty_card_edit_activity.xml | 36 +++++++++---------- .../res/layout/loyalty_card_view_layout.xml | 20 +++++------ app/src/main/res/layout/main_activity.xml | 10 +++--- app/src/main/res/menu/main_menu.xml | 2 +- .../LoyaltyCardViewActivityTest.java | 2 +- .../protect/card_locker/MainActivityTest.java | 2 +- gradle.properties | 2 ++ 28 files changed, 106 insertions(+), 107 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 2d4a28c42..4ac7af80b 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -41,13 +41,13 @@ android { dependencies { compile fileTree(dir: 'libs', include: ['*.jar']) - compile 'com.android.support:appcompat-v7:28.0.0' - compile 'com.android.support:design:28.0.0' - compile 'com.android.support:support-v4:28.0.0' + compile 'androidx.appcompat:appcompat:1.2.0-alpha01' + compile 'com.google.android.material:material:1.2.0-alpha03' + compile 'androidx.legacy:legacy-support-v4:1.0.0' compile 'com.journeyapps:zxing-android-embedded:3.5.0@aar' compile 'com.google.zxing:core:3.3.0' compile 'org.apache.commons:commons-csv:1.5' - compile 'com.android.support.constraint:constraint-layout:1.0.2' + compile 'androidx.constraintlayout:constraintlayout:1.1.3' compile 'com.jaredrummler:colorpicker:1.0.2' compile group: 'com.google.guava', name: 'guava', version: '20.0' compile 'com.github.apl-devs:appintro:v4.2.0' diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 7a0e0be6a..d5d7644e0 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -86,7 +86,7 @@ diff --git a/app/src/main/java/protect/card_locker/BarcodeSelectorActivity.java b/app/src/main/java/protect/card_locker/BarcodeSelectorActivity.java index 86c647c3b..18becdcc6 100644 --- a/app/src/main/java/protect/card_locker/BarcodeSelectorActivity.java +++ b/app/src/main/java/protect/card_locker/BarcodeSelectorActivity.java @@ -5,9 +5,9 @@ import android.content.Intent; import android.os.AsyncTask; import android.os.Build; import android.os.Bundle; -import android.support.v7.app.ActionBar; -import android.support.v7.app.AppCompatActivity; -import android.support.v7.widget.Toolbar; +import androidx.appcompat.app.ActionBar; +import androidx.appcompat.app.AppCompatActivity; +import androidx.appcompat.widget.Toolbar; import android.text.Editable; import android.text.TextWatcher; import android.util.Log; diff --git a/app/src/main/java/protect/card_locker/CardShortcutConfigure.java b/app/src/main/java/protect/card_locker/CardShortcutConfigure.java index 3e2c8f639..2917d703d 100644 --- a/app/src/main/java/protect/card_locker/CardShortcutConfigure.java +++ b/app/src/main/java/protect/card_locker/CardShortcutConfigure.java @@ -4,8 +4,8 @@ import android.content.Intent; import android.database.Cursor; import android.os.Bundle; import android.os.Parcelable; -import android.support.v7.app.AppCompatActivity; -import android.support.v7.widget.Toolbar; +import androidx.appcompat.app.AppCompatActivity; +import androidx.appcompat.widget.Toolbar; import android.util.Log; import android.view.View; import android.widget.AdapterView; diff --git a/app/src/main/java/protect/card_locker/ImportExportActivity.java b/app/src/main/java/protect/card_locker/ImportExportActivity.java index e0be204cc..bd8fac2d3 100644 --- a/app/src/main/java/protect/card_locker/ImportExportActivity.java +++ b/app/src/main/java/protect/card_locker/ImportExportActivity.java @@ -7,19 +7,18 @@ import android.content.DialogInterface; import android.content.Intent; import android.content.pm.PackageManager; import android.content.pm.ResolveInfo; -import android.database.Cursor; import android.net.Uri; import android.os.AsyncTask; import android.os.Bundle; import android.os.Environment; -import android.provider.OpenableColumns; -import android.support.v4.app.ActivityCompat; -import android.support.v4.content.ContextCompat; -import android.support.v4.content.FileProvider; -import android.support.v7.app.ActionBar; -import android.support.v7.app.AlertDialog; -import android.support.v7.app.AppCompatActivity; -import android.support.v7.widget.Toolbar; + +import androidx.core.app.ActivityCompat; +import androidx.core.content.ContextCompat; +import androidx.core.content.FileProvider; +import androidx.appcompat.app.ActionBar; +import androidx.appcompat.app.AlertDialog; +import androidx.appcompat.app.AppCompatActivity; +import androidx.appcompat.widget.Toolbar; import android.util.Log; import android.view.MenuItem; import android.view.View; diff --git a/app/src/main/java/protect/card_locker/LoyaltyCard.java b/app/src/main/java/protect/card_locker/LoyaltyCard.java index a1dac3a69..152d15d35 100644 --- a/app/src/main/java/protect/card_locker/LoyaltyCard.java +++ b/app/src/main/java/protect/card_locker/LoyaltyCard.java @@ -1,7 +1,7 @@ package protect.card_locker; import android.database.Cursor; -import android.support.annotation.Nullable; +import androidx.annotation.Nullable; public class LoyaltyCard { diff --git a/app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java b/app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java index bb185b857..4cf69b92c 100644 --- a/app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java +++ b/app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java @@ -8,11 +8,11 @@ import android.graphics.Color; import android.net.Uri; import android.os.Build; import android.os.Bundle; -import android.support.design.widget.Snackbar; -import android.support.v7.app.ActionBar; -import android.support.v7.app.AlertDialog; -import android.support.v7.app.AppCompatActivity; -import android.support.v7.widget.Toolbar; +import com.google.android.material.snackbar.Snackbar; +import androidx.appcompat.app.ActionBar; +import androidx.appcompat.app.AlertDialog; +import androidx.appcompat.app.AppCompatActivity; +import androidx.appcompat.widget.Toolbar; import android.util.Log; import android.view.Menu; import android.view.MenuItem; diff --git a/app/src/main/java/protect/card_locker/LoyaltyCardLockerApplication.java b/app/src/main/java/protect/card_locker/LoyaltyCardLockerApplication.java index c53584520..0705435fc 100644 --- a/app/src/main/java/protect/card_locker/LoyaltyCardLockerApplication.java +++ b/app/src/main/java/protect/card_locker/LoyaltyCardLockerApplication.java @@ -1,7 +1,7 @@ package protect.card_locker; import android.app.Application; -import android.support.v7.app.AppCompatDelegate; +import androidx.appcompat.app.AppCompatDelegate; import protect.card_locker.preferences.Settings; diff --git a/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java b/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java index ea889a161..592b564b1 100644 --- a/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java +++ b/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java @@ -7,13 +7,13 @@ import android.graphics.Color; import android.graphics.drawable.Drawable; import android.os.Build; import android.os.Bundle; -import android.support.v4.graphics.ColorUtils; -import android.support.v4.graphics.drawable.DrawableCompat; -import android.support.v4.widget.TextViewCompat; -import android.support.v7.app.ActionBar; -import android.support.v7.app.AppCompatActivity; -import android.support.v7.content.res.AppCompatResources; -import android.support.v7.widget.Toolbar; +import androidx.core.graphics.ColorUtils; +import androidx.core.graphics.drawable.DrawableCompat; +import androidx.core.widget.TextViewCompat; +import androidx.appcompat.app.ActionBar; +import androidx.appcompat.app.AppCompatActivity; +import androidx.appcompat.content.res.AppCompatResources; +import androidx.appcompat.widget.Toolbar; import android.util.Log; import android.util.TypedValue; import android.view.Menu; diff --git a/app/src/main/java/protect/card_locker/MainActivity.java b/app/src/main/java/protect/card_locker/MainActivity.java index 68b736ca1..bc7abf2eb 100644 --- a/app/src/main/java/protect/card_locker/MainActivity.java +++ b/app/src/main/java/protect/card_locker/MainActivity.java @@ -11,13 +11,12 @@ import android.content.pm.PackageInfo; import android.content.pm.PackageManager; import android.content.res.Configuration; import android.database.Cursor; -import android.net.Uri; import android.os.Bundle; -import android.support.v7.app.AlertDialog; -import android.support.v7.app.AppCompatActivity; -import android.support.v7.app.AppCompatDelegate; -import android.support.v7.widget.SearchView; -import android.support.v7.widget.Toolbar; +import androidx.appcompat.app.AlertDialog; +import androidx.appcompat.app.AppCompatActivity; +import androidx.appcompat.app.AppCompatDelegate; +import androidx.appcompat.widget.SearchView; +import androidx.appcompat.widget.Toolbar; import android.util.Log; import android.view.ContextMenu; import android.view.Menu; @@ -36,7 +35,6 @@ import java.util.Calendar; import java.util.Map; import protect.card_locker.intro.IntroActivity; -import protect.card_locker.preferences.Settings; import protect.card_locker.preferences.SettingsActivity; public class MainActivity extends AppCompatActivity diff --git a/app/src/main/java/protect/card_locker/intro/IntroActivity.java b/app/src/main/java/protect/card_locker/intro/IntroActivity.java index d34b0b05d..37a699ed8 100644 --- a/app/src/main/java/protect/card_locker/intro/IntroActivity.java +++ b/app/src/main/java/protect/card_locker/intro/IntroActivity.java @@ -1,7 +1,7 @@ package protect.card_locker.intro; import android.os.Bundle; -import android.support.v4.app.Fragment; +import androidx.fragment.app.Fragment; import com.github.paolorotolo.appintro.AppIntro; diff --git a/app/src/main/java/protect/card_locker/intro/IntroSlide1.java b/app/src/main/java/protect/card_locker/intro/IntroSlide1.java index 7e53d7652..beecb43c3 100644 --- a/app/src/main/java/protect/card_locker/intro/IntroSlide1.java +++ b/app/src/main/java/protect/card_locker/intro/IntroSlide1.java @@ -1,7 +1,7 @@ package protect.card_locker.intro; import android.os.Bundle; -import android.support.v4.app.Fragment; +import androidx.fragment.app.Fragment; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; diff --git a/app/src/main/java/protect/card_locker/intro/IntroSlide2.java b/app/src/main/java/protect/card_locker/intro/IntroSlide2.java index 6ee1952b7..a1e652c51 100644 --- a/app/src/main/java/protect/card_locker/intro/IntroSlide2.java +++ b/app/src/main/java/protect/card_locker/intro/IntroSlide2.java @@ -1,7 +1,7 @@ package protect.card_locker.intro; import android.os.Bundle; -import android.support.v4.app.Fragment; +import androidx.fragment.app.Fragment; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; diff --git a/app/src/main/java/protect/card_locker/intro/IntroSlide3.java b/app/src/main/java/protect/card_locker/intro/IntroSlide3.java index deb6927b0..5acc83e7b 100644 --- a/app/src/main/java/protect/card_locker/intro/IntroSlide3.java +++ b/app/src/main/java/protect/card_locker/intro/IntroSlide3.java @@ -1,7 +1,7 @@ package protect.card_locker.intro; import android.os.Bundle; -import android.support.v4.app.Fragment; +import androidx.fragment.app.Fragment; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; diff --git a/app/src/main/java/protect/card_locker/intro/IntroSlide4.java b/app/src/main/java/protect/card_locker/intro/IntroSlide4.java index d47a5ac8e..1a7ad6e69 100644 --- a/app/src/main/java/protect/card_locker/intro/IntroSlide4.java +++ b/app/src/main/java/protect/card_locker/intro/IntroSlide4.java @@ -1,7 +1,7 @@ package protect.card_locker.intro; import android.os.Bundle; -import android.support.v4.app.Fragment; +import androidx.fragment.app.Fragment; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; diff --git a/app/src/main/java/protect/card_locker/intro/IntroSlide5.java b/app/src/main/java/protect/card_locker/intro/IntroSlide5.java index 6127ab1ba..ab3b5b757 100644 --- a/app/src/main/java/protect/card_locker/intro/IntroSlide5.java +++ b/app/src/main/java/protect/card_locker/intro/IntroSlide5.java @@ -1,7 +1,7 @@ package protect.card_locker.intro; import android.os.Bundle; -import android.support.v4.app.Fragment; +import androidx.fragment.app.Fragment; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; diff --git a/app/src/main/java/protect/card_locker/intro/IntroSlide6.java b/app/src/main/java/protect/card_locker/intro/IntroSlide6.java index d3fba4f98..217967844 100644 --- a/app/src/main/java/protect/card_locker/intro/IntroSlide6.java +++ b/app/src/main/java/protect/card_locker/intro/IntroSlide6.java @@ -1,7 +1,7 @@ package protect.card_locker.intro; import android.os.Bundle; -import android.support.v4.app.Fragment; +import androidx.fragment.app.Fragment; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; diff --git a/app/src/main/java/protect/card_locker/preferences/Settings.java b/app/src/main/java/protect/card_locker/preferences/Settings.java index f6c9fb026..586e18769 100644 --- a/app/src/main/java/protect/card_locker/preferences/Settings.java +++ b/app/src/main/java/protect/card_locker/preferences/Settings.java @@ -3,9 +3,9 @@ package protect.card_locker.preferences; import android.content.Context; import android.content.SharedPreferences; import android.preference.PreferenceManager; -import android.support.annotation.IntegerRes; -import android.support.annotation.StringRes; -import android.support.v7.app.AppCompatDelegate; +import androidx.annotation.IntegerRes; +import androidx.annotation.StringRes; +import androidx.appcompat.app.AppCompatDelegate; import protect.card_locker.R; diff --git a/app/src/main/java/protect/card_locker/preferences/SettingsActivity.java b/app/src/main/java/protect/card_locker/preferences/SettingsActivity.java index ee1bccbbb..485626742 100644 --- a/app/src/main/java/protect/card_locker/preferences/SettingsActivity.java +++ b/app/src/main/java/protect/card_locker/preferences/SettingsActivity.java @@ -3,9 +3,9 @@ package protect.card_locker.preferences; import android.os.Bundle; import android.preference.Preference; import android.preference.PreferenceFragment; -import android.support.v7.app.ActionBar; -import android.support.v7.app.AppCompatActivity; -import android.support.v7.app.AppCompatDelegate; +import androidx.appcompat.app.ActionBar; +import androidx.appcompat.app.AppCompatActivity; +import androidx.appcompat.app.AppCompatDelegate; import android.view.MenuItem; import protect.card_locker.R; diff --git a/app/src/main/res/layout/barcode_selector_activity.xml b/app/src/main/res/layout/barcode_selector_activity.xml index 248087cee..8edd3374f 100644 --- a/app/src/main/res/layout/barcode_selector_activity.xml +++ b/app/src/main/res/layout/barcode_selector_activity.xml @@ -1,23 +1,23 @@ - + - - - + - + diff --git a/app/src/main/res/layout/import_export_activity.xml b/app/src/main/res/layout/import_export_activity.xml index 7d3f7fc76..464b3657e 100644 --- a/app/src/main/res/layout/import_export_activity.xml +++ b/app/src/main/res/layout/import_export_activity.xml @@ -1,23 +1,23 @@ - + - - - + - + diff --git a/app/src/main/res/layout/loyalty_card_edit_activity.xml b/app/src/main/res/layout/loyalty_card_edit_activity.xml index 17897cff8..198a867b0 100644 --- a/app/src/main/res/layout/loyalty_card_edit_activity.xml +++ b/app/src/main/res/layout/loyalty_card_edit_activity.xml @@ -1,28 +1,28 @@ - + - - - + + app:layout_behavior="com.google.android.material.appbar.AppBarLayout$ScrollingViewBehavior"> - - - +