From 3c69990b0d234872616860a43cd9e358f21dabc9 Mon Sep 17 00:00:00 2001 From: Sylvia van Os Date: Thu, 3 Dec 2020 19:33:20 +0100 Subject: [PATCH] Make findBugs happy and improve bottom sheet logic --- .../card_locker/LoyaltyCardViewActivity.java | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java b/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java index 2a7bf0f0f..77b2b8d01 100644 --- a/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java +++ b/app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java @@ -152,18 +152,14 @@ public class LoyaltyCardViewActivity extends AppCompatActivity behavior.addBottomSheetCallback(new BottomSheetBehavior.BottomSheetCallback() { @Override public void onStateChanged(@NonNull View bottomSheet, int newState) { - switch (newState) { - case BottomSheetBehavior.STATE_COLLAPSED: - bottomSheetButton.setImageResource(R.drawable.ic_baseline_arrow_drop_up_24); - editButton.show(); - break; - case BottomSheetBehavior.STATE_EXPANDED: - bottomSheetButton.setImageResource(R.drawable.ic_baseline_arrow_drop_down_24); - editButton.hide(); - break; - case BottomSheetBehavior.STATE_HIDDEN: - editButton.show(); - break; + if (newState == BottomSheetBehavior.STATE_DRAGGING) { + editButton.hide(); + } else if (newState == BottomSheetBehavior.STATE_EXPANDED) { + bottomSheetButton.setImageResource(R.drawable.ic_baseline_arrow_drop_down_24); + editButton.hide(); + } else if (newState == BottomSheetBehavior.STATE_COLLAPSED) { + bottomSheetButton.setImageResource(R.drawable.ic_baseline_arrow_drop_up_24); + editButton.show(); } }