From 653606fae3b0076a9ed16f64347daa52cdeb7729 Mon Sep 17 00:00:00 2001
From: Pfaffenrodt <dimitri@pfaffenrodt.de>
Date: Sat, 29 Oct 2022 13:36:22 +0200
Subject: [PATCH] Extract show credits dialog. remove empty listener

---
 .../java/protect/card_locker/AboutActivity.java  | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/app/src/main/java/protect/card_locker/AboutActivity.java b/app/src/main/java/protect/card_locker/AboutActivity.java
index ca59bd18e..c63ec5e60 100644
--- a/app/src/main/java/protect/card_locker/AboutActivity.java
+++ b/app/src/main/java/protect/card_locker/AboutActivity.java
@@ -64,13 +64,7 @@ public class AboutActivity extends CatimaAppCompatActivity {
         binding.reportError.setOnClickListener(openExternalBrowser);
         binding.rate.setOnClickListener(openExternalBrowser);
 
-        binding.credits
-                .setOnClickListener(view -> new MaterialAlertDialogBuilder(this)
-                        .setTitle(R.string.credits)
-                        .setMessage(content.getContributorInfo())
-                        .setPositiveButton(R.string.ok, (dialogInterface, i) -> {
-                        })
-                        .show());
+        binding.credits.setOnClickListener(view -> showCredits());
     }
 
     private void clearClickListeners() {
@@ -83,4 +77,12 @@ public class AboutActivity extends CatimaAppCompatActivity {
         binding.rate.setOnClickListener(null);
         binding.credits.setOnClickListener(null);
     }
+
+    private void showCredits() {
+        new MaterialAlertDialogBuilder(this)
+                .setTitle(R.string.credits)
+                .setMessage(content.getContributorInfo())
+                .setPositiveButton(R.string.ok, null)
+                .show();
+    }
 }