diff --git a/CHANGELOG.md b/CHANGELOG.md index 5947ae6af..8ef087770 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +Changes: + +- Fix selected colour in colour changing dialog + ## v2.0.4 (2021-07-27) Changes: diff --git a/app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java b/app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java index 45c368fc7..a88812c8d 100644 --- a/app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java +++ b/app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java @@ -640,7 +640,7 @@ public class LoyaltyCardEditActivity extends AppCompatActivity // It can't be null because we set it in updateTempState but SpotBugs insists it can be // NP_NULL_ON_SOME_PATH: Possible null pointer dereference if(tempLoyaltyCard.headerColor != null) { - thumbnail.setOnClickListener(new ColorSelectListener(tempLoyaltyCard.headerColor)); + thumbnail.setOnClickListener(new ColorSelectListener()); } // Update from intent @@ -896,17 +896,16 @@ public class LoyaltyCardEditActivity extends AppCompatActivity class ColorSelectListener implements View.OnClickListener { - final int defaultColor; - - ColorSelectListener(int defaultColor) - { - this.defaultColor = defaultColor; - } - @Override public void onClick(View v) { - ColorPickerDialog dialog = ColorPickerDialog.newBuilder().setColor(defaultColor).create(); + ColorPickerDialog.Builder dialogBuilder = ColorPickerDialog.newBuilder(); + + if (tempLoyaltyCard.headerColor != null) { + dialogBuilder.setColor(tempLoyaltyCard.headerColor); + } + + ColorPickerDialog dialog = dialogBuilder.create(); dialog.setColorPickerDialogListener(new ColorPickerDialogListener() { @Override