From 7a361c9afe55af9435a000aab90351b405d289ea Mon Sep 17 00:00:00 2001 From: Sylvia van Os Date: Fri, 1 Sep 2023 19:40:09 +0200 Subject: [PATCH] CI cleanups --- .github/workflows/android.yml | 9 ++--- .github/workflows/autoclose-needs-info.yml | 22 ------------ .../workflows/calibreapp-image-actions.yml | 34 ------------------- .github/workflows/changelog-to-fastlane.yml | 7 ++-- .github/workflows/contributors-to-file.yml | 4 +-- .../workflows/generate-feature-graphic.yml | 4 +-- .../workflows/gradle-wrapper-validation.yml | 10 ------ 7 files changed, 9 insertions(+), 81 deletions(-) delete mode 100644 .github/workflows/autoclose-needs-info.yml delete mode 100644 .github/workflows/calibreapp-image-actions.yml delete mode 100644 .github/workflows/gradle-wrapper-validation.yml diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml index ecd5b72c9..2068a461d 100644 --- a/.github/workflows/android.yml +++ b/.github/workflows/android.yml @@ -1,5 +1,4 @@ name: Android CI - on: push: branches: @@ -9,17 +8,13 @@ on: pull_request: branches: - main - env: JAVA_HOME: /usr/lib/jvm/java-17-openjdk-amd64 - jobs: build: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Fail on bad translations run: if grep -ri "<xliff" app/src/main/res/values*/strings.xml; then echo "Invalidly escaped translations found"; exit 1; fi - uses: gradle/wrapper-validation-action@v1 @@ -38,7 +33,7 @@ jobs: run: ./gradlew spotbugsRelease - name: Archive test results if: always() - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: test-results path: app/build/reports diff --git a/.github/workflows/autoclose-needs-info.yml b/.github/workflows/autoclose-needs-info.yml deleted file mode 100644 index 2ae68b1b9..000000000 --- a/.github/workflows/autoclose-needs-info.yml +++ /dev/null @@ -1,22 +0,0 @@ -name: 'Close issues and PRs needing info for too long' -on: - schedule: - - cron: '30 1 * * *' - -permissions: - issues: write - pull-requests: write - -jobs: - stale: - runs-on: ubuntu-latest - steps: - - uses: actions/stale@v4 - with: - days-before-close: 90 - stale-issue-message: "" - stale-pr-message: "" - close-issue-message: 'This issue is missing necessary information and cannot be worked on in its current state. It has therefore been closed to keep the issue tracker clean. If you have more information, feel free to reopen it.' - close-pr-message: 'This PR is missing necessary information and cannot be merged in its current state. It has therefore been closed to keep the issue tracker clean. If you have more information, feel free to reopen it.' - only-labels: 'state: needs info' - enable-statistics: true diff --git a/.github/workflows/calibreapp-image-actions.yml b/.github/workflows/calibreapp-image-actions.yml deleted file mode 100644 index fb3e58eb3..000000000 --- a/.github/workflows/calibreapp-image-actions.yml +++ /dev/null @@ -1,34 +0,0 @@ -name: Compress Images on Push to Main -on: - push: - branches: - - main - paths: - - '**.jpg' - - '**.jpeg' - - '**.png' - - '**.webp' -jobs: - build: - # Only run on Pull Requests within the same repository, and not from forks. - if: github.event.pull_request.head.repo.full_name == github.repository - name: calibreapp/image-actions - runs-on: ubuntu-latest - steps: - - name: Checkout Repo - uses: actions/checkout@v2 - - name: Compress Images - id: calibre - uses: calibreapp/image-actions@1.1.0 - with: - githubToken: ${{ secrets.GITHUB_TOKEN }} - ignorePaths: 'app/src/test' - compressOnly: true - - name: Create New Pull Request If Needed - if: steps.calibre.outputs.markdown != '' - uses: peter-evans/create-pull-request@v3 - with: - title: Compressed Images - branch-suffix: timestamp - commit-message: Compressed Images - body: ${{ steps.calibre.outputs.markdown }} diff --git a/.github/workflows/changelog-to-fastlane.yml b/.github/workflows/changelog-to-fastlane.yml index 3772f598c..764135140 100644 --- a/.github/workflows/changelog-to-fastlane.yml +++ b/.github/workflows/changelog-to-fastlane.yml @@ -3,7 +3,6 @@ on: push: branches: - main - jobs: convert_changelog_to_fastlane: runs-on: ubuntu-latest @@ -11,15 +10,15 @@ jobs: steps: - name: Checkout repo id: checkout - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Setup Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: '3.x' - name: Run converter script run: python .scripts/changelog_to_fastlane.py - name: Create Pull Request - uses: peter-evans/create-pull-request@v3 + uses: peter-evans/create-pull-request@v5 with: title: "Update Fastlane changelogs" commit-message: "Update Fastlane changelogs" diff --git a/.github/workflows/contributors-to-file.yml b/.github/workflows/contributors-to-file.yml index bc57d9a5d..640e9db0c 100644 --- a/.github/workflows/contributors-to-file.yml +++ b/.github/workflows/contributors-to-file.yml @@ -11,14 +11,14 @@ jobs: steps: - name: Checkout repo id: checkout - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Update contributors id: update_contributors uses: TheLastProject/contributors-to-file-action@v2 with: file_in_repo: app/src/main/res/raw/contributors.txt - name: Create Pull Request - uses: peter-evans/create-pull-request@v3 + uses: peter-evans/create-pull-request@v5 with: title: "Update contributors" commit-message: "Update contributors" diff --git a/.github/workflows/generate-feature-graphic.yml b/.github/workflows/generate-feature-graphic.yml index 2d67e6f13..e2dd37a40 100644 --- a/.github/workflows/generate-feature-graphic.yml +++ b/.github/workflows/generate-feature-graphic.yml @@ -9,7 +9,7 @@ jobs: generate-feature-graphic: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Install requirements run: | sudo apt-get update @@ -53,7 +53,7 @@ jobs: popd done - name: Create Pull Request - uses: peter-evans/create-pull-request@v3 + uses: peter-evans/create-pull-request@v5 with: title: "Update feature graphic" commit-message: "Update feature graphic" diff --git a/.github/workflows/gradle-wrapper-validation.yml b/.github/workflows/gradle-wrapper-validation.yml deleted file mode 100644 index 8bfd0dcf5..000000000 --- a/.github/workflows/gradle-wrapper-validation.yml +++ /dev/null @@ -1,10 +0,0 @@ -name: "Validate Gradle Wrapper" -on: [push, pull_request] - -jobs: - validation: - name: "Validation" - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - uses: gradle/wrapper-validation-action@v1