From f3e1bfc503c07a04cd97d239bd1acf0f7b25cd88 Mon Sep 17 00:00:00 2001
From: Sylvia van Os <sylvia@hackerchick.me>
Date: Mon, 29 May 2023 19:37:03 +0200
Subject: [PATCH] Improve button styling in Groups screen

---
 CHANGELOG.md                                  |  1 +
 .../card_locker/GroupCursorAdapter.java       |  3 +-
 app/src/main/res/layout/group_layout.xml      | 44 ++++++++++++-------
 3 files changed, 31 insertions(+), 17 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a51041b0e..4cfa7ced9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Unreleased - 122
 
 - Long-press card icon in view activity to change it
+- Improve button styling in Groups screen
 
 ## v2.23.1 - 121
 
diff --git a/app/src/main/java/protect/card_locker/GroupCursorAdapter.java b/app/src/main/java/protect/card_locker/GroupCursorAdapter.java
index 33460aae9..2e7926d75 100644
--- a/app/src/main/java/protect/card_locker/GroupCursorAdapter.java
+++ b/app/src/main/java/protect/card_locker/GroupCursorAdapter.java
@@ -7,6 +7,7 @@ import android.database.sqlite.SQLiteDatabase;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
+import android.widget.Button;
 import android.widget.ImageButton;
 import android.widget.TextView;
 
@@ -84,7 +85,7 @@ public class GroupCursorAdapter extends BaseCursorAdapter<GroupCursorAdapter.Gro
 
     public static class GroupListItemViewHolder extends RecyclerView.ViewHolder {
         public TextView mName, mCardCount;
-        public ImageButton mMoveUp, mMoveDown, mEdit, mDelete;
+        public Button mMoveUp, mMoveDown, mEdit, mDelete;
 
         public GroupListItemViewHolder(GroupLayoutBinding groupLayoutBinding) {
             super(groupLayoutBinding.getRoot());
diff --git a/app/src/main/res/layout/group_layout.xml b/app/src/main/res/layout/group_layout.xml
index d0e7134d3..c798ab552 100644
--- a/app/src/main/res/layout/group_layout.xml
+++ b/app/src/main/res/layout/group_layout.xml
@@ -37,36 +37,48 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content">
 
-        <ImageButton
+        <Button
             android:id="@+id/moveUp"
-            android:layout_width="@dimen/cardThumbnailSize"
-            android:layout_height="@dimen/cardThumbnailSize"
+            style="?attr/materialIconButtonFilledStyle"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
             android:layout_weight="1"
-            app:srcCompat="@drawable/ic_baseline_arrow_drop_up_24"
+            app:icon="@drawable/ic_baseline_arrow_drop_up_24"
+            app:iconGravity="textStart"
+            app:tint="?attr/colorOnPrimary"
             android:contentDescription="@string/moveUp"/>
 
-        <ImageButton
+        <Button
             android:id="@+id/moveDown"
-            android:layout_width="@dimen/cardThumbnailSize"
-            android:layout_height="@dimen/cardThumbnailSize"
+            style="?attr/materialIconButtonFilledStyle"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
             android:layout_weight="1"
-            app:srcCompat="@drawable/ic_baseline_arrow_drop_down_24"
+            app:icon="@drawable/ic_baseline_arrow_drop_down_24"
+            app:iconGravity="textStart"
+            app:tint="?attr/colorOnPrimary"
             android:contentDescription="@string/moveDown"/>
 
-        <ImageButton
+        <Button
             android:id="@+id/edit"
-            android:layout_width="@dimen/cardThumbnailSize"
-            android:layout_height="@dimen/cardThumbnailSize"
+            style="?attr/materialIconButtonFilledStyle"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
             android:layout_weight="1"
-            app:srcCompat="@drawable/ic_mode_edit_white_24dp"
+            app:icon="@drawable/ic_mode_edit_white_24dp"
+            app:iconGravity="textStart"
+            app:tint="?attr/colorOnPrimary"
             android:contentDescription="@string/edit"/>
 
-        <ImageButton
+        <Button
             android:id="@+id/delete"
-            android:layout_width="@dimen/cardThumbnailSize"
-            android:layout_height="@dimen/cardThumbnailSize"
+            style="?attr/materialIconButtonFilledStyle"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
             android:layout_weight="1"
-            app:srcCompat="@drawable/ic_delete_white_24dp"
+            app:icon="@drawable/ic_delete_white_24dp"
+            app:iconGravity="textStart"
+            app:tint="?attr/colorOnPrimary"
             android:contentDescription="@string/delete"/>
 
     </LinearLayout>