From 09136efded874152bcd76f9efd79aa1e6a974026 Mon Sep 17 00:00:00 2001
From: Sergey Eremin <yeriomin@gmail.com>
Date: Tue, 29 Aug 2017 17:41:19 +0300
Subject: [PATCH] "Check updates" button will now show "Checking..." status
 only if it is really checking for updates

Since the button has to be disabled while app list is compiled, users
are confused by the "Checking..." status. The button will just show
ellipsis now while the app list is being built.
---
 .../yalpstore/ForegroundUpdatableAppsTask.java         | 10 +++++++++-
 .../github/yeriomin/yalpstore/UpdatableAppsTask.java   |  1 +
 app/src/main/res/values/donottranslate.xml             |  1 +
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/com/github/yeriomin/yalpstore/ForegroundUpdatableAppsTask.java b/app/src/main/java/com/github/yeriomin/yalpstore/ForegroundUpdatableAppsTask.java
index 3c4cdeac1..7a87375b2 100644
--- a/app/src/main/java/com/github/yeriomin/yalpstore/ForegroundUpdatableAppsTask.java
+++ b/app/src/main/java/com/github/yeriomin/yalpstore/ForegroundUpdatableAppsTask.java
@@ -42,7 +42,7 @@ class ForegroundUpdatableAppsTask extends UpdatableAppsTask {
         super.onPreExecute();
         Button button = activity.findViewById(R.id.check_updates);
         button.setEnabled(false);
-        button.setText(R.string.details_download_checking);
+        button.setText(R.string.ellipsis);
     }
 
     @Override
@@ -69,6 +69,14 @@ class ForegroundUpdatableAppsTask extends UpdatableAppsTask {
         button.setText(R.string.list_check_updates);
     }
 
+    @Override
+    protected void onProgressUpdate(Void... values) {
+        super.onProgressUpdate(values);
+        Button button = activity.findViewById(R.id.check_updates);
+        button.setEnabled(false);
+        button.setText(R.string.details_download_checking);
+    }
+
     private App getSelf() {
         if (installedApps.containsKey(BuildConfig.APPLICATION_ID)) {
             return installedApps.get(BuildConfig.APPLICATION_ID);
diff --git a/app/src/main/java/com/github/yeriomin/yalpstore/UpdatableAppsTask.java b/app/src/main/java/com/github/yeriomin/yalpstore/UpdatableAppsTask.java
index ff2e0ff2a..dace0aaac 100644
--- a/app/src/main/java/com/github/yeriomin/yalpstore/UpdatableAppsTask.java
+++ b/app/src/main/java/com/github/yeriomin/yalpstore/UpdatableAppsTask.java
@@ -87,6 +87,7 @@ public class UpdatableAppsTask extends GoogleApiAsyncTask {
             installedApps = filterSystemApps(installedApps);
         }
         // Requesting info from Google Play Market for installed apps
+        publishProgress();
         List<App> appsFromPlayStore = new ArrayList<>();
         try {
             appsFromPlayStore.addAll(getAppsFromPlayStore(filterBlacklistedApps(context, installedApps).keySet()));
diff --git a/app/src/main/res/values/donottranslate.xml b/app/src/main/res/values/donottranslate.xml
index 3a56bfade..0517758e5 100644
--- a/app/src/main/res/values/donottranslate.xml
+++ b/app/src/main/res/values/donottranslate.xml
@@ -23,4 +23,5 @@
     <string name="details_installs" translatable="false">"%1$s↓"</string>
     <string name="details_rating" translatable="false">"%1$.1f★"</string>
     <string name="details_rating_specific" translatable="false">"%1$d★ %2$d"</string>
+    <string name="ellipsis" translatable="false">"…"</string>
 </resources>
\ No newline at end of file