From 6e13bf8917a095fa1f7c0f009d83f536337342db Mon Sep 17 00:00:00 2001
From: Sergey Eremin <yeriomin@gmail.com>
Date: Sat, 27 May 2017 14:42:59 +0300
Subject: [PATCH] Minor lint fixes

---
 .../java/com/github/yeriomin/yalpstore/CategoryAppsTask.java  | 4 +---
 .../java/com/github/yeriomin/yalpstore/CategoryManager.java   | 4 +---
 .../github/yeriomin/yalpstore/NativeHttpClientAdapter.java    | 2 +-
 .../java/com/github/yeriomin/yalpstore/ReviewAddTask.java     | 1 -
 4 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/com/github/yeriomin/yalpstore/CategoryAppsTask.java b/app/src/main/java/com/github/yeriomin/yalpstore/CategoryAppsTask.java
index f75c1ce4f..a4d6120f8 100644
--- a/app/src/main/java/com/github/yeriomin/yalpstore/CategoryAppsTask.java
+++ b/app/src/main/java/com/github/yeriomin/yalpstore/CategoryAppsTask.java
@@ -21,9 +21,7 @@ class CategoryAppsTask extends GoogleApiAsyncTask {
             if (!iterator.hasNext()) {
                 return null;
             }
-            for (App app: iterator.next()) {
-                apps.add(app);
-            }
+            apps.addAll(iterator.next());
         } catch (Throwable e) {
             return e;
         }
diff --git a/app/src/main/java/com/github/yeriomin/yalpstore/CategoryManager.java b/app/src/main/java/com/github/yeriomin/yalpstore/CategoryManager.java
index c344994f3..fe6f1320d 100644
--- a/app/src/main/java/com/github/yeriomin/yalpstore/CategoryManager.java
+++ b/app/src/main/java/com/github/yeriomin/yalpstore/CategoryManager.java
@@ -21,12 +21,10 @@ public class CategoryManager {
 
     private Activity activity;
     private SharedPreferencesTranslator translator;
-    private SharedPreferences prefs;
 
     public CategoryManager(Activity activity) {
         this.activity = activity;
-        prefs = PreferenceManager.getDefaultSharedPreferences(activity);
-        translator = new SharedPreferencesTranslator(prefs);
+        translator = new SharedPreferencesTranslator(PreferenceManager.getDefaultSharedPreferences(activity));
     }
 
     public String getCategoryName(String categoryId) {
diff --git a/app/src/main/java/com/github/yeriomin/yalpstore/NativeHttpClientAdapter.java b/app/src/main/java/com/github/yeriomin/yalpstore/NativeHttpClientAdapter.java
index 754d37972..7f70de2a9 100644
--- a/app/src/main/java/com/github/yeriomin/yalpstore/NativeHttpClientAdapter.java
+++ b/app/src/main/java/com/github/yeriomin/yalpstore/NativeHttpClientAdapter.java
@@ -69,7 +69,7 @@ public class NativeHttpClientAdapter extends HttpClientAdapter {
         }
         addBody(connection, body);
 
-        byte[] content = new byte[0];
+        byte[] content;
         Log.i(getClass().getName(), "Requesting " + connection.getURL().toString());
         connection.connect();
 
diff --git a/app/src/main/java/com/github/yeriomin/yalpstore/ReviewAddTask.java b/app/src/main/java/com/github/yeriomin/yalpstore/ReviewAddTask.java
index 42516dc27..9e88e2a0f 100644
--- a/app/src/main/java/com/github/yeriomin/yalpstore/ReviewAddTask.java
+++ b/app/src/main/java/com/github/yeriomin/yalpstore/ReviewAddTask.java
@@ -30,7 +30,6 @@ class ReviewAddTask extends AsyncTask<com.github.yeriomin.yalpstore.model.Review
         try {
             review = wrapper.addOrEditReview(packageName, params[0]);
         } catch (IOException e) {
-            System.out.println(e.getClass().getName() + " " + e.getMessage());
             e.printStackTrace();
             return e;
         }