From cd5da2b83c4e3404e228bf585cf98ac7ad9e2186 Mon Sep 17 00:00:00 2001 From: Aayush Gupta Date: Mon, 30 Jun 2025 12:50:56 +0800 Subject: [PATCH] BaseFragment: Drop unused app parameter Signed-off-by: Aayush Gupta --- .../java/com/aurora/store/view/ui/all/AppsGamesFragment.kt | 3 +-- .../main/java/com/aurora/store/view/ui/commons/BaseFragment.kt | 3 +-- .../com/aurora/store/view/ui/commons/CategoryBrowseFragment.kt | 2 +- .../store/view/ui/commons/ExpandedStreamBrowseFragment.kt | 2 +- .../java/com/aurora/store/view/ui/commons/FavouriteFragment.kt | 3 +-- .../java/com/aurora/store/view/ui/commons/ForYouFragment.kt | 2 +- .../com/aurora/store/view/ui/commons/StreamBrowseFragment.kt | 2 +- .../java/com/aurora/store/view/ui/commons/TopChartFragment.kt | 2 +- .../com/aurora/store/view/ui/details/DevProfileFragment.kt | 2 +- .../com/aurora/store/view/ui/search/SearchResultsFragment.kt | 2 +- 10 files changed, 10 insertions(+), 13 deletions(-) diff --git a/app/src/main/java/com/aurora/store/view/ui/all/AppsGamesFragment.kt b/app/src/main/java/com/aurora/store/view/ui/all/AppsGamesFragment.kt index 8ed316a21..ff2229cac 100644 --- a/app/src/main/java/com/aurora/store/view/ui/all/AppsGamesFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/all/AppsGamesFragment.kt @@ -145,8 +145,7 @@ class AppsGamesFragment : BaseFragment() { .app(app) .click { _ -> openDetailsFragment( - app.packageName, - app + app.packageName ) } .longClick { _ -> diff --git a/app/src/main/java/com/aurora/store/view/ui/commons/BaseFragment.kt b/app/src/main/java/com/aurora/store/view/ui/commons/BaseFragment.kt index f0c541f14..66b4295a8 100644 --- a/app/src/main/java/com/aurora/store/view/ui/commons/BaseFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/commons/BaseFragment.kt @@ -29,7 +29,6 @@ import androidx.navigation.fragment.findNavController import androidx.viewbinding.ViewBinding import com.airbnb.epoxy.EpoxyRecyclerView import com.aurora.extensions.navigate -import com.aurora.gplayapi.data.models.App import com.aurora.gplayapi.data.models.Category import com.aurora.gplayapi.data.models.StreamCluster import com.aurora.store.MobileNavigationDirections @@ -82,7 +81,7 @@ abstract class BaseFragment : Fragment() { super.onDestroyView() } - fun openDetailsFragment(packageName: String, app: App? = null) { + fun openDetailsFragment(packageName: String) { requireContext().navigate( Screen.AppDetails(packageName) ) diff --git a/app/src/main/java/com/aurora/store/view/ui/commons/CategoryBrowseFragment.kt b/app/src/main/java/com/aurora/store/view/ui/commons/CategoryBrowseFragment.kt index 5b88e5c59..60a998667 100644 --- a/app/src/main/java/com/aurora/store/view/ui/commons/CategoryBrowseFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/commons/CategoryBrowseFragment.kt @@ -91,7 +91,7 @@ class CategoryBrowseFragment : BaseFragment() } override fun onAppClick(app: App) { - openDetailsFragment(app.packageName, app) + openDetailsFragment(app.packageName) } override fun onAppLongClick(app: App) { diff --git a/app/src/main/java/com/aurora/store/view/ui/commons/ExpandedStreamBrowseFragment.kt b/app/src/main/java/com/aurora/store/view/ui/commons/ExpandedStreamBrowseFragment.kt index 64855b553..c1dd0f7f5 100644 --- a/app/src/main/java/com/aurora/store/view/ui/commons/ExpandedStreamBrowseFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/commons/ExpandedStreamBrowseFragment.kt @@ -92,7 +92,7 @@ class ExpandedStreamBrowseFragment : BaseFragment openDetailsFragment(it.packageName, it) } + .click { _ -> openDetailsFragment(it.packageName) } ) } diff --git a/app/src/main/java/com/aurora/store/view/ui/commons/FavouriteFragment.kt b/app/src/main/java/com/aurora/store/view/ui/commons/FavouriteFragment.kt index 6bbf39e89..fee0f9da2 100644 --- a/app/src/main/java/com/aurora/store/view/ui/commons/FavouriteFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/commons/FavouriteFragment.kt @@ -30,7 +30,6 @@ import com.aurora.Constants import com.aurora.extensions.toast import com.aurora.store.R import com.aurora.store.data.room.favourite.Favourite -import com.aurora.store.data.room.favourite.Favourite.Companion.toApp import com.aurora.store.databinding.FragmentFavouriteBinding import com.aurora.store.view.epoxy.views.FavouriteViewModel_ import com.aurora.store.view.epoxy.views.app.NoAppViewModel_ @@ -104,7 +103,7 @@ class FavouriteFragment : BaseFragment() { FavouriteViewModel_() .id(it.packageName.hashCode()) .favourite(it) - .onClick { _ -> openDetailsFragment(it.packageName, it.toApp()) } + .onClick { _ -> openDetailsFragment(it.packageName) } .onFavourite { _ -> viewModel.removeFavourite(it.packageName) } ) } diff --git a/app/src/main/java/com/aurora/store/view/ui/commons/ForYouFragment.kt b/app/src/main/java/com/aurora/store/view/ui/commons/ForYouFragment.kt index 92fe7cb5c..15f9130b0 100644 --- a/app/src/main/java/com/aurora/store/view/ui/commons/ForYouFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/commons/ForYouFragment.kt @@ -106,7 +106,7 @@ class ForYouFragment : BaseFragment(), } override fun onAppClick(app: App) { - openDetailsFragment(app.packageName, app) + openDetailsFragment(app.packageName) } override fun onAppLongClick(app: App) { diff --git a/app/src/main/java/com/aurora/store/view/ui/commons/StreamBrowseFragment.kt b/app/src/main/java/com/aurora/store/view/ui/commons/StreamBrowseFragment.kt index 816add47f..dfaee3e38 100644 --- a/app/src/main/java/com/aurora/store/view/ui/commons/StreamBrowseFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/commons/StreamBrowseFragment.kt @@ -80,7 +80,7 @@ class StreamBrowseFragment : BaseFragment() { AppListViewModel_() .id(it.packageName.hashCode()) .app(it) - .click { _ -> openDetailsFragment(it.packageName, it) } + .click { _ -> openDetailsFragment(it.packageName) } ) } diff --git a/app/src/main/java/com/aurora/store/view/ui/commons/TopChartFragment.kt b/app/src/main/java/com/aurora/store/view/ui/commons/TopChartFragment.kt index a70b5aa73..db1049d91 100644 --- a/app/src/main/java/com/aurora/store/view/ui/commons/TopChartFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/commons/TopChartFragment.kt @@ -123,7 +123,7 @@ class TopChartFragment : BaseFragment() { AppListViewModel_() .id(app.id) .app(app) - .click { _ -> openDetailsFragment(app.packageName, app) } + .click { _ -> openDetailsFragment(app.packageName) } ) } diff --git a/app/src/main/java/com/aurora/store/view/ui/details/DevProfileFragment.kt b/app/src/main/java/com/aurora/store/view/ui/details/DevProfileFragment.kt index 1296ab6ee..0b810b998 100644 --- a/app/src/main/java/com/aurora/store/view/ui/details/DevProfileFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/details/DevProfileFragment.kt @@ -97,7 +97,7 @@ class DevProfileFragment : BaseFragment(), } override fun onAppClick(app: App) { - openDetailsFragment(app.packageName, app) + openDetailsFragment(app.packageName) } override fun onAppLongClick(app: App) { diff --git a/app/src/main/java/com/aurora/store/view/ui/search/SearchResultsFragment.kt b/app/src/main/java/com/aurora/store/view/ui/search/SearchResultsFragment.kt index a4992c218..20ecc4c6d 100644 --- a/app/src/main/java/com/aurora/store/view/ui/search/SearchResultsFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/search/SearchResultsFragment.kt @@ -153,7 +153,7 @@ class SearchResultsFragment : BaseFragment(), } override fun onAppClick(app: App) { - openDetailsFragment(app.packageName, app) + openDetailsFragment(app.packageName) } override fun onAppLongClick(app: App) {