From d85bcfd2accfa4c653e5f8ee4199a06962a3c719 Mon Sep 17 00:00:00 2001
From: Rahul Patel <whyorean@gmail.com>
Date: Mon, 16 Dec 2024 22:58:37 +0530
Subject: [PATCH] AppDetails: Do not clear menu instead don not inflate if not
 required

---
 .../view/ui/details/AppDetailsFragment.kt     | 21 ++++++-------------
 1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt b/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt
index 2c44fbb7b..b9bba59dd 100644
--- a/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt
+++ b/app/src/main/java/com/aurora/store/view/ui/details/AppDetailsFragment.kt
@@ -117,7 +117,6 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
 
     private var downloadStatus = DownloadStatus.UNAVAILABLE
     private var isUpdatable: Boolean = false
-    private var uninstallActionEnabled = false
 
     private val tags = mutableSetOf<String>()
 
@@ -192,7 +191,6 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
         app.apply {
             // Check whether app is installed or not
             isInstalled = PackageUtil.isInstalled(requireContext(), app.packageName)
-            uninstallActionEnabled = isInstalled
         }
 
         // Show the basic app details, while the rest of the data is being fetched
@@ -227,6 +225,8 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
 
                     // Fetch Exodus Privacy Report
                     viewModel.fetchAppReport(app.packageName)
+
+
                 } else {
                     toast(getString(R.string.status_unavailable))
                     // TODO: Redirect to App Unavailable Fragment
@@ -402,11 +402,10 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
                 }
             }
 
-            // Clear Menu, so that it clears the previous menu items before inflating new ones
-            menu.clear()
-
-            // Inflate Menu
-            inflateMenu(R.menu.menu_details)
+            if (menu.size() == 0) {
+                // Inflate Menu only if it is not already inflated
+                inflateMenu(R.menu.menu_details)
+            }
 
             // Adjust Menu Items
             menu.let {
@@ -697,10 +696,6 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
                         }
                     }
                 }
-
-                if (!uninstallActionEnabled) {
-                    binding.layoutDetailsToolbar.toolbar.invalidateMenu()
-                }
             } else {
                 if (downloadStatus in DownloadStatus.running) {
                     updateProgress(-1)
@@ -732,10 +727,6 @@ class AppDetailsFragment : BaseFragment<FragmentDetailsBinding>() {
                         startDownload()
                     }
                 }
-
-                if (uninstallActionEnabled) {
-                    binding.layoutDetailsToolbar.toolbar.invalidateMenu()
-                }
             }
         }
     }