From e1dda57471dbcd9a67d501d42ce08478643a4f07 Mon Sep 17 00:00:00 2001 From: Aayush Gupta Date: Fri, 4 Aug 2023 18:16:26 +0800 Subject: [PATCH] FilterSheet: Migrate to navigation components Signed-off-by: Aayush Gupta --- .../store/view/ui/search/SearchResultsFragment.kt | 3 +-- .../aurora/store/view/ui/sheets/FilterSheet.kt | 15 --------------- app/src/main/res/navigation/mobile_navigation.xml | 5 +++++ 3 files changed, 6 insertions(+), 17 deletions(-) diff --git a/app/src/main/java/com/aurora/store/view/ui/search/SearchResultsFragment.kt b/app/src/main/java/com/aurora/store/view/ui/search/SearchResultsFragment.kt index c7c6d1544..2a06f0a06 100644 --- a/app/src/main/java/com/aurora/store/view/ui/search/SearchResultsFragment.kt +++ b/app/src/main/java/com/aurora/store/view/ui/search/SearchResultsFragment.kt @@ -48,7 +48,6 @@ import com.aurora.store.view.epoxy.views.app.AppListViewModel_ import com.aurora.store.view.epoxy.views.app.NoAppViewModel_ import com.aurora.store.view.epoxy.views.shimmer.AppListViewShimmerModel_ import com.aurora.store.view.ui.commons.BaseFragment -import com.aurora.store.view.ui.sheets.FilterSheet import com.aurora.store.viewmodel.search.SearchResultViewModel import com.google.android.material.snackbar.Snackbar import com.google.android.material.textfield.TextInputEditText @@ -112,7 +111,7 @@ class SearchResultsFragment : BaseFragment(R.layout.fragment_search_result), // Filter binding.filterFab.setOnClickListener { - FilterSheet.newInstance().show(childFragmentManager, FilterSheet.TAG) + findNavController().navigate(R.id.filterSheet) } VM.liveData.observe(viewLifecycleOwner) { diff --git a/app/src/main/java/com/aurora/store/view/ui/sheets/FilterSheet.kt b/app/src/main/java/com/aurora/store/view/ui/sheets/FilterSheet.kt index 1dffbca7e..12e41d109 100644 --- a/app/src/main/java/com/aurora/store/view/ui/sheets/FilterSheet.kt +++ b/app/src/main/java/com/aurora/store/view/ui/sheets/FilterSheet.kt @@ -27,7 +27,6 @@ import com.aurora.store.R import com.aurora.store.data.Filter import com.aurora.store.data.providers.FilterProvider import com.aurora.store.databinding.SheetFilterBinding -import com.aurora.store.util.Log import com.google.android.material.chip.Chip class FilterSheet : BaseBottomSheet() { @@ -35,20 +34,6 @@ class FilterSheet : BaseBottomSheet() { private lateinit var B: SheetFilterBinding private lateinit var filter: Filter - companion object { - - const val TAG = "FilterSheet" - - @JvmStatic - fun newInstance(): FilterSheet { - return FilterSheet().apply { - arguments = Bundle().apply { - - } - } - } - } - override fun onCreateContentView( inflater: LayoutInflater, container: ViewGroup, diff --git a/app/src/main/res/navigation/mobile_navigation.xml b/app/src/main/res/navigation/mobile_navigation.xml index cf7c6ef38..581b68c0f 100644 --- a/app/src/main/res/navigation/mobile_navigation.xml +++ b/app/src/main/res/navigation/mobile_navigation.xml @@ -364,4 +364,9 @@ android:name="app" app:argType="com.aurora.gplayapi.data.models.App" /> +