From e60df2f6ce3cd0aec56328897fa4e931b2ac8149 Mon Sep 17 00:00:00 2001 From: Sergey Eremin Date: Fri, 2 Jun 2017 12:11:27 +0300 Subject: [PATCH] Preference method setting label was not being updated properly --- .../preference/OnInstallationMethodChangeListener.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/github/yeriomin/yalpstore/fragment/preference/OnInstallationMethodChangeListener.java b/app/src/main/java/com/github/yeriomin/yalpstore/fragment/preference/OnInstallationMethodChangeListener.java index d4e00fb84..abc45d484 100644 --- a/app/src/main/java/com/github/yeriomin/yalpstore/fragment/preference/OnInstallationMethodChangeListener.java +++ b/app/src/main/java/com/github/yeriomin/yalpstore/fragment/preference/OnInstallationMethodChangeListener.java @@ -28,7 +28,9 @@ class OnInstallationMethodChangeListener implements Preference.OnPreferenceChang String oldValue = ((ListPreference) preference).getValue(); if (null != oldValue && !oldValue.equals(newValue)) { if (PreferenceActivity.INSTALLATION_METHOD_PRIVILEGED.equals(newValue)) { - return checkPrivileged(); + if (!checkPrivileged()) { + return false; + } } else if (PreferenceActivity.INSTALLATION_METHOD_ROOT.equals(newValue)) { new CheckSuTask(activity).execute(); }