From 8b50b9b26ddb0d04002aa70ebca9bf28c9a91964 Mon Sep 17 00:00:00 2001 From: nettnikl Date: Fri, 15 May 2020 11:31:46 +0200 Subject: [PATCH] Fix UpdateItems are randomly expanding during scrolling due to view rebinding --- .../com/aurora/store/model/items/UpdatesItem.java | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/aurora/store/model/items/UpdatesItem.java b/app/src/main/java/com/aurora/store/model/items/UpdatesItem.java index c582f90e9..4d8205ae1 100644 --- a/app/src/main/java/com/aurora/store/model/items/UpdatesItem.java +++ b/app/src/main/java/com/aurora/store/model/items/UpdatesItem.java @@ -46,6 +46,7 @@ public class UpdatesItem extends AbstractItem { private String packageName; private boolean checked; + private boolean expanded; public UpdatesItem(App app) { this.app = app; @@ -118,15 +119,23 @@ public class UpdatesItem extends AbstractItem { .into(imgIcon); imgExpand.setOnClickListener(v -> { - boolean isVisible = layoutChanges.getVisibility() == View.VISIBLE; - if (isVisible) { + if (item.expanded) { ViewUtil.collapse(layoutChanges); ViewUtil.rotateView(imgExpand, true); + item.expanded = false; } else { ViewUtil.rotateView(imgExpand, false); ViewUtil.expand(layoutChanges); + item.expanded = true; } }); + if (item.expanded) { + imgExpand.setRotation(180); + layoutChanges.setVisibility(View.VISIBLE); + } else { + imgExpand.setRotation(0); + layoutChanges.setVisibility(View.GONE); + } checkBox.setChecked(item.checked); }