From 7ab5e701e178be853672d6ce245477dd0cf83bfa Mon Sep 17 00:00:00 2001 From: tibbi Date: Sun, 17 Jul 2022 22:11:23 +0200 Subject: [PATCH] updating commons with some design changes --- app/build.gradle | 2 +- .../calculator/activities/MainActivity.kt | 25 +- .../calculator/activities/SettingsActivity.kt | 15 +- .../activities/WidgetConfigureActivity.kt | 4 + .../calculator/dialogs/HistoryDialog.kt | 3 +- .../main/res/layout-land/activity_main.xml | 433 +++++++++--------- app/src/main/res/layout/activity_main.xml | 259 +---------- app/src/main/res/layout/activity_settings.xml | 297 ++++++------ app/src/main/res/layout/view_calculator.xml | 244 ++++++++++ app/src/main/res/layout/widget.xml | 2 +- app/src/main/res/layout/widget_config.xml | 145 +++--- 11 files changed, 763 insertions(+), 666 deletions(-) create mode 100644 app/src/main/res/layout/view_calculator.xml diff --git a/app/build.gradle b/app/build.gradle index 60ef87a0..238c04ab 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -63,7 +63,7 @@ android { } dependencies { - implementation 'com.github.SimpleMobileTools:Simple-Commons:c070dff787' + implementation 'com.github.SimpleMobileTools:Simple-Commons:8ee6c0c17b' implementation 'me.grantland:autofittextview:0.2.1' implementation 'net.objecthunter:exp4j:0.4.8' diff --git a/app/src/main/kotlin/com/simplemobiletools/calculator/activities/MainActivity.kt b/app/src/main/kotlin/com/simplemobiletools/calculator/activities/MainActivity.kt index 0c13aea5..a808731b 100644 --- a/app/src/main/kotlin/com/simplemobiletools/calculator/activities/MainActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/calculator/activities/MainActivity.kt @@ -4,7 +4,6 @@ import android.content.Context import android.content.Intent import android.os.Bundle import android.view.Menu -import android.view.MenuItem import android.view.View import android.view.WindowManager import com.simplemobiletools.calculator.BuildConfig @@ -35,6 +34,7 @@ class MainActivity : SimpleActivity(), Calculator { super.onCreate(savedInstanceState) setContentView(R.layout.activity_main) appLaunched(BuildConfig.APPLICATION_ID) + setupOptionsMenu() calc = CalculatorImpl(this, applicationContext) @@ -74,6 +74,7 @@ class MainActivity : SimpleActivity(), Calculator { override fun onResume() { super.onResume() + setupToolbar(main_toolbar) if (storedTextColor != config.textColor) { updateViewColors(calculator_holder, getProperTextColor()) } @@ -110,20 +111,16 @@ class MainActivity : SimpleActivity(), Calculator { } } - override fun onCreateOptionsMenu(menu: Menu): Boolean { - menuInflater.inflate(R.menu.menu, menu) - updateMenuItemColors(menu) - return true - } - - override fun onOptionsItemSelected(item: MenuItem): Boolean { - when (item.itemId) { - R.id.history -> showHistory() - R.id.settings -> launchSettings() - R.id.about -> launchAbout() - else -> return super.onOptionsItemSelected(item) + private fun setupOptionsMenu() { + main_toolbar.setOnMenuItemClickListener { menuItem -> + when (menuItem.itemId) { + R.id.history -> showHistory() + R.id.settings -> launchSettings() + R.id.about -> launchAbout() + else -> return@setOnMenuItemClickListener false + } + return@setOnMenuItemClickListener true } - return true } private fun storeStateVariables() { diff --git a/app/src/main/kotlin/com/simplemobiletools/calculator/activities/SettingsActivity.kt b/app/src/main/kotlin/com/simplemobiletools/calculator/activities/SettingsActivity.kt index d2721e25..fbb37899 100644 --- a/app/src/main/kotlin/com/simplemobiletools/calculator/activities/SettingsActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/calculator/activities/SettingsActivity.kt @@ -2,19 +2,18 @@ package com.simplemobiletools.calculator.activities import android.content.Intent import android.os.Bundle -import android.view.Menu import com.simplemobiletools.calculator.R import com.simplemobiletools.calculator.extensions.calculatorDB import com.simplemobiletools.calculator.extensions.config import com.simplemobiletools.calculator.extensions.updateWidgets import com.simplemobiletools.commons.extensions.* import com.simplemobiletools.commons.helpers.IS_CUSTOMIZING_COLORS +import com.simplemobiletools.commons.helpers.NavigationIcon import com.simplemobiletools.commons.helpers.ensureBackgroundThread import kotlinx.android.synthetic.main.activity_settings.* import java.util.* import kotlin.system.exitProcess - class SettingsActivity : SimpleActivity() { override fun onCreate(savedInstanceState: Bundle?) { @@ -24,6 +23,7 @@ class SettingsActivity : SimpleActivity() { override fun onResume() { super.onResume() + setupToolbar(settings_toolbar, NavigationIcon.Arrow) setupPurchaseThankYou() setupCustomizeColors() @@ -32,7 +32,7 @@ class SettingsActivity : SimpleActivity() { setupPreventPhoneFromSleeping() setupUseCommaAsDecimalMark() setupCustomizeWidgetColors() - updateTextColors(settings_scrollview) + updateTextColors(settings_nested_scrollview) arrayOf(settings_color_customization_label, settings_general_settings_label).forEach { it.setTextColor(getProperPrimaryColor()) @@ -43,11 +43,6 @@ class SettingsActivity : SimpleActivity() { } } - override fun onCreateOptionsMenu(menu: Menu): Boolean { - updateMenuItemColors(menu) - return super.onCreateOptionsMenu(menu) - } - private fun setupPurchaseThankYou() { settings_purchase_thank_you_holder.beGoneIf(isOrWasThankYouInstalled()) @@ -105,8 +100,8 @@ class SettingsActivity : SimpleActivity() { settings_use_comma_as_decimal_mark.toggle() config.useCommaAsDecimalMark = settings_use_comma_as_decimal_mark.isChecked updateWidgets() - ensureBackgroundThread { - applicationContext.calculatorDB.deleteHistory() + ensureBackgroundThread { + applicationContext.calculatorDB.deleteHistory() } } } diff --git a/app/src/main/kotlin/com/simplemobiletools/calculator/activities/WidgetConfigureActivity.kt b/app/src/main/kotlin/com/simplemobiletools/calculator/activities/WidgetConfigureActivity.kt index 46d6823e..864f2087 100644 --- a/app/src/main/kotlin/com/simplemobiletools/calculator/activities/WidgetConfigureActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/calculator/activities/WidgetConfigureActivity.kt @@ -3,6 +3,7 @@ package com.simplemobiletools.calculator.activities import android.app.Activity import android.appwidget.AppWidgetManager import android.content.Intent +import android.content.res.ColorStateList import android.graphics.Color import android.os.Bundle import android.widget.Button @@ -63,6 +64,7 @@ class WidgetConfigureActivity : SimpleActivity() { if (mFeatureLockedDialog != null && isOrWasThankYouInstalled()) { mFeatureLockedDialog?.dismissDialog() } + setupToolbar(config_toolbar) } private fun initVariables() { @@ -118,6 +120,7 @@ class WidgetConfigureActivity : SimpleActivity() { mBgColor = mBgColorWithoutTransparency.adjustAlpha(mBgAlpha) widget_background.applyColorFilter(mBgColor) config_bg_color.setFillWithStroke(mBgColor, mBgColor) + config_save.backgroundTintList = ColorStateList.valueOf(getProperPrimaryColor()) } private fun updateTextColor() { @@ -130,6 +133,7 @@ class WidgetConfigureActivity : SimpleActivity() { ) result.setTextColor(mTextColor) formula.setTextColor(mTextColor) + config_save.setTextColor(getProperPrimaryColor().getContrastColor()) viewIds.forEach { (findViewById