Add configurable number of retries and timeout for http calls (#40)

code/Executable/DependencyInjection/MainDI.cs

@@ -1,14 +1,9 @@
 using System.Net;
-using Common.Configuration;
-using Common.Configuration.ContentBlocker;
-using Executable.Jobs;
-using Infrastructure.Verticals.Arr;
-using Infrastructure.Verticals.ContentBlocker;
-using Infrastructure.Verticals.DownloadClient;
+using Common.Configuration.General;
+using Common.Helpers;
 using Infrastructure.Verticals.DownloadClient.Deluge;
-using Infrastructure.Verticals.DownloadClient.QBittorrent;
-using Infrastructure.Verticals.DownloadClient.Transmission;
-using Infrastructure.Verticals.QueueCleaner;
+using Polly;
+using Polly.Extensions.Http;
 
 namespace Executable.DependencyInjection;
 
@@ -17,16 +12,27 @@ public static class MainDI
     public static IServiceCollection AddInfrastructure(this IServiceCollection services, IConfiguration configuration) =>
         services
             .AddLogging(builder => builder.ClearProviders().AddConsole())
-            .AddHttpClients()
+            .AddHttpClients(configuration)
             .AddConfiguration(configuration)
             .AddMemoryCache()
             .AddServices()
             .AddQuartzServices(configuration);
     
-    private static IServiceCollection AddHttpClients(this IServiceCollection services)
+    private static IServiceCollection AddHttpClients(this IServiceCollection services, IConfiguration configuration)
     {
         // add default HttpClient
         services.AddHttpClient();
+        
+        HttpConfig config = configuration.Get<HttpConfig>() ?? new();
+        config.Validate();
+
+        // add retry HttpClient
+        services
+            .AddHttpClient(Constants.HttpClientWithRetryName, x =>
+            {
+                x.Timeout = TimeSpan.FromSeconds(config.Timeout);
+            })
+            .AddRetryPolicyHandler(config);
 
         // add Deluge HttpClient
         services
@@ -44,8 +50,18 @@ public static class MainDI
                     AutomaticDecompression = DecompressionMethods.GZip | DecompressionMethods.Deflate,
                     ServerCertificateCustomValidationCallback = (_, _, _, _) => true
                 };
-            });
+            })
+            .AddRetryPolicyHandler(config);
 
         return services;
     }
+
+    private static IHttpClientBuilder AddRetryPolicyHandler(this IHttpClientBuilder builder, HttpConfig config) =>
+        builder.AddPolicyHandler(
+            HttpPolicyExtensions
+                .HandleTransientHttpError()
+                // do not retry on Unauthorized
+                .OrResult(response => !response.IsSuccessStatusCode && response.StatusCode != HttpStatusCode.Unauthorized)
+                .WaitAndRetryAsync(config.MaxRetries, retryAttempt => TimeSpan.FromSeconds(Math.Pow(2, retryAttempt)))
+        );
 }

code/Executable/DependencyInjection/QuartzDI.cs

@@ -1,5 +1,6 @@
 using Common.Configuration;
 using Common.Configuration.ContentBlocker;
+using Common.Configuration.General;
 using Common.Configuration.QueueCleaner;
 using Common.Helpers;
 using Executable.Jobs;

code/Executable/Executable.csproj

@@ -12,6 +12,7 @@
     <ItemGroup>
         <PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.0" />
         <PackageReference Include="Microsoft.Extensions.Http" Version="9.0.0" />
+        <PackageReference Include="Microsoft.Extensions.Http.Polly" Version="9.0.0" />
         <PackageReference Include="Quartz" Version="3.13.1" />
         <PackageReference Include="Quartz.Extensions.DependencyInjection" Version="3.13.1" />
         <PackageReference Include="Quartz.Extensions.Hosting" Version="3.13.1" />

code/Executable/appsettings.Development.json

@@ -1,4 +1,6 @@
 {
+  "HTTP_MAX_RETRIES": 0,
+  "HTTP_TIMEOUT": 10,
   "Logging": {
     "LogLevel": "Debug",
     "Enhanced": true,

code/Executable/appsettings.json

@@ -1,4 +1,6 @@
 {
+  "HTTP_MAX_RETRIES": 0,
+  "HTTP_TIMEOUT": 100,
   "Logging": {
     "LogLevel": "Information",
     "Enhanced": true,