From 087ccdf2f417cff067f8599fdc7de7d4bf2e354f Mon Sep 17 00:00:00 2001 From: tibbi Date: Wed, 31 Aug 2022 19:17:22 +0200 Subject: [PATCH] updating the main and settings top menus --- .../clock/activities/MainActivity.kt | 33 +- .../clock/activities/SettingsActivity.kt | 2 + app/src/main/res/layout/activity_main.xml | 51 +- app/src/main/res/layout/activity_settings.xml | 540 +++++++++--------- 4 files changed, 338 insertions(+), 288 deletions(-) diff --git a/app/src/main/kotlin/com/simplemobiletools/clock/activities/MainActivity.kt b/app/src/main/kotlin/com/simplemobiletools/clock/activities/MainActivity.kt index cc5017b8..8e9739a5 100644 --- a/app/src/main/kotlin/com/simplemobiletools/clock/activities/MainActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/clock/activities/MainActivity.kt @@ -3,8 +3,6 @@ package com.simplemobiletools.clock.activities import android.content.Intent import android.graphics.drawable.ColorDrawable import android.os.Bundle -import android.view.Menu -import android.view.MenuItem import android.view.WindowManager import android.widget.ImageView import android.widget.TextView @@ -31,6 +29,8 @@ class MainActivity : SimpleActivity() { super.onCreate(savedInstanceState) setContentView(R.layout.activity_main) appLaunched(BuildConfig.APPLICATION_ID) + setupOptionsMenu() + refreshMenuItems() storeStateVariables() initFragments() setupTabs() @@ -45,6 +45,7 @@ class MainActivity : SimpleActivity() { override fun onResume() { super.onResume() + setupToolbar(main_toolbar) val configTextColor = getProperTextColor() if (storedTextColor != configTextColor) { getInactiveTabIndexes(view_pager.currentItem).forEach { @@ -79,24 +80,22 @@ class MainActivity : SimpleActivity() { config.lastUsedViewPagerPage = view_pager.currentItem } - override fun onCreateOptionsMenu(menu: Menu): Boolean { - menuInflater.inflate(R.menu.menu, menu) - menu.apply { - findItem(R.id.sort).isVisible = view_pager.currentItem == TAB_ALARM - updateMenuItemColors(this) + private fun setupOptionsMenu() { + main_toolbar.setOnMenuItemClickListener { menuItem -> + when (menuItem.itemId) { + R.id.sort -> getViewPagerAdapter()?.showAlarmSortDialog() + R.id.settings -> launchSettings() + R.id.about -> launchAbout() + else -> return@setOnMenuItemClickListener false + } + return@setOnMenuItemClickListener true } - - return true } - override fun onOptionsItemSelected(item: MenuItem): Boolean { - when (item.itemId) { - R.id.sort -> getViewPagerAdapter()?.showAlarmSortDialog() - R.id.settings -> launchSettings() - R.id.about -> launchAbout() - else -> return super.onOptionsItemSelected(item) + private fun refreshMenuItems() { + main_toolbar.menu.apply { + findItem(R.id.sort).isVisible = view_pager.currentItem == TAB_ALARM } - return true } override fun onNewIntent(intent: Intent) { @@ -144,7 +143,7 @@ class MainActivity : SimpleActivity() { view_pager.adapter = viewPagerAdapter view_pager.onPageChangeListener { main_tabs_holder.getTabAt(it)?.select() - invalidateOptionsMenu() + refreshMenuItems() } val tabToOpen = intent.getIntExtra(OPEN_TAB, config.lastUsedViewPagerPage) diff --git a/app/src/main/kotlin/com/simplemobiletools/clock/activities/SettingsActivity.kt b/app/src/main/kotlin/com/simplemobiletools/clock/activities/SettingsActivity.kt index c2195c22..765635ba 100644 --- a/app/src/main/kotlin/com/simplemobiletools/clock/activities/SettingsActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/clock/activities/SettingsActivity.kt @@ -9,6 +9,7 @@ import com.simplemobiletools.clock.helpers.DEFAULT_MAX_TIMER_REMINDER_SECS import com.simplemobiletools.commons.extensions.* import com.simplemobiletools.commons.helpers.IS_CUSTOMIZING_COLORS import com.simplemobiletools.commons.helpers.MINUTE_SECONDS +import com.simplemobiletools.commons.helpers.NavigationIcon import kotlinx.android.synthetic.main.activity_settings.* import java.util.* @@ -20,6 +21,7 @@ class SettingsActivity : SimpleActivity() { override fun onResume() { super.onResume() + setupToolbar(settings_toolbar, NavigationIcon.Arrow) setupPurchaseThankYou() setupCustomizeColors() diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml index 1504a115..96b3ea64 100644 --- a/app/src/main/res/layout/activity_main.xml +++ b/app/src/main/res/layout/activity_main.xml @@ -1,23 +1,46 @@ - - + + + + + + + app:layout_behavior="@string/appbar_scrolling_view_behavior"> - + - + + + + diff --git a/app/src/main/res/layout/activity_settings.xml b/app/src/main/res/layout/activity_settings.xml index 7a278571..462a31b3 100644 --- a/app/src/main/res/layout/activity_settings.xml +++ b/app/src/main/res/layout/activity_settings.xml @@ -1,278 +1,304 @@ - + android:layout_height="match_parent"> - + + + + + + - - + android:fillViewport="true" + android:scrollbars="none" + app:layout_behavior="@string/appbar_scrolling_view_behavior"> - + android:text="@string/color_customization" /> - - - - - + android:layout_margin="@dimen/medium_margin" + android:background="@drawable/section_holder_stroke" + android:orientation="vertical"> - + android:background="@drawable/ripple_top_corners"> - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + +