From cae5b96b1e0d80db00f051785fbb19f4aa838c98 Mon Sep 17 00:00:00 2001 From: MartinBraquet Date: Mon, 9 Mar 2026 13:36:52 +0100 Subject: [PATCH] Fix sorting by answer count --- web/components/answers/compatibility-questions-display.tsx | 1 + web/components/compatibility/sort-widget.tsx | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/web/components/answers/compatibility-questions-display.tsx b/web/components/answers/compatibility-questions-display.tsx index 7f78ab15..d1923e2c 100644 --- a/web/components/answers/compatibility-questions-display.tsx +++ b/web/components/answers/compatibility-questions-display.tsx @@ -132,6 +132,7 @@ export function CompatibilityQuestionsDisplay(props: { const sortedAndFilteredAnswers = sortBy( answers.filter((a) => { + // if (a.id < 10) console.log({a, sort}) const question = compatibilityQuestions.find((q) => q.id === a.question_id) const comparedAnswer = questionIdToComparedAnswer[a.question_id] if (question && !isMatchingSearch({...question, answer: a}, searchTerm)) return false diff --git a/web/components/compatibility/sort-widget.tsx b/web/components/compatibility/sort-widget.tsx index 06655e1b..4873484d 100644 --- a/web/components/compatibility/sort-widget.tsx +++ b/web/components/compatibility/sort-widget.tsx @@ -76,6 +76,7 @@ export function CompatibilitySortWidget(props: { } export function compareBySort(a: any, b: any, sort: CompatibilitySort) { + // if (a.id < 10) console.log({a, b, sort}) if (sort === 'random') { return Math.random() - 0.5 } else if (sort === 'community_importance') { @@ -83,7 +84,7 @@ export function compareBySort(a: any, b: any, sort: CompatibilitySort) { const rateB = (b?.community_importance_score ?? 0) / Math.max(b?.answer_count ?? 1, 1) return rateB - rateA } else if (sort === 'most_answered') { - return b?.answer_count - a?.answer_count + return (b?.answer_count ?? 0) - (a?.answer_count ?? 0) } else if (sort === 'newest') { return ( (b?.created_time ? new Date(b?.created_time).getTime() : 0) - @@ -96,7 +97,6 @@ export function compareBySort(a: any, b: any, sort: CompatibilitySort) { } export function isMatchingSearch(question: any, searchTerm: string) { - console.log(searchTerm, question) if (searchTerm) { const searchLower = searchTerm.toLowerCase()