From eaa0b4ce9630d33c12cb09d50edae18e1318f516 Mon Sep 17 00:00:00 2001 From: Okechi Jones-Williams Date: Thu, 28 May 2026 22:29:50 +0100 Subject: [PATCH] Fix #1 --- tests/e2e/web/fixtures/signInFixture.ts | 2 ++ tests/e2e/web/pages/peoplePage.ts | 1 + tests/e2e/web/pages/profilePage.ts | 1 - tests/e2e/web/specs/signIn.spec.ts | 31 ++++++++++++------------- 4 files changed, 18 insertions(+), 17 deletions(-) diff --git a/tests/e2e/web/fixtures/signInFixture.ts b/tests/e2e/web/fixtures/signInFixture.ts index fa30f5be..3b4884c1 100644 --- a/tests/e2e/web/fixtures/signInFixture.ts +++ b/tests/e2e/web/fixtures/signInFixture.ts @@ -28,6 +28,7 @@ export const test = base.extend<{ undefined, account.display_name, account.username, + true, ) await app.signinWithEmail(account) await use(account) @@ -41,6 +42,7 @@ export const test = base.extend<{ undefined, account.display_name, account.username, + true, ) await use(account) await deleteUser('Email/Password', account) diff --git a/tests/e2e/web/pages/peoplePage.ts b/tests/e2e/web/pages/peoplePage.ts index 67eece02..50ff146d 100644 --- a/tests/e2e/web/pages/peoplePage.ts +++ b/tests/e2e/web/pages/peoplePage.ts @@ -514,6 +514,7 @@ export class PeoplePage { async verifySavedPerson(displayName: string) { await expect(this.savedPeopleHeading).toBeVisible() + await this.page.waitForTimeout(1000) const isThereSavedPeople = (await this.savedPeopleList.count()) > 0 if (isThereSavedPeople) { diff --git a/tests/e2e/web/pages/profilePage.ts b/tests/e2e/web/pages/profilePage.ts index 3a63d128..3367ed25 100644 --- a/tests/e2e/web/pages/profilePage.ts +++ b/tests/e2e/web/pages/profilePage.ts @@ -504,7 +504,6 @@ export class ProfilePage { async verifyKeywords(keywords: string | undefined) { if (!keywords) return - console.log(this.keywordsSection.textContent()) const keywordsArr = keywords.split(', ') await expect(this.keywordsSection).toBeVisible() for (const word of keywordsArr) { diff --git a/tests/e2e/web/specs/signIn.spec.ts b/tests/e2e/web/specs/signIn.spec.ts index 2cd8d467..182778cc 100644 --- a/tests/e2e/web/specs/signIn.spec.ts +++ b/tests/e2e/web/specs/signIn.spec.ts @@ -30,9 +30,8 @@ test.describe('when given valid input', () => { await app.people.setDisplayFilter({cardSize: 'Large'}) const filterdProfiles = await app.people.profileCountLocator.textContent() - await expect(totalProfiles).not.toBeNull() - await expect(filterdProfiles).not.toBeNull() - await expect(Number(totalProfiles)).not.toEqual(Number(filterdProfiles)) + if (!totalProfiles || !filterdProfiles) return + await expect(parseInt(totalProfiles)).not.toEqual(parseInt(filterdProfiles)) const results = await app.people.getProfileInfo() if (!results) return @@ -238,41 +237,41 @@ test.describe('when given valid input', () => { test.describe('a verified account should', () => { test('be able to send a message from the messages page', async ({ app, - devOneAccount, - devTwoAccount, + signedOutAccount: accountOne, + signedInAccount: accountTwo, }) => { const devOne = await app.contextManager.createContext('devOne') const devTwo = await app.contextManager.createContext('devTwo') - await devOne.signinWithEmail(devOneAccount) - await devTwo.signinWithEmail(devTwoAccount) + await devOne.signinWithEmail(accountOne) + await devTwo.signinWithEmail(accountTwo) await devOne.home.clickMessagesLink() - await devOne.messages.createNewMessage([devTwoAccount.display_name]) + await devOne.messages.createNewMessage([accountTwo.display_name]) await devOne.messages.sendMessage('This is a message') await devTwo.home.clickMessagesLink() - await devTwo.messages.findMessageConversation(devOneAccount.display_name) + await devTwo.messages.findMessageConversation(accountOne.display_name) await devTwo.messages.verifyMessage('This is a message') }) test('be able to send a message from the people page', async ({ app, - devOneAccount, - devTwoAccount, + signedOutAccount: accountOne, + signedInAccount: accountTwo, }) => { const devOne = await app.contextManager.createContext('devOne') const devTwo = await app.contextManager.createContext('devTwo') - await devOne.signinWithEmail(devOneAccount) - await devTwo.signinWithEmail(devTwoAccount) + await devOne.signinWithEmail(accountOne) + await devTwo.signinWithEmail(accountTwo) await devOne.home.clickPeopleLink() - await devOne.people.useSearch(devTwoAccount.display_name) + await devOne.people.useSearch(accountTwo.display_name) const message = 'This is a message'.repeat(20) - await devOne.people.messageProfile(devTwoAccount.display_name, message) + await devOne.people.messageProfile(accountTwo.display_name, message) await devOne.messages.verifyMessage(message) await devTwo.home.clickMessagesLink() - await devTwo.messages.findMessageConversation(devOneAccount.display_name) + await devTwo.messages.findMessageConversation(accountOne.display_name) await devTwo.messages.verifyMessage(message) }) })