mirror/Compass
1
0
Fork 0
mirror of https://github.com/CompassConnections/Compass.git synced 2026-04-03 14:33:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix logs not showing in google cloud console

Browse Source
This commit is contained in:
MartinBraquet
2026-04-01 18:56:41 +02:00
parent b936466a9d
commit fc199a918a
3 changed files with 37 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
backend/api/src/app.ts
View File

@@ -123,6 +123,8 @@ const requestMonitoring: RequestHandler = (req, _res, next) => {
log(`${req.method} ${req.url}`)
metrics.inc('http/request_count', {endpoint: req.path})
next()
// There's a bug worth flagging in that middleware. The timing/cleanup code after next() won't work as you expect:
// next() is synchronous — it just hands off to the next middleware. The response hasn't been sent by the time endTs is captured. To measure actual latency you'd want to hook into res.on('finish', ...)
const endTs = hrtime.bigint()
const latencyMs = Number(endTs - startTs) / 1e6
metrics.push('http/request_latency', latencyMs, {endpoint: req.path})