From 0efae2f760e48633bbae9c2c9adde5d2c2bb25a1 Mon Sep 17 00:00:00 2001
From: tibbi <tibor@kaputa.sk>
Date: Mon, 26 Oct 2020 12:53:04 +0100
Subject: [PATCH] adding a divider under the contacts photo

---
 .../contacts/pro/activities/ViewContactActivity.kt |  9 +++++----
 app/src/main/res/layout/activity_view_contact.xml  | 14 +++++++++++---
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/ViewContactActivity.kt b/app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/ViewContactActivity.kt
index 3de6ba59..5b84ebcf 100644
--- a/app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/ViewContactActivity.kt
+++ b/app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/ViewContactActivity.kt
@@ -182,14 +182,14 @@ class ViewContactActivity : ContactActivity() {
             val path = contact!!.photoUri
             currentContactPhotoPath = path
 
-            val options = RequestOptions()
-                .diskCacheStrategy(DiskCacheStrategy.RESOURCE)
-                .centerCrop()
-
             if (isDestroyed || isFinishing) {
                 return
             }
 
+            val options = RequestOptions()
+                .diskCacheStrategy(DiskCacheStrategy.RESOURCE)
+                .centerCrop()
+
             val wantedWidth = realScreenSize.x
             val wantedHeight = resources.getDimension(R.dimen.top_contact_image_height).toInt()
 
@@ -202,6 +202,7 @@ class ViewContactActivity : ContactActivity() {
                     override fun onResourceReady(resource: Drawable?, model: Any?, target: Target<Drawable>?, dataSource: DataSource?, isFirstResource: Boolean): Boolean {
                         contact_photo.background = ColorDrawable(0)
                         contact_photo_bottom_shadow.beVisible()
+                        contact_photo_divider.beInvisible()
                         return false
                     }
 
diff --git a/app/src/main/res/layout/activity_view_contact.xml b/app/src/main/res/layout/activity_view_contact.xml
index e4f56b3e..b4b0cc44 100644
--- a/app/src/main/res/layout/activity_view_contact.xml
+++ b/app/src/main/res/layout/activity_view_contact.xml
@@ -20,7 +20,6 @@
                 android:id="@+id/contact_photo"
                 android:layout_width="match_parent"
                 android:layout_height="@dimen/top_contact_image_height"
-                android:layout_marginBottom="@dimen/normal_margin"
                 android:src="@drawable/ic_person_vector" />
 
             <ImageView
@@ -31,6 +30,15 @@
                 android:background="@drawable/gradient_background"
                 android:contentDescription="@null" />
 
+            <ImageView
+                android:id="@+id/contact_photo_divider"
+                android:layout_width="match_parent"
+                android:layout_height="1px"
+                android:layout_below="@+id/contact_photo"
+                android:layout_marginBottom="@dimen/normal_margin"
+                android:background="@color/divider_grey"
+                android:importantForAccessibility="no" />
+
             <ImageView
                 android:id="@+id/contact_toggle_favorite"
                 android:layout_width="@dimen/contact_actions_size"
@@ -93,7 +101,7 @@
                 android:id="@+id/contact_name_image"
                 android:layout_width="@dimen/contact_icons_size"
                 android:layout_height="@dimen/contact_icons_size"
-                android:layout_below="@+id/contact_photo"
+                android:layout_below="@+id/contact_photo_divider"
                 android:layout_marginStart="@dimen/normal_margin"
                 android:paddingTop="@dimen/medium_margin"
                 android:paddingEnd="@dimen/small_margin"
@@ -104,7 +112,7 @@
                 android:id="@+id/contact_prefix"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:layout_below="@+id/contact_photo"
+                android:layout_below="@+id/contact_photo_divider"
                 android:layout_centerVertical="true"
                 android:layout_toEndOf="@+id/contact_name_image"
                 android:background="?attr/selectableItemBackground"