mirror/FreshRSS
0
0
Fork 0
mirror of https://github.com/FreshRSS/FreshRSS.git synced 2026-04-12 18:37:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

PHPStan level 5 (#4110)

Browse Source 
* Fix most PHPDocs errors
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types

* Avoid func_get_args
Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list
And avoid dynamic functions names when possible to more easily identify calls and unused functions.
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103

* PHPStan level 3

* PHPStand level 4

* Update default to PHPStan level 4

* Towards level 5

* Fix level 4 regression

* Towards level 5

* Pass PHPStan level 5

* Towards level 6

* Remove erronenous regression from changelog
https://github.com/FreshRSS/FreshRSS/pull/4116
This commit is contained in:
Alexandre Alapetite
2022-01-04 13:59:09 +01:00
committed by GitHub
parent 0988b0c2be
commit 1335a0e3cf
73 changed files with 403 additions and 170 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Controllers/javascriptController.php
View File

@@ -1,6 +1,6 @@
<?php
class FreshRSS_javascript_Controller extends Minz_ActionController {
class FreshRSS_javascript_Controller extends FreshRSS_ActionController {
public function firstAction() {
$this->view->_layout(false);
}
@@ -36,7 +36,7 @@ class FreshRSS_javascript_Controller extends Minz_ActionController {
if (strlen($s) >= 60) {
//CRYPT_BLOWFISH Salt: "$2a$", a two digit cost parameter, "$", and 22 characters from the alphabet "./0-9A-Za-z".
$this->view->salt1 = substr($s, 0, 29);
$this->view->nonce = sha1($salt . uniqid(mt_rand(), true));
$this->view->nonce = sha1($salt . uniqid('' . mt_rand(), true));
Minz_Session::_param('nonce', $this->view->nonce);
return; //Success
}
@@ -52,6 +52,6 @@ class FreshRSS_javascript_Controller extends Minz_ActionController {
for ($i = 22; $i > 0; $i--) {
$this->view->salt1 .= $alphabet[mt_rand(0, 63)];
}
$this->view->nonce = sha1(mt_rand());
$this->view->nonce = sha1('' . mt_rand());
}
}