mirror/FreshRSS
0
0
Fork 0
mirror of https://github.com/FreshRSS/FreshRSS.git synced 2026-04-04 22:53:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

PHPStan prepare exceptions (#6037)

Browse Source 
Take advantage of
https://phpstan.org/blog/bring-your-exceptions-under-control

Minimum changes to pass `tooWideThrowType` and `implicitThrows`.

Revert some mistakes from:
https://github.com/FreshRSS/FreshRSS/pull/5504
Preparation needed before new PRs of the same type:
https://github.com/FreshRSS/FreshRSS/pull/5962

Fix several wrong PHPDocs and catches:

> Method ... has ...Exception in PHPDoc @throws tag but it's not thrown.

> Dead catch - ...Exception is never thrown in the try block.
This commit is contained in:
Alexandre Alapetite
2024-01-15 10:36:30 +01:00
committed by GitHub
parent 52f6c8399b
commit 314077a457
41 changed files with 217 additions and 177 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Models/UserQuery.php
View File

@@ -109,8 +109,6 @@ class FreshRSS_UserQuery {
/**
* Parse the query string when it is a "category" query
*
* @throws FreshRSS_DAO_Exception
*/
private function parseCategory(int $id): void {
if ($this->category_dao === null) {
@@ -127,8 +125,6 @@ class FreshRSS_UserQuery {
/**
* Parse the query string when it is a "feed" query
*
* @throws FreshRSS_DAO_Exception
*/
private function parseFeed(int $id): void {
if ($this->feed_dao === null) {
@@ -145,8 +141,6 @@ class FreshRSS_UserQuery {
/**
* Parse the query string when it is a "tag" query
*
* @throws FreshRSS_DAO_Exception
*/
private function parseTag(int $id): void {
if ($this->tag_dao === null) {