PHPStan Level 7 complete DAOs (#5354)

* PHPStan Level 7 complete DAOs

* Finalise PHPStan Level 7 for CategoryDAO

* PHPStan Level 7 for Context and Search

* Apply suggestions from code review

Co-authored-by: Luc SANCHEZ <4697568+ColonelMoutarde@users.noreply.github.com>
This commit is contained in:
Alexandre Alapetite
2023-05-02 14:38:32 +02:00
committed by GitHub
parent 4de1d5efea
commit bd9fa803f1
15 changed files with 234 additions and 247 deletions

View File

@@ -128,7 +128,7 @@ class FreshRSS_UserQuery {
throw new FreshRSS_DAO_Exception('Category DAO is not loaded in UserQuery');
}
$category = $this->category_dao->searchById($id);
if ($category) {
if ($category !== null) {
$this->get_name = $category->name();
} else {
$this->deprecated = true;
@@ -146,7 +146,7 @@ class FreshRSS_UserQuery {
throw new FreshRSS_DAO_Exception('Feed DAO is not loaded in UserQuery');
}
$feed = $this->feed_dao->searchById($id);
if ($feed) {
if ($feed !== null) {
$this->get_name = $feed->name();
} else {
$this->deprecated = true;
@@ -164,7 +164,7 @@ class FreshRSS_UserQuery {
throw new FreshRSS_DAO_Exception('Tag DAO is not loaded in UserQuery');
}
$tag = $this->tag_dao->searchById($id);
if ($tag) {
if ($tag !== null) {
$this->get_name = $tag->name();
} else {
$this->deprecated = true;