Commit Graph

2431 Commits

Author SHA1 Message Date
Alexandre Alapetite
4e2dff4591 Add spell checking with typos (#4138)
* Add spell checking with typos
Implement https://github.com/FreshRSS/FreshRSS/pull/4134#issuecomment-1008027558

* GitHub Actions attempt

* Quiet wget

* Makefile
2022-01-09 18:21:40 +01:00
Alexandre Alapetite
1acd3ab09b Use typographic quotes (#4133)
* Use typographic quotes

* A few fixes

* Fix

* Fix not saved

* Implement feedback

* Detail

* Revert spoken English fixes
Left for a future dedicated discussion

* More reverts

* Final reverts

* Final minor
2022-01-08 21:58:55 +01:00
Thomas Renes
916df412f5 Fix various typos and spelling errors in documentation, comments and code. (#4134) 2022-01-08 16:25:17 +01:00
Alexis Degrugillier
127b7f0a3a Change i18n process (#4131)
Before, the ignore info were stored in a different file which was a bit cumbersome
for new comers. Now, this info is stored directly in the translation file as a
comment.

Before, there was no way of telling translators that a previously translated string
was in need of a new translation. Now, the dirty information is there to convey that
info.
2022-01-08 14:00:26 +01:00
Luc SANCHEZ
ed19445f74 Optimise Minz_ModelPdo::class (#4119)
* - Fix typo,
- remove unnecessary null in property,
- remove unused property,
- add phpDoc,
- add ext PDO in composer.json,
- use strict comparison,
- indentation

* Translate

* Update lib/Minz/ModelPdo.php

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* The code is more explicite

* Fix phpstan

* Fix phpstan expect one

* Fix phpstan

* Return in back...

* make fix-all

* Fix exception and more types

* Fix more types

* Remove ext- in composer.json

Co-authored-by: Luc SANCHEZ <l.sanchez-ext@ubitransport.com>
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2022-01-07 10:05:09 +01:00
maTh
f8c5df28ab delete the no-mobile css class (#4128) 2022-01-07 00:35:58 +01:00
Alexandre Alapetite
8e398d24f1 Fix several PHP8.1 warnings (#4123)
* Fix several PHP8.1 warnings
Taking advantage of https://github.com/FreshRSS/FreshRSS/pull/4121

* Couple oh type hints missing

* Compatibility PHP 7

* Fix variadic PHPDocs syntax
2022-01-06 22:39:35 +01:00
Frans de Jonge
d339b6dd45 [CI] PHPCS: check for opening brace on same line (#4122)
* [CI] PHPCS: check for opening brace on same line

* make fix-all

* Minor comments

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2022-01-05 00:52:24 +01:00
Alexandre Alapetite
1335a0e3cf PHPStan level 5 (#4110)
* Fix most PHPDocs errors
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types

* Avoid func_get_args
Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list
And avoid dynamic functions names when possible to more easily identify calls and unused functions.
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103

* PHPStan level 3

* PHPStand level 4

* Update default to PHPStan level 4

* Towards level 5

* Fix level 4 regression

* Towards level 5

* Pass PHPStan level 5

* Towards level 6

* Remove erronenous regression from changelog
https://github.com/FreshRSS/FreshRSS/pull/4116
2022-01-04 13:59:09 +01:00
Alexandre Alapetite
a19b4534f9 Fix regression user init (#4116)
#fix https://github.com/FreshRSS/FreshRSS/issues/4115
2022-01-02 18:19:40 +01:00
Alexandre Alapetite
3f6aa42b81 Fix most PHPDocs errors (#4107)
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types
2022-01-01 11:26:56 +01:00
Alexandre Alapetite
77e9877316 Add PHPStan (#4021)
* Add PHPStan
#fix https://github.com/FreshRSS/FreshRSS/issues/4016
https://phpstan.org/

```sh
composer run-script phpstan
```

* More fixes

* Fix global variables

* Add .phtml

* Fix merge
https://github.com/FreshRSS/FreshRSS/pull/4090

* Fix more warnings

* Fix view errors and enable in CI

* ReturnTypeWillChange

* Dynamic view type

* Fix Minz static/self bug
2021-12-31 17:00:51 +01:00
maTh
09c84fb3bc Improved: install.php code quality (#4099)
* delete unused $user_default_config

* move inner named function

* moved $auth_type

* improve readability

* phpcs fixes
2021-12-31 13:50:32 +01:00
maTh
5cac8cce74 Improve: Aside slider: close slider when click on the outside of slider (#4061)
* CSS + PHTML

* give some grey background

* fixed whitespace

* fixed RTL

* close area just for mobile view
2021-12-31 13:17:38 +01:00
maTh
f27b25d9a6 fix (#4065) 2021-12-31 13:16:35 +01:00
Alexandre Alapetite
f13ef3b102 Fix article filter (#4092)
#fix https://github.com/FreshRSS/FreshRSS/issues/4057
Several search filters where missing for the automatic article actions
2021-12-31 13:13:03 +01:00
Alexandre Alapetite
fb15a2d804 Search on article IDs (#4058)
* Search on article IDs
Partial implementation of https://github.com/FreshRSS/FreshRSS/issues/4053
2021-12-31 13:10:41 +01:00
maTh
25954de759 Fix: loading wheel (#4082)
* fix anoym. user

* fix global view

* Update app/views/helpers/pagination.phtml

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update global_view.js

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2021-12-28 11:52:03 +01:00
Virgil Chen
9e901d0eed fix: incorrect translations (#4084) 2021-12-27 12:24:58 +01:00
Alexandre Alapetite
20c8382c25 Fix invalid user (#4081)
#fix https://github.com/FreshRSS/FreshRSS/issues/4080
Initialise the default user to be able to display the error page
2021-12-24 18:44:34 +01:00
maTh
7a81865e41 Update UserMailer.php (#4076) 2021-12-21 23:44:53 +01:00
maTh
6b046873da fix global view template (#4043) 2021-12-09 08:57:21 +01:00
maTh
343c7bf3cb fix normal and reader view (#4040) 2021-12-07 23:20:58 +01:00
maTh
1d624d041f Fix: global view does not show "no articles to show" alert (#4042)
* fix

* phpcs fixed

* fix JS
2021-12-07 23:19:58 +01:00
Tibor Repček
f62633172c Updated translation (#4038)
I translated strings with "TODO - Translation" comment. ;)
2021-12-07 23:16:33 +01:00
Tibor Repček
482b17789b Updated translation (#4036)
I translated strings with "TODO - Translation" comment. ;)
2021-12-06 19:22:19 +01:00
Tibor Repček
be77c466af Updated translation (#4035)
I translated strings with "TODO - Translation" comment. ;)
2021-12-06 19:21:34 +01:00
Tibor Repček
8c3f205e91 Updated translation (#4034)
I translated strings with "TODO - Translation" comment. ;)
2021-12-06 19:20:58 +01:00
Tibor Repček
ba4a41c417 Updated translation (#4033)
I translated strings with "TODO - Translation" comments. ;)
2021-12-06 19:20:40 +01:00
Tibor Repček
62b79272d8 Updated translation (#4032)
I translated string with "TODO - Translation" comment. ;)
2021-12-06 19:20:24 +01:00
Tibor Repček
9a7c760ec1 Updated translation (#4031)
I translated strings with "TODO - Translation" comment. ;)
2021-12-06 19:20:09 +01:00
Tibor Repček
e56157dcee Updated translation (#4030)
I translated strings with "TODO - Translate" comment. ;)
2021-12-06 19:19:46 +01:00
maTh
754a7b27b6 Fix reader view header (#4015)
* fix the hyperlink underline

* add mouse title

* improve German mouse titles

* fixed whitespaces

* use the same title in config/display like in normal/reader view

* i18n German: Discard change for this String

* delete unused gen.action.mark_favorite
2021-12-05 21:42:06 +01:00
312k
19c2cb7f05 Updated japanese translation on 3898 (#4026) 2021-12-05 17:05:49 +01:00
Bartosz Taudul
c2249a9afd Update polish translation. (#4027) 2021-12-05 17:04:43 +01:00
maTh
a54aa19dc7 Fix: double main tags (#4014)
* replace div with main

* include the slider into main

* format source

* add close icon for the extension slider

* replace div with main

* Update shortcut.phtml

* fixed the nits
2021-12-03 00:57:32 +01:00
Alexandre Alapetite
00dbde68fb Fix some PHPstan errors (#4019)
Fix some wrong variables found by https://github.com/FreshRSS/FreshRSS/issues/4016
2021-12-02 23:30:13 +01:00
Alexandre Alapetite
a2ab9cf83a Minz request avoid custom methods (#4020)
Take advantage of PHP7+ null-coalescing operator `??` to make code more standard, shorter, and faster instead of custom function with no extra functionality.

Allows code to be better tested and fix two PHPstan errors:

```
 ------ -----------------------------------------
  Line   app/Controllers/configureController.php
 ------ -----------------------------------------
  410    Cannot unset offset 'rid' on string.
 ------ -----------------------------------------

 ------ ------------------------------------
  Line   lib/Minz/FrontController.php
 ------ ------------------------------------
  70     Cannot unset offset 'c' on string.
  71     Cannot unset offset 'a' on string.
 ------ ------------------------------------
```

https://github.com/FreshRSS/FreshRSS/issues/4016
2021-12-02 23:25:07 +01:00
Alexandre Alapetite
4e00c2d337 Fix more PHP 8.1 null warnings (#4018)
Follow-up of https://github.com/FreshRSS/FreshRSS/pull/4012
2021-12-02 21:05:28 +01:00
maTh
48ca0bb764 related_tags (#4008) 2021-12-01 13:19:17 +01:00
maTh
c5d444e8df Fix JS error: new-article missed (#3999) 2021-11-30 22:20:43 +01:00
maTh
392861b7c3 Switch category - remember status filter (#3986)
* url parameter

* fixed phpcs

* rename variables
2021-11-24 09:10:23 +01:00
maTh
9f7a973ca0 improved HTML (#3989) 2021-11-24 09:08:19 +01:00
maTh
af85a754ad improved HTML (#3990) 2021-11-24 09:06:46 +01:00
maTh
a5410f6d37 Fix issue with mark-all-as-read-button in anonym. mode (#3944)
* fix

* Update p/scripts/main.js

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-11-15 22:03:26 +01:00
Alexandre Alapetite
e61cc3153a Additional HTTP error codes (#3981) 2021-11-15 13:44:14 +01:00
maTh
1ae5a5af14 Improve mobile view: access to the config menu (#3881)
* wip

* improve the header

* Fix theme "Adark"

* fixed theme: Ansum

* Fixed theme: BlueLagoon

* fixed Ansum after PR comment of Frenzie

* Fixed theme: Dark

* fixed theme: Flat

* fixed theme: Mapco

* fixed theme: Origine compact

* fixed theme: Pafat

* fixed theme: Screwdriver

* fixed theme: Swage

* hide the close button in wide view

* fixed base/template RTL

* fixed SCSS of theme Swage

* stylelint fix

* fixed theme Swage

* make fix-all

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-11-12 08:57:36 +01:00
maTh
a29894610b a to button (#3969) 2021-11-11 20:07:10 +01:00
maTh
079b7b961f Improve install routine: database password input with "show password" button (#3962)
* wip

* CSS better btn

* CSS: RTL

* button is better than a

* improved CSS for button
2021-11-11 20:01:28 +01:00
maTh
26afec2379 Fix label management (#3959)
* disable inputs

* fix create empty tags

* Update app/Controllers/tagController.php

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* Update app/views/tag/index.phtml

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* Small additional checks

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-11-11 19:57:05 +01:00