Alexandre Alapetite
1335a0e3cf
PHPStan level 5 ( #4110 )
...
* Fix most PHPDocs errors
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types
* Avoid func_get_args
Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list
And avoid dynamic functions names when possible to more easily identify calls and unused functions.
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
* PHPStan level 3
* PHPStand level 4
* Update default to PHPStan level 4
* Towards level 5
* Fix level 4 regression
* Towards level 5
* Pass PHPStan level 5
* Towards level 6
* Remove erronenous regression from changelog
https://github.com/FreshRSS/FreshRSS/pull/4116
2022-01-04 13:59:09 +01:00
Alexandre Alapetite
3f6aa42b81
Fix most PHPDocs errors ( #4107 )
...
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types
2022-01-01 11:26:56 +01:00
Alexandre Alapetite
77e9877316
Add PHPStan ( #4021 )
...
* Add PHPStan
#fix https://github.com/FreshRSS/FreshRSS/issues/4016
https://phpstan.org/
```sh
composer run-script phpstan
```
* More fixes
* Fix global variables
* Add .phtml
* Fix merge
https://github.com/FreshRSS/FreshRSS/pull/4090
* Fix more warnings
* Fix view errors and enable in CI
* ReturnTypeWillChange
* Dynamic view type
* Fix Minz static/self bug
2021-12-31 17:00:51 +01:00
maTh
25954de759
Fix: loading wheel ( #4082 )
...
* fix anoym. user
* fix global view
* Update app/views/helpers/pagination.phtml
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com >
* Update global_view.js
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com >
2021-12-28 11:52:03 +01:00
maTh
6b046873da
fix global view template ( #4043 )
2021-12-09 08:57:21 +01:00
maTh
343c7bf3cb
fix normal and reader view ( #4040 )
2021-12-07 23:20:58 +01:00
maTh
1d624d041f
Fix: global view does not show "no articles to show" alert ( #4042 )
...
* fix
* phpcs fixed
* fix JS
2021-12-07 23:19:58 +01:00
maTh
754a7b27b6
Fix reader view header ( #4015 )
...
* fix the hyperlink underline
* add mouse title
* improve German mouse titles
* fixed whitespaces
* use the same title in config/display like in normal/reader view
* i18n German: Discard change for this String
* delete unused gen.action.mark_favorite
2021-12-05 21:42:06 +01:00
maTh
a54aa19dc7
Fix: double main tags ( #4014 )
...
* replace div with main
* include the slider into main
* format source
* add close icon for the extension slider
* replace div with main
* Update shortcut.phtml
* fixed the nits
2021-12-03 00:57:32 +01:00
Alexandre Alapetite
a2ab9cf83a
Minz request avoid custom methods ( #4020 )
...
Take advantage of PHP7+ null-coalescing operator `??` to make code more standard, shorter, and faster instead of custom function with no extra functionality.
Allows code to be better tested and fix two PHPstan errors:
```
------ -----------------------------------------
Line app/Controllers/configureController.php
------ -----------------------------------------
410 Cannot unset offset 'rid' on string.
------ -----------------------------------------
------ ------------------------------------
Line lib/Minz/FrontController.php
------ ------------------------------------
70 Cannot unset offset 'c' on string.
71 Cannot unset offset 'a' on string.
------ ------------------------------------
```
https://github.com/FreshRSS/FreshRSS/issues/4016
2021-12-02 23:25:07 +01:00
maTh
c5d444e8df
Fix JS error: new-article missed ( #3999 )
2021-11-30 22:20:43 +01:00
maTh
9f7a973ca0
improved HTML ( #3989 )
2021-11-24 09:08:19 +01:00
maTh
af85a754ad
improved HTML ( #3990 )
2021-11-24 09:06:46 +01:00
maTh
a5410f6d37
Fix issue with mark-all-as-read-button in anonym. mode ( #3944 )
...
* fix
* Update p/scripts/main.js
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-11-15 22:03:26 +01:00
maTh
a29894610b
a to button ( #3969 )
2021-11-11 20:07:10 +01:00
maTh
26afec2379
Fix label management ( #3959 )
...
* disable inputs
* fix create empty tags
* Update app/Controllers/tagController.php
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
* Update app/views/tag/index.phtml
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
* Small additional checks
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-11-11 19:57:05 +01:00
maTh
181a54289a
Update details.phtml ( #3966 )
2021-11-08 22:37:29 +01:00
maTh
f0fa3f3202
New shortcut: actualize feeds ( #3900 )
...
* configs
* i18n
* improved
* Update app/i18n/fr/conf.php
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
* Update p/scripts/main.js
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
* Update main.js
* Update conf.php
* make fix-all
* i18n
* i18n
* i18n: delete conf.shortcut.actualize
* Update app/views/configure/shortcut.phtml
2021-10-28 01:24:44 +02:00
maTh
76f722f5fe
Follow up of 3814 ( #3910 )
...
* fixed the whitespace in value of username input
* fixed a HTML structure fault
2021-10-21 14:21:45 +02:00
maTh
c5cfb2ac07
fixed: add feed: advanced: white space char as default password ( #3814 )
...
* fixed space char as default password
* fix: whitespace in feed http username configuration
* fix: type=password
* extend the type=password with the watch-password-plain button
* init_extra() again for new slider content
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-10-21 12:47:50 +02:00
maTh
3623a5421d
enhancement subscription management page ( #3893 )
...
* wip
* wip2
* i18n
* Update app/views/helpers/category/update.phtml
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com >
* fixed box layout
* Revert "i18n"
This reverts commit a2e4d8ace6 .
* i18n
This reverts commit 55236930cf .
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com >
2021-10-19 15:08:32 +02:00
stysebae
85b898c623
Add shortcut to jump to next unread article (issue #3393 ) ( #3891 )
...
* Add shortcut to jump to next unread article
* phpcbf
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-10-19 10:46:39 +02:00
maTh
f934eb981e
fix ( #3888 )
2021-10-16 13:14:18 +02:00
maTh
c23702eaa5
Fix #3835 : theme switcher broken when theme is not available ( #3874 )
...
* FIx the function: add an error slide
* i18n for the error message
* fix the message
* i18n: nl
* phpcbf
* Typographic quotation marks
+fr +en-US
* Unicode instead of entities
* Whitespace
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-10-16 12:44:02 +02:00
maTh
e9b62d1d76
fix #3661 : not logged in user: button to mark all as read leads to HTTP403 error ( #3871 )
...
* fix
* optimized
* Fix href
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-10-16 12:19:20 +02:00
maTh
02641de32e
Stats: replace flotr2 with chart.js ( #3858 )
...
* include Chart.js
* page: main statistics. Flotr.js replaced with Chart.js
* main stats + repartition
* Delete: repartition.js + stats.js
* delete flotr2
* add libs in README
* polish
* code polish
* fixed amount of week days and months
* added manget link for LibreJS
* added: @license-end
* phpcbf + jshint formatting
* delete old code
* fix stats
* fix Comments
* finally I found the issue and fixed its best
* fix the month stats
* Whitespace fixes
* Remove flotr2
* Rename to chart.min.js
* Remove console.log
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-10-16 12:00:07 +02:00
Alexandre Alapetite
ebf9c70ebd
Automatic fix minor syntax previous commits
2021-10-14 13:59:31 +02:00
maTh
d2a95ef2a6
fix ( #3876 )
2021-10-14 13:32:05 +02:00
maTh
b673c53e07
fix ( #3883 )
2021-10-14 13:24:05 +02:00
Alexandre Alapetite
a7aca6c0ab
Improved feed action filters ( #3303 )
...
* Re-order some feed options
* Option to auto mark as read existing titles
* Option to keep at max n unread articles per feed
2021-09-19 10:56:38 +02:00
maTh
dfc89831d4
Headline structure improvement (Part 2) ( #3851 )
...
* Update about.phtml
* Update queries.phtml
* Update query.phtml
* Update configure.phtml
* Update profile.phtml
* Update simple.phtml
* update app\views\helpers\category\update.phtml
2021-09-18 12:52:17 +02:00
maTh
8b80c4cc8f
Settings: User queries - layout upgrade ( #3827 )
...
* draft
* deleted the out commeted code
* improved alert messages
* Update queries.phtml
* Theme base-theme/template.css
* fixed theme: Origin
* Fixed: Theme Adark
* Fixed: Theme Ansum
* Fix: Theme BlueLagoon
* Fix: Theme Dark
* Fix: Theme Flat
* Fix: Theme Mapco
* Fix: Theme Mapco (SCSS)
* Fix: Theme Origine-compact
* Fix: Theme Pafat
* Fix: Theme Screwdriver
* Fix: Theme Swage
* Lint CSS, RTL, and i18n
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-09-12 12:06:29 +02:00
maTh
e5e9a417da
Menu: move stats into subscription management ( #3803 )
...
* add stats menu into subscription management menu
* delete stats menu entry from dropdown menu
* Delete aside_stats.phtml
* Update aside_subscription.phtml
2021-09-12 11:50:00 +02:00
Alexandre Alapetite
ff60e24c57
Mailer rename .txt to .txt.php ( #3842 )
...
* Mailer rename .txt to .txt.php
2021-09-11 20:40:45 +02:00
maTh
9712e4d888
Headline structure improvement ( #3830 )
...
* header: h1 deleted - full logo included
* template: config - display
* WIP
* shortcut configs. added fieldset. do not display the border by default
* system.phtml
* subscription: add feed or category
* wip
* wip
* Update bookmarklet.phtml
* Update archiving.phtml
* Update queries.phtml
* Update profile.phtml
* Update manage.phtml
* auth+update
* Update template.rtl.css
* fixed FreshRSS logo (Theme: Mapco)
* Update mapco.rtl.css
* Update _layout.scss
* fixed FreshRSS logo (theme: Dark)
* fix: FreshRSS logo (Theme: BlueLagoon)
* fix: FreshRSS logo (Theme: Ansum)
* fixed: FreshRSS logo (Theme: Alternative Dark)
* fix: FreshRSS logo (Theme: Pafat)
* fix: FreshRSS logo (Theme: Screwdriver)
* fix: FreshRSS logo (theme: Swage)
* Minor lint
* little fix: FreshRSS logo (Theme: Origine)
* Fix: FreshRSS logo (Theme: Origine Compact)
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-09-11 18:22:26 +02:00
maTh
9aed5ef48f
Fixed: overflowing tables on small screens ( #3819 )
...
* fix
* overflow-x
* a better fix, that fix all tables
* Revert "a better fix, that fix all tables"
This reverts commit 3bc9447347 .
* user list table with wrapper
* scrolling table: extension table
2021-09-03 08:35:44 +02:00
maTh
be61a3f771
delete firefox 63 informatoin ( #3822 )
2021-09-02 22:27:37 +02:00
maTh
595979d97f
Add navigation to about page ( #3804 )
...
* add navigation to about page
* empty headline in aside navigation
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-09-02 09:18:20 +02:00
maTh
f1a4cfa482
<pre> -> <kbd> ( #3821 )
2021-09-02 09:11:39 +02:00
ORelio
50ba6bbe07
UI: Add optional thumbnail and summary on feed items ( #3805 )
...
* UI: Add optional thumbnail and summary on feed items
Implements #561
* UI: Thumbnail: Own column, Custom size, Lazy load
* UI: Thumbnail: Remove unnecessary CSS rule
Remove rule already defined in base theme, no override needed
* CSS lint + RTL
* Improve thumbail and summary generation
* Support img alt
* Missing htmlspecialchars
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
2021-08-30 10:58:06 +02:00
maTh
d049277807
fix: changed "for" and "id" ( #3801 )
2021-08-25 13:06:12 +02:00
maTh
6c396997f2
Statistics: improved layout ( #3797 )
...
* css grid layout
* Update repartition.phtml
* scrolling the canvas if it does not fit
2021-08-25 11:52:40 +02:00
maTh
235f16647a
Settings: Display - icons table in mobile view fixed ( #3792 )
...
* fixed all themes
* fixed swage.scss
2021-08-22 23:01:37 +02:00
Alexandre Alapetite
ee2d2db780
Fallback for feeds with empty title ( #3787 )
...
* Fallback for feeds with empty title
Address a part of https://github.com/FreshRSS/FreshRSS/issues/3776 for existing feeds
* Also strip www prefix
* Reuse fallback logic
2021-08-22 13:33:58 +02:00
maTh
93f759fd4f
changed about.phtml ( #3790 )
2021-08-20 23:25:27 +02:00
maTh
f1e15cdd82
Improve the link "back to RSS feeds": set a CSS class ( #3761 )
...
* templates
* improved CSS class names
2021-08-20 14:07:14 +02:00
maTh
92ae9c89a4
fix ( #3765 )
2021-08-14 12:06:00 +02:00
maTh
ab0285b0aa
Add HTML5 tags ( #3651 )
...
* use HTML5 tags #3643
added some HTML5 tags: header, main, nav
* <main> into <div>
as dicussed in the PR.
Todo: check side effects (f.e. threepaneview extension)
* fixed whitespace with tabs
* fixed more whitespaces with tabs
it was not my fault, but I fixed it
* added empty lines as wished
* Update app/views/index/global.phtml
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
* Update app/views/index/global.phtml
* Update app/views/index/global.phtml
* Update app/views/index/global.phtml
* Update app/views/index/global.phtml
* Update app/views/index/global.phtml
* Update app/views/index/global.phtml
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr >
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com >
2021-07-21 22:42:04 +02:00
maTh
3ed9d00f0a
changed <h2> to <legend> ( #3676 )
...
* changed <h2> to <legend>
* white spaces replaced to tabs
Thanks for the review
* fixed shortcut.phtml headline
legend -> h2
* fixed bookmarklet.phtml headline
legend -> h2
2021-07-11 14:58:41 +02:00
Alexis Degrugillier
3c3eab768e
Fix user creation form redirection ( #3656 )
...
Before, when there was an error during the user creation process, the user was
always redirected to the same page no matter where the creation process was
initiated (registration or creation by an admin). Thus, there were no error
messages displayed when something went bad during the creation process by an
admin.
Now, the origin of the user creation has been added to the form to be able to
redirect the user to the proper page.
2021-06-01 14:16:33 +02:00