Commit Graph

352 Commits

Author SHA1 Message Date
Alexandre Alapetite
4e2dff4591 Add spell checking with typos (#4138)
* Add spell checking with typos
Implement https://github.com/FreshRSS/FreshRSS/pull/4134#issuecomment-1008027558

* GitHub Actions attempt

* Quiet wget

* Makefile
2022-01-09 18:21:40 +01:00
Alexandre Alapetite
1acd3ab09b Use typographic quotes (#4133)
* Use typographic quotes

* A few fixes

* Fix

* Fix not saved

* Implement feedback

* Detail

* Revert spoken English fixes
Left for a future dedicated discussion

* More reverts

* Final reverts

* Final minor
2022-01-08 21:58:55 +01:00
Thomas Renes
916df412f5 Fix various typos and spelling errors in documentation, comments and code. (#4134) 2022-01-08 16:25:17 +01:00
Offerel
f905ad772e Check data URI (#4098)
* Check data URI
2021-12-31 13:14:15 +01:00
maTh
25954de759 Fix: loading wheel (#4082)
* fix anoym. user

* fix global view

* Update app/views/helpers/pagination.phtml

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update global_view.js

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2021-12-28 11:52:03 +01:00
maTh
1d624d041f Fix: global view does not show "no articles to show" alert (#4042)
* fix

* phpcs fixed

* fix JS
2021-12-07 23:19:58 +01:00
Frans de Jonge
ba48733f17 Add preventDefault to keydown event handler (#4013)
* Add preventDefault to keydown event handler

Fixes #3946.

* review

* silence technically correct but missing the picture check

Co-authored-by: Frans de Jonge <frans@clevercast.com>
2021-12-03 00:58:40 +01:00
maTh
a5410f6d37 Fix issue with mark-all-as-read-button in anonym. mode (#3944)
* fix

* Update p/scripts/main.js

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-11-15 22:03:26 +01:00
maTh
f12637d2b2 Fix js errors (#3980)
* fixed missed popup

* fix missed document.getElementById('loginButton')

* make fix-all

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-11-14 23:24:47 +01:00
maTh
387343a0e1 fixed: Shortcuts in "Anonym. Mode" broken (#3897) (#3945)
* fix

* improved delayClick()

* Do not send empty mark as read request

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-11-04 22:22:39 +01:00
maTh
530aa0bb3a fix main.js (#3956) 2021-11-02 23:45:38 +01:00
maTh
9326e419e3 fix typo (#3949) 2021-10-30 18:45:05 +02:00
maTh
c5cfb2ac07 fixed: add feed: advanced: white space char as default password (#3814)
* fixed space char as default password

* fix: whitespace in feed http username configuration

* fix: type=password

* extend the type=password with the watch-password-plain button

* init_extra() again for new slider content

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-10-21 12:47:50 +02:00
Alexandre Alapetite
008cbfef2c Fix global context (#3909)
Regression from https://github.com/FreshRSS/FreshRSS/pull/3906
2021-10-21 12:47:31 +02:00
Alexandre Alapetite
b438d8bb3d ESLint upgrade from JSHint (#3906)
* ESLint upgrade from JSHint
* commit corresponding package.json
* `npm run fix` for automatic JS and CSS fixes
* Keep JSHint config for now
2021-10-21 11:44:03 +02:00
maTh
cfd625c559 close panel with esc shortcut (#3901)
* ESC as shortcut to close

* some little beauty

* only ESC close the list now

* Update template.rtl.css

* fixed onclick listener

* Update global_view.js

* heebie jeebies fix ;-)

* Update p/scripts/global_view.js

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-10-21 11:33:35 +02:00
maTh
3623a5421d enhancement subscription management page (#3893)
* wip

* wip2

* i18n

* Update app/views/helpers/category/update.phtml

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* fixed box layout

* Revert "i18n"

This reverts commit a2e4d8ace6.

* i18n

This reverts commit 55236930cf.

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2021-10-19 15:08:32 +02:00
stysebae
85b898c623 Add shortcut to jump to next unread article (issue #3393) (#3891)
* Add shortcut to jump to next unread article

* phpcbf

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-10-19 10:46:39 +02:00
Frans de Jonge
24c2c47d4b [chore] Replace direct .onkeydown override with addEventListener (#3902)
Removes inextensible bad example to prevent it from being copied. See <https://github.com/FreshRSS/FreshRSS/pull/3901/files#r731292613>.
2021-10-19 10:05:30 +02:00
maTh
f934eb981e fix (#3888) 2021-10-16 13:14:18 +02:00
maTh
02641de32e Stats: replace flotr2 with chart.js (#3858)
* include Chart.js

* page: main statistics. Flotr.js replaced with Chart.js

* main stats + repartition

* Delete: repartition.js + stats.js

* delete flotr2

* add libs in README

* polish

* code polish

* fixed amount of week days and months

* added manget link for LibreJS

* added: @license-end

* phpcbf + jshint formatting

* delete old code

* fix stats

* fix Comments

* finally I found the issue and fixed its best

* fix the month stats

* Whitespace fixes

* Remove flotr2

* Rename to chart.min.js

* Remove console.log

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-10-16 12:00:07 +02:00
maTh
93e73855ec Delete jQuery (#3847)
* delete jquery.min.js lib
2021-09-13 08:02:09 +02:00
Frans de Jonge
9178fd30c2 Statistics: update Flotr2 to latest release from EnterpriseDB (#3800)
It contains a few minor fixes for Google's breaking changes in Blink.

See <https://github.com/EnterpriseDB/Flotr2> for the repo.

Cf. <https://github.com/FreshRSS/FreshRSS/pull/3799#issuecomment-905370969>
2021-08-28 21:33:35 +02:00
Frans de Jonge
6304c56b60 Statistics: dynamically resize (#3799)
* Statistics: dynamically resize

Follow-up on <https://github.com/FreshRSS/FreshRSS/pull/3797>.

* also do 'repartiton'
2021-08-25 15:52:28 +02:00
maTh
991ee64db2 3672 notification icon (#3678)
* icon with padding to border

* resized icon to 256
2021-06-28 21:10:12 +02:00
Alexis Degrugillier
d6a0af6ba0 Fix navigation JS error (#3655)
Before, the UP navigation button was generating an error when no article was
selected. The process to navigate to the first element was using the position
of the current element to compute the offset, thus generating said error.
Now, if no article is selected, the first article is used as a fall-back.

See #3654
2021-06-01 09:36:26 +02:00
Alexandre Alapetite
51ed59dcc6 jQuery 3.6.0 (#3501)
https://blog.jquery.com/2021/03/02/jquery-3-6-0-released/
2021-03-07 12:54:17 +01:00
Alexandre Alapetite
947e918f05 Travis: Enforce phpcs line length + whitespace (#3488)
* Update Travis line length

* Also check whitespace in CSS files

* Fix line length ext.php

* More syntax, string templates

* Fix exclude-pattern

* Test JS files as well
2021-02-28 12:26:24 +01:00
Alexis Degrugillier
5c18c64afb Change integration configuration page (#3372)
I've refactored the user query code to be able to use it also on the
integration configuration page. Now, items can be re-organized as in
the user query list.
2021-01-16 22:11:30 +01:00
Alexis Degrugillier
c5da4e56a6 Add a query configuration page (#3366)
* Add a query configuration page

Before, there was no way to modify a user query. Thus you need to
create a new one and delete the old one afterward.
Now, every user query can be modified if needed. They have their
own configuration page on which it can be modified or deleted.

* Change drag and drop action on queries

Before, the drag and drop action needed to be validated by submitting
the form to be persisted.
Now, it's done automatically after the query is dropped to its final
location.
2021-01-15 00:14:53 +01:00
Alexis Degrugillier
e3457f7d7b Add drag & drop marker on user query list (#3355)
Before, it was nearly impossible to know exactly where the dragged
item will land when dropping it.
Now, there is a visual marker to show the drop location.

An HR tag is inserted dynamically in the DOM. It's possible to style
it if needed.
2021-01-13 20:34:45 +01:00
Alexis Degrugillier
896f9d3363 Add user query manual sorting (#3346)
* Add user query manual sorting

Before, to change the user query order, you'll have to delete them
and recreate them. It was not really efficient.
Now, you can drag and drop them to ease reordering.

See #2216 and #2015

* Remove cancel action on user query configuration

Before, the cancel action was useless since it was not wired.
Now, there is no cancel action.

See #2015
2021-01-09 01:47:20 +01:00
Clemens Neubauer
ef458992c1 two new hooks (#3342)
* add two new hooks

I develop a new extension and i need 2 new hooks for it

* update EN documentation

* Correct typing errors

* Update app/views/helpers/javascript_vars.phtml

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-01-07 21:45:48 +01:00
Alexis Degrugillier
46c8f6e77b Add clipboard sharing (#3330)
When the discussion #3327 started, I thought that the clipboard share
is a good idea. It never occurred to me because I do not use a
smartphone.
It might need some polishing but it seems pretty usable as-is.

See #3327
2021-01-03 18:20:15 +01:00
Alexandre Alapetite
5ca961b8d5 Fix bugs in anomymous mode (#3305)
* Fix bugs in anomymous mode

Login bug (submit button not working) and refresh bug (JS null
exception, and then 403).

* Take advantage of existing variable
2020-12-31 00:13:29 +01:00
Alexandre Alapetite
48e0464e4b Prevent login before extra.js is loaded (#3275)
Disable submit button until extra.js with its crypto functions is
loaded.
2020-12-22 17:36:50 +01:00
Prashant Tholia
6f23999c7b Remember open categories (#3185)
* feature(normal) - Remember opened categories in the left menu

Session storage based implementation to remember opened categories in left menu

Issue Ref: #2248

* lib_phpQuery updates

* Updates covering feedback points and functionality fixes

* Feedback updates

* Revert "lib_phpQuery updates"

This reverts commit dcd23b9418.

* First review

Change variable name to "remember" instead of "open".
Start using localStorage instead of sessionStorage.
Simplify code.

* Simplify remember categories init function

Replace 'session' with 'local' in function names and comment

Set open categories CSS as same as when category is opened in 'active' unfold mode

* Remove URLSearchParams check in remember categories init function

* Delete open categories on login and logout

* JSHint check fix

* Second review

* Make new mode the default for new users
* Always open active category
* Reduce / simplify code

* i18n French

* Revert default value

Wait a bit more for this decision / change

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2020-11-02 12:03:16 +01:00
Alexandre Alapetite
a69a7531b6 Remember sidebar position (#3231)
#fix https://github.com/FreshRSS/FreshRSS/issues/3209
Extracted from https://github.com/FreshRSS/FreshRSS/pull/3185
2020-10-19 11:38:27 +02:00
Alexandre Alapetite
191cda42e6 Misc. minor
Whitespace...
2020-10-11 10:59:43 +02:00
Alexis Degrugillier
dc68783fc8 Add controls on media (#3036)
Now, there is a shortcut to play or pause media available from an
entry. If there is more than one media available, only the first
one will be targeted.

See #1952
2020-06-05 23:37:05 +02:00
Alexis Degrugillier
d4554fa087 Change add feed action (#3027)
* Docker Alpine 3.12 (#3025)

https://alpinelinux.org/posts/Alpine-3.12.0-released.html
With PHP 7.3.18 (from 7.3.17) (and Apache 2.4.43 unchanged).
No other significant change spotted

* Ensure feed attributes are used before load

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2020-06-05 10:09:31 +02:00
Alexandre Alapetite
0d74cb8a42 Fix JS show password in install (#2999)
The button for showing the password was not working in the install.
Updated JavaScript file to ES6 at the same time.
2020-05-25 19:03:42 +02:00
Alexandre Alapetite
3bef867a44 Better hide spinner (#2990)
Fix https://github.com/FreshRSS/FreshRSS/issues/2986#issuecomment-631396735
By CSS, and also by JS
https://framagit.org/nicofrand/xextension-threepanesview/-/issues/10
2020-05-21 12:17:21 +02:00
Alexandre Alapetite
bba9535626 jQuery 3.5.1 (#2982)
Minor version
https://blog.jquery.com/2020/05/04/jquery-3-5-1-released-fixing-a-regression/
2020-05-16 16:44:15 +02:00
Alexandre Alapetite
e9213e89f4 Fix CSS Edge glitch in archiving options (#2906)
With Edge, only setting `.hidden = true` does not make the element and
sub-elements properly visible.
Should not make any difference for other browser.
2020-04-18 11:50:35 +02:00
Alexandre Alapetite
f2e0f051aa Fix JS for statistics repartition select form (#2896)
* Fix JS for statistics repartition select form

Error was: `s.form is null in extra.js:166:7`
At the same time, disable the form and clears the value while waiting
for the next page to load, to better understand what is happening.

* Whitespace
2020-04-12 16:40:06 +02:00
Alexandre Alapetite
14fa3f2781 jQuery 3.5.0 (#2895)
https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/
2020-04-12 11:37:50 +02:00
Alexandre Alapetite
0d235cbadd Swap shortcuts for mark all articles as read / mark previous articles as read (#2881)
* Swap shortcuts for mark all articles as read / mark previous articles as read

#fix https://github.com/FreshRSS/FreshRSS/issues/2865
Follow-up of https://github.com/FreshRSS/FreshRSS/pull/2843
* <kbd>⇧ Shift</kbd>+<kbd>R</kbd> to mark all articles as read;
* <kbd>Alt ⎇</kbd>+<kbd>r</kbd> to mark previous articles as read.

* i18n
2020-04-08 13:17:20 +02:00
Alexandre Alapetite
a7b72481e7 Shortcut mark previous articles as read (#2843)
* Shortcut mark previous articles as read

Address part of https://github.com/FreshRSS/FreshRSS/issues/2836
The shortcut [shift]+[r] now marks previous articles as read;
The previous action of marking all articles as read is now achieved by
[alt]+[r]
So this is a slight breaking change, but I like the logic of the
upward-facing [shift] arrow to hint at previous articles, while [alt] is
more like "all", at least to my eyes :-)

* Update app/i18n/nl/conf.php

Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>

* [⇧ Shift] / [Alt ⎇]

With standard Unicode signs

* <kbd> + CSS styling

* Missing themes

Tested with all themes

* Travis CSS

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2020-03-23 23:05:01 +01:00
Alexandre Alapetite
8fabed337a Reset scroll (#2842)
Address some of https://github.com/FreshRSS/FreshRSS/issues/2836
This patch resets the scrollbar to the top when a FreshRSS page is
initialised.
Makes sure that when a FreshRSS page is restored in a Web browser
session, we do not hit the problematic situation when the content is
refreshed but the scrollbar moved back to where it was, potentially
erroneously marking as read many as read, of landing on the wrong focus.
2020-03-23 22:29:26 +01:00