Commit Graph

1388 Commits

Author SHA1 Message Date
Alexandre Alapetite
4e2dff4591 Add spell checking with typos (#4138)
* Add spell checking with typos
Implement https://github.com/FreshRSS/FreshRSS/pull/4134#issuecomment-1008027558

* GitHub Actions attempt

* Quiet wget

* Makefile
2022-01-09 18:21:40 +01:00
Alexandre Alapetite
1acd3ab09b Use typographic quotes (#4133)
* Use typographic quotes

* A few fixes

* Fix

* Fix not saved

* Implement feedback

* Detail

* Revert spoken English fixes
Left for a future dedicated discussion

* More reverts

* Final reverts

* Final minor
2022-01-08 21:58:55 +01:00
Thomas Renes
916df412f5 Fix various typos and spelling errors in documentation, comments and code. (#4134) 2022-01-08 16:25:17 +01:00
Frans de Jonge
d339b6dd45 [CI] PHPCS: check for opening brace on same line (#4122)
* [CI] PHPCS: check for opening brace on same line

* make fix-all

* Minor comments

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2022-01-05 00:52:24 +01:00
Alexandre Alapetite
1335a0e3cf PHPStan level 5 (#4110)
* Fix most PHPDocs errors
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types

* Avoid func_get_args
Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list
And avoid dynamic functions names when possible to more easily identify calls and unused functions.
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103

* PHPStan level 3

* PHPStand level 4

* Update default to PHPStan level 4

* Towards level 5

* Fix level 4 regression

* Towards level 5

* Pass PHPStan level 5

* Towards level 6

* Remove erronenous regression from changelog
https://github.com/FreshRSS/FreshRSS/pull/4116
2022-01-04 13:59:09 +01:00
Alexandre Alapetite
3f6aa42b81 Fix most PHPDocs errors (#4107)
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types
2022-01-01 11:26:56 +01:00
Alexandre Alapetite
77e9877316 Add PHPStan (#4021)
* Add PHPStan
#fix https://github.com/FreshRSS/FreshRSS/issues/4016
https://phpstan.org/

```sh
composer run-script phpstan
```

* More fixes

* Fix global variables

* Add .phtml

* Fix merge
https://github.com/FreshRSS/FreshRSS/pull/4090

* Fix more warnings

* Fix view errors and enable in CI

* ReturnTypeWillChange

* Dynamic view type

* Fix Minz static/self bug
2021-12-31 17:00:51 +01:00
maTh
0e683ee5d2 fixed themes Origine and Origine compact (#4059)
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-12-31 13:20:20 +01:00
maTh
a29f161e44 fixed: Left navigation with long category names (#4055)
* fixed CSS

* fixed themes Ansum and Mapco

* fixed syntax
2021-12-31 13:19:16 +01:00
maTh
5cac8cce74 Improve: Aside slider: close slider when click on the outside of slider (#4061)
* CSS + PHTML

* give some grey background

* fixed whitespace

* fixed RTL

* close area just for mobile view
2021-12-31 13:17:38 +01:00
maTh
dc70b74ef4 CSS (#4067) 2021-12-31 13:15:55 +01:00
maTh
9fc98317f9 Fix: Thumbnails alt text overflow (#4085)
* CSS fix

* Fix RTL CSS

* fix CSS (order)
2021-12-31 13:15:19 +01:00
Offerel
f905ad772e Check data URI (#4098)
* Check data URI
2021-12-31 13:14:15 +01:00
maTh
25954de759 Fix: loading wheel (#4082)
* fix anoym. user

* fix global view

* Update app/views/helpers/pagination.phtml

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update global_view.js

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2021-12-28 11:52:03 +01:00
maTh
46cb8644c4 Fix: Compressed & Cached JS files (#4075)
* Update .htaccess

* Explicit MIME type for .js
https://developer.mozilla.org/en-US/docs/Learn/Server-side/Configuring_server_MIME_types
https://www.iana.org/assignments/media-types/media-types.xhtml

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-12-21 23:43:59 +01:00
Alexandre Alapetite
816f4178dc Docker fix missing .htaccess (#4074)
Related to https://github.com/FreshRSS/FreshRSS/issues/4073
In our Docker configuration, `.htaccess` files are included only once at startup. The one for themes was missing.
2021-12-20 20:46:41 +01:00
Felix Bühler
1ac3effce5 fever: fix warning of unset array key (#4056) 2021-12-12 13:03:18 +01:00
maTh
1d624d041f Fix: global view does not show "no articles to show" alert (#4042)
* fix

* phpcs fixed

* fix JS
2021-12-07 23:19:58 +01:00
maTh
c25dace809 fix CSS (#4041) 2021-12-07 23:17:34 +01:00
maTh
5050b20cca Fix: search in mobile view (#4025)
* bring back the search in the nav bar

* fix the search input height

* line-heigt improved
2021-12-05 21:36:16 +01:00
Frans de Jonge
ba48733f17 Add preventDefault to keydown event handler (#4013)
* Add preventDefault to keydown event handler

Fixes #3946.

* review

* silence technically correct but missing the picture check

Co-authored-by: Frans de Jonge <frans@clevercast.com>
2021-12-03 00:58:40 +01:00
Alexandre Alapetite
00dbde68fb Fix some PHPstan errors (#4019)
Fix some wrong variables found by https://github.com/FreshRSS/FreshRSS/issues/4016
2021-12-02 23:30:13 +01:00
maTh
f6db32bdfb delete overflow-y (#4005) 2021-11-30 22:28:55 +01:00
maTh
42162c04a0 Fix #4002: transparent config menu (#4003)
* Update template.css

* Update template.rtl.css
2021-11-29 19:59:13 +01:00
maTh
83110b1c49 typo fix (#3998) 2021-11-27 12:23:52 +01:00
maTh
a5410f6d37 Fix issue with mark-all-as-read-button in anonym. mode (#3944)
* fix

* Update p/scripts/main.js

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-11-15 22:03:26 +01:00
maTh
f12637d2b2 Fix js errors (#3980)
* fixed missed popup

* fix missed document.getElementById('loginButton')

* make fix-all

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-11-14 23:24:47 +01:00
maTh
1ae5a5af14 Improve mobile view: access to the config menu (#3881)
* wip

* improve the header

* Fix theme "Adark"

* fixed theme: Ansum

* Fixed theme: BlueLagoon

* fixed Ansum after PR comment of Frenzie

* Fixed theme: Dark

* fixed theme: Flat

* fixed theme: Mapco

* fixed theme: Origine compact

* fixed theme: Pafat

* fixed theme: Screwdriver

* fixed theme: Swage

* hide the close button in wide view

* fixed base/template RTL

* fixed SCSS of theme Swage

* stylelint fix

* fixed theme Swage

* make fix-all

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-11-12 08:57:36 +01:00
maTh
079b7b961f Improve install routine: database password input with "show password" button (#3962)
* wip

* CSS better btn

* CSS: RTL

* button is better than a

* improved CSS for button
2021-11-11 20:01:28 +01:00
maTh
387343a0e1 fixed: Shortcuts in "Anonym. Mode" broken (#3897) (#3945)
* fix

* improved delayClick()

* Do not send empty mark as read request

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-11-04 22:22:39 +01:00
maTh
530aa0bb3a fix main.js (#3956) 2021-11-02 23:45:38 +01:00
maTh
9326e419e3 fix typo (#3949) 2021-10-30 18:45:05 +02:00
proletarius101
d3be01a1da Add pwa (#3890)
* Don't use Chrome or indeed Firefox on Android

Would close #1963. But I will not finish this PR because the idea that every single website on the internet should have to do this is absolutely ridiculous.

* add pwa manifest

Add a pwa manifest as defined in https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Installable_PWAs
- creates shortcuts without the browser frame
- has a splash screen
- has an independent view stack than the browser one

* update manifest as per pwabuilder.com

* add 32x32 and 48x48 icon config

* enhance manifest spec compliance

* change as per suggestions

* Update app/layout/layout.phtml

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* fix mobile icon padding

* remove screen auto rotation

* change theme color to white

* Move meta
(Should not be in the referrer condition)

* JSON HTTP cache

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-10-24 17:28:40 +02:00
maTh
da4f0dea1f add button to open nav panel (#3879) 2021-10-23 13:53:22 +02:00
Alexandre Alapetite
acbba9adb2 Improved markdownlint (#3918)
* Improved markdownlint
* Relaxed rules slighlty
* `npm run markdownlint` for automatic tests
* `npm run markdownlint_fix` for automatic syntax fixing
* Applied the fixes on all our Markdown files
2021-10-23 13:43:24 +02:00
maTh
c5cfb2ac07 fixed: add feed: advanced: white space char as default password (#3814)
* fixed space char as default password

* fix: whitespace in feed http username configuration

* fix: type=password

* extend the type=password with the watch-password-plain button

* init_extra() again for new slider content

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-10-21 12:47:50 +02:00
Alexandre Alapetite
008cbfef2c Fix global context (#3909)
Regression from https://github.com/FreshRSS/FreshRSS/pull/3906
2021-10-21 12:47:31 +02:00
Alexandre Alapetite
b438d8bb3d ESLint upgrade from JSHint (#3906)
* ESLint upgrade from JSHint
* commit corresponding package.json
* `npm run fix` for automatic JS and CSS fixes
* Keep JSHint config for now
2021-10-21 11:44:03 +02:00
maTh
cfd625c559 close panel with esc shortcut (#3901)
* ESC as shortcut to close

* some little beauty

* only ESC close the list now

* Update template.rtl.css

* fixed onclick listener

* Update global_view.js

* heebie jeebies fix ;-)

* Update p/scripts/global_view.js

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-10-21 11:33:35 +02:00
maTh
3623a5421d enhancement subscription management page (#3893)
* wip

* wip2

* i18n

* Update app/views/helpers/category/update.phtml

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* fixed box layout

* Revert "i18n"

This reverts commit a2e4d8ace6.

* i18n

This reverts commit 55236930cf.

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2021-10-19 15:08:32 +02:00
stysebae
85b898c623 Add shortcut to jump to next unread article (issue #3393) (#3891)
* Add shortcut to jump to next unread article

* phpcbf

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-10-19 10:46:39 +02:00
Frans de Jonge
24c2c47d4b [chore] Replace direct .onkeydown override with addEventListener (#3902)
Removes inextensible bad example to prevent it from being copied. See <https://github.com/FreshRSS/FreshRSS/pull/3901/files#r731292613>.
2021-10-19 10:05:30 +02:00
maTh
f934eb981e fix (#3888) 2021-10-16 13:14:18 +02:00
maTh
02641de32e Stats: replace flotr2 with chart.js (#3858)
* include Chart.js

* page: main statistics. Flotr.js replaced with Chart.js

* main stats + repartition

* Delete: repartition.js + stats.js

* delete flotr2

* add libs in README

* polish

* code polish

* fixed amount of week days and months

* added manget link for LibreJS

* added: @license-end

* phpcbf + jshint formatting

* delete old code

* fix stats

* fix Comments

* finally I found the issue and fixed its best

* fix the month stats

* Whitespace fixes

* Remove flotr2

* Rename to chart.min.js

* Remove console.log

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-10-16 12:00:07 +02:00
Alexandre Alapetite
ebf9c70ebd Automatic fix minor syntax previous commits 2021-10-14 13:59:31 +02:00
maTh
7f1e8ff507 fix #3652 "about" link in "reading view" (#3877)
* fix
* improve nav slider width in mobile view
2021-10-14 13:30:48 +02:00
maTh
93e73855ec Delete jQuery (#3847)
* delete jquery.min.js lib
2021-09-13 08:02:09 +02:00
maTh
8b80c4cc8f Settings: User queries - layout upgrade (#3827)
* draft

* deleted the out commeted code

* improved alert messages

* Update queries.phtml

* Theme base-theme/template.css

* fixed theme: Origin

* Fixed: Theme Adark

* Fixed: Theme Ansum

* Fix: Theme BlueLagoon

* Fix: Theme Dark

* Fix: Theme Flat

* Fix: Theme Mapco

* Fix: Theme Mapco (SCSS)

* Fix: Theme Origine-compact

* Fix: Theme Pafat

* Fix: Theme Screwdriver

* Fix: Theme Swage

* Lint CSS, RTL, and i18n

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-09-12 12:06:29 +02:00
maTh
9712e4d888 Headline structure improvement (#3830)
* header: h1 deleted - full logo included

* template: config - display

* WIP

* shortcut configs. added fieldset. do not display the border by default

* system.phtml

* subscription: add feed or category

* wip

* wip

* Update bookmarklet.phtml

* Update archiving.phtml

* Update queries.phtml

* Update profile.phtml

* Update manage.phtml

* auth+update

* Update template.rtl.css

* fixed FreshRSS logo (Theme: Mapco)

* Update mapco.rtl.css

* Update _layout.scss

* fixed FreshRSS logo (theme: Dark)

* fix: FreshRSS logo (Theme: BlueLagoon)

* fix: FreshRSS logo (Theme: Ansum)

* fixed: FreshRSS logo (Theme: Alternative Dark)

* fix: FreshRSS logo (Theme: Pafat)

* fix: FreshRSS logo (Theme: Screwdriver)

* fix: FreshRSS logo (theme: Swage)

* Minor lint

* little fix: FreshRSS logo (Theme: Origine)

* Fix: FreshRSS logo (Theme: Origine Compact)

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-09-11 18:22:26 +02:00
maTh
c80e081bb0 fixed: margin around <figure> (#3832)
* fix CSS

* Minor whitespace

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2021-09-08 21:09:39 +02:00