Commit Graph

7003 Commits

Author SHA1 Message Date
upskaling
1a0901bbd0 Add credit related to #2962 (#2965) 2020-05-11 16:08:21 +02:00
upskaling
bd8f6f19b6 add lazy loading on favicon (#2962) 2020-05-10 22:12:13 +02:00
Alexandre Alapetite
aea3806590 Attempt to reduce max memory usage during actualize (#2955)
* Attempt to reduce max memory usage during actualize

#Fix https://github.com/FreshRSS/FreshRSS/issues/2952

* Use memory_get_peak_usage
2020-05-10 21:34:12 +02:00
equinoxmatt
be10486f5e 2914 show last login date (#2936)
* Add new last_login param to default user config

* Add English translation strings for last login feature

* Update last_login when user successfully logs in.

* Add last_login column to manage users screen

* Add last_login to user details screen

* Remove accidental docker-compose.yml

* Fix whitespace

* Use last modified time for config file

* Remove last_login field from default user config

* Touch user configuration file upon succesful login

* Add translations with todos

* Fix whitespace

* Use last_user_activity

* Semi-colomn

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2020-05-09 12:49:49 +02:00
Alexandre Alapetite
17539668ea Fix bad relogging clients (#2961)
* Fix bad relogging clients

Some clients (like EasyRSS) are still using the old HTTP Authorization
header after having logged to log in with another user.
We should not attempt to process Authorization headers during a login
request

* Typo

* A bit safer

Avoid null exception
2020-05-08 21:54:45 +02:00
saimyx
a76caf78e7 documentation utilisateur / user doc (#2948)
* Update 04_Subscriptions.md

- ajouter un flux
- import/export

* Update 04_Subscriptions.md

* Update 04_Subscriptions.md

* Update 04_Subscriptions.md

Translated in english from https://github.com/Saimyx/FreshRSS/edit/master/docs/fr/users/04_Subscriptions.md

* Update 04_Subscriptions.md

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/fr/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update 04_Subscriptions.md

* Update docs/en/users/04_Subscriptions.md

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Update docs/en/users/04_Subscriptions.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>

* Language improvements

* Language improvements

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2020-05-08 16:04:22 +02:00
Alexandre Alapetite
0fc71fdf42 API relaxed detection of short/long item ID forms (#2957)
#Fix https://github.com/FreshRSS/FreshRSS/issues/2956
Bug/feature introduced by https://github.com/FreshRSS/FreshRSS/pull/2947 (which was following the specification better)

The original code `strpos($e_id, '/') !== null` was wrong (it can never be null, only false or integer), but the idea was to check whether the client was sending a short form (decimal) or long form of the ID (hexadecimal with prefixes including slashes). Since it has not given problem until my recent typo fix, this means that the short form is apparently not used by the clients we tested. But now that we are back to following the specification better, it looks like a client such as Reeder 4 is sending an hexadecimal form without a prefix, which breaks the detection.

This patch changes the detection, which should work in all known cases AND comply with the specification

https://feedhq.readthedocs.io/en/latest/api/terminology.html#items
2020-05-07 18:33:40 +02:00
pofilo
ee29ec0a73 Fix tty error on cron with docker (#2954)
* Fix tty error on cron with docker

* remove interactive option in cron command
2020-05-06 22:56:51 +02:00
Marien Fressinaud
cc7a784cbe Add/mobile feed configuration (#2938)
* Show subscription management button on mobile

* Show aside box-shadow on Origine only when opened

* Reduce padding of Origine posts on mobile

* Shrink stick component with long input

* Show Origine configure icons on mobile

* Show the slider full width on mobile

* Improve the look of forms on mobile

* Fix Ansum theme

* Fix BlueLagoon theme

* Fix Dark theme

* Fix Flat theme

* Fix Mapco theme

* Fix Origine-compact theme

* Fix Pafat theme

* Fix Screwdriver theme

* Fix Swage theme

* Fix Alternative-Dark theme

* Apply RTL script on themes

Co-authored-by: triatic <42704418+triatic@users.noreply.github.com>
2020-05-06 19:55:45 +02:00
Alexandre Alapetite
5e18ca8408 Fix warning with FeedReader (#2947)
FeedReader 2.10.0 sends something like
`T=cd3421a73e8a09f955449d02beaf9593b0c0265cZZZZZZZZZZZZZZZZZ&r=user/-/state/com.google/read&i=-/tag%3Agoogle.com&i=-/2005%3Areader/item/0005a4b97779db22`
to `/api/greader.php/reader/api/0/edit-tag`

The first `i=-/tag/google.com` is wrong and cannot be converted to an entry ID.
This resulted in:

> PHP Warning:  gmp_init(): Unable to convert variable to GMP - string is not an integer in /var/www/FreshRSS/p/api/greader.php on line 35
2020-05-05 17:13:18 +02:00
Alexandre Alapetite
b1aac20839 Fever integer type for numbers (#2946)
* Fever integer type for feed ID

#Fix
https://github.com/FreshRSS/FreshRSS/issues/2940#issuecomment-623022435

* Fix feed_id

* Ensure string for entry ID

To be compatible with 32-bit platforms.
Before, the type was inconsistent depending on architecture + database

* Integer for entry count functions
2020-05-03 13:39:16 +02:00
Alexandre Alapetite
83ba09c2a5 Fever integer type for last_refreshed_on_time 2 (#2945)
#Fix fever_last_refreshed_on_time
Try again https://github.com/FreshRSS/FreshRSS/pull/2944
2020-05-02 23:55:10 +02:00
Alexandre Alapetite
1bb4c75db7 Fever integer type for last_refreshed_on_time (#2944)
#Fix https://github.com/FreshRSS/FreshRSS/issues/2940
https://feedafever.com/api
2020-05-02 20:04:51 +02:00
Alexandre Alapetite
af575e061d Revert to Ubuntu 19.10 (#2943)
* Revert to Ubuntu 19.10

#Fix https://github.com/FreshRSS/FreshRSS/issues/2939
Revert https://github.com/FreshRSS/FreshRSS/pull/2925

Will upgrade back to 20.04 when Ubuntu bugs are fixed, e.g.
https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1867675

* Revert changelog
2020-05-02 18:24:13 +02:00
Marien Fressinaud
960ecd2d09 Always put checkbox labels on the right (#2937)
There were two checkboxes with labels set on the left: it was looking
weird and inconsistent with the rest of the application.

Also, since the Websub checkbox cannot be checked by the user (i.e. it
is entirely managed by the backend), I just hide the line when Websub is
disabled. It would be better to never show the checkbox and adapt the
label to say something like "Websub is enabled for this feed", but I
prefer to avoid changing all the locales.

Last point: an input should always have one and only one label. Websub
checkbox had two labels, which can be hardly supported by assistive
technologies.

Reference: https://developer.mozilla.org/en-US/docs/Learn/Forms/How_to_structure_a_web_form#Multiple_labels
2020-05-01 10:55:57 +02:00
Alexandre Alapetite
f0db70dcb0 API Use string type for Usec (#2935)
#Fix https://github.com/FreshRSS/FreshRSS/issues/2934
2020-04-30 23:17:46 +02:00
Marien Fressinaud
8f188ffa84 Fix filenames for files exported with CLI (#2932)
Filenames were created with the username of the current user. However,
when we export the files with the CLI, the current user is "_".

This commit makes the username always required in the `exportFile`
method so we make sure to always manipulate a real value. Consequently,
the filenames can be formatted correctly.

Obviously, this has absolutely no impacts since the CLI doesn't consider
the HTTP headers. It just makes things a bit more clear. It's a first
step to remove the concept of "default user".
2020-04-30 12:11:51 +02:00
Alexandre Alapetite
4ac868b301 Changelog 2020-04-25 13:30:11 +02:00
Alexandre Alapetite
0f7970b4c0 Docker: Ubuntu 20.04 (#2925)
https://ubuntu.com/blog/ubuntu-20-04-lts-arrives
PHP 7.4.3, Apache 2.4.41
https://php.net/migration74
We have already addressed PHP 7.4 issues in FreshRSS 1.16
2020-04-25 12:27:25 +02:00
Alexandre Alapetite
dba40e5870 WebSub move fixes (#2922)
Small fixes related to when WebSub changes address:
* When unsubscribing, one must use the current/old address, not the
newly found selfUrl;
* This change
https://github.com/FreshRSS/FreshRSS/pull/2659#discussion_r347263068 was
wrong, so reverted to the first version. We must obey the rules also for
feeds for which the initial WebSub enabling is not finished, otherwise
we never have a chance to redirect the feed to the proper selfUrl.
2020-04-24 16:29:19 +02:00
Frans de Jonge
5fbbc6ad58 Fix minor typo in Docker README (#2921) 2020-04-21 21:17:29 +02:00
Twilek-de
bb3c35401c #2671 Apache reverse proxy (#2919)
* #2671 Apache reverse proxy

Adding sample configuration for using apache as a reverse proxy

* Update Docker/README.md

Better wording

Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>

* Update Docker/README.md

Better wording

Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>

* Included suggestions and cleaned up code

I have cleaned the code with the <location> Tags so that it is more concise

* Included corrections

* Update Docker/README.md

Minor port number

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2020-04-21 20:11:34 +02:00
Kristian Salonen
e2c8e73c2c Add credit related to #2912 (#2920) 2020-04-21 18:31:24 +02:00
Julien-Pierre Avérous
acca89505b Enhance the way help elements are displayed (#2911)
* - Always display help under the targeted element.
- Use same help place for HTTP authentication in 'add' feed view than in 'update' feed view.
- Move help under input field in register view, as all other places (homogeneity).

* - Don't use "!important" as suggested by @Alkarex.
2020-04-20 23:27:17 +02:00
Kristian Salonen
bd9a72726d Fix for "Flash Of Unstyled Content" and slow loading in the Firefox (#2913) 2020-04-20 23:20:34 +02:00
Marien Fressinaud
582a0041a9 Don't check email if feature disabled or for admin (#2917) 2020-04-20 17:48:41 +02:00
Andrew Hunter
f8db9ddd85 Turn off autocaptialization on the username field to improve mobile UX. (#2907)
* Turn off autocapitalization on the username field to improve mobile UX.

Fixes issue #2384

* Update app/views/auth/formLogin.phtml

Co-Authored-By: Alexandre Alapetite <alexandre@alapetite.fr>

* Update app/views/auth/register.phtml

Co-Authored-By: Alexandre Alapetite <alexandre@alapetite.fr>
2020-04-18 23:38:32 +02:00
Alexandre Alapetite
e9213e89f4 Fix CSS Edge glitch in archiving options (#2906)
With Edge, only setting `.hidden = true` does not make the element and
sub-elements properly visible.
Should not make any difference for other browser.
2020-04-18 11:50:35 +02:00
Alexandre Alapetite
ae70374b03 Filter by multiple feed IDs (#2892)
Add the possibility to filter by feed ID like `f:123 more-search`
or multiple feed IDs, like `f:123,234,345 more-search` or an exclusion
like `!f:456,789 more-search`
2020-04-17 10:57:35 +02:00
Alexandre Alapetite
a49db010e4 A wrong login must return HTTP 403 (#2903)
* A wrong login must produce HTTP 403

#fix https://github.com/FreshRSS/FreshRSS/issues/2901
https://github.com/FreshRSS/FreshRSS/pull/2794/files#r389319248

* Just for consistency
2020-04-17 10:56:06 +02:00
Alexandre Alapetite
bdc4da6ad0 Expose podcast in API (#2898)
* Expose podcast in API

Expose RSS enclosures in our API, e.g. for clients supporting podcasts

* PHP CS?

* Annoying linter

* Light optimisation
2020-04-16 18:11:26 +02:00
Alexandre Alapetite
5ddae68953 Option to control which categories to unfold (#2888)
#fix https://github.com/FreshRSS/FreshRSS/issues/2324
2020-04-16 18:09:54 +02:00
Alexandre Alapetite
475feffdbe Markdownlint (#2880)
* markdownlint

I have started to use
[markdownlint](https://github.com/DavidAnson/markdownlint/) to find
typos in Markdown. Let's discuss which rules to enforce / disable /
customize

* markdownlint cli/readme
2020-04-16 18:08:53 +02:00
Alexandre Alapetite
946d9f5535 Reduce DB locks (#2899)
Do not lock the DB to update it when there is nothing to commit.
This should reduce the risk of seeing some `database is locked` errors.
2020-04-14 00:09:13 +02:00
Alexandre Alapetite
f2e0f051aa Fix JS for statistics repartition select form (#2896)
* Fix JS for statistics repartition select form

Error was: `s.form is null in extra.js:166:7`
At the same time, disable the form and clears the value while waiting
for the next page to load, to better understand what is happening.

* Whitespace
2020-04-12 16:40:06 +02:00
Alexandre Alapetite
82278af7a9 Fix double HTML-encoding in category names (#2897)
Category names are already HTML-encoded when reaching the view.
2020-04-12 16:36:45 +02:00
Alexandre Alapetite
14fa3f2781 jQuery 3.5.0 (#2895)
https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/
2020-04-12 11:37:50 +02:00
yzqzss
8a83f7a856 Add files via upload (#2894) 2020-04-12 11:32:47 +02:00
Troy Engel
1401186a48 pause automatic updates during upgrade (#2893) 2020-04-11 17:47:08 +02:00
yzqzss
d1fdfbf987 Update Chinese Translation (#2891)
* Update admin.php

* Update conf.php

* Update feedback.php

已重置

* Update gen.php

* Update sub.php

* Update user.php

* Update user.php
2020-04-11 15:22:02 +02:00
kinoushe
8f71b80fbb Update CREDITS.md (#2890) 2020-04-11 00:36:43 +02:00
Frans de Jonge
04e5f5b2e4 Minor stylelint exception formatting change (#2889)
Slightly tidier
2020-04-10 18:51:59 +02:00
kinoushe
da67489df2 Fix search input styling in Safari (#2887)
* Fix search input styling in Safari
#fix https://github.com/FreshRSS/FreshRSS/issues/2885

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2020-04-10 14:22:02 +02:00
Alexandre Alapetite
f29b63df3b gitattributes (#2879)
https://www.git-scm.com/docs/gitattributes
Disable automatic end-of-line conversion from Unix to Windows.
We do not have any file type in the project that is sensitive to line
ending (e.g. PHP works fine on Windows with Linux line endings), but the
automatic conversion makes it annoying to work on the same git local
repository from different systems (e.g. hybrid Linux / Windows
development)
2020-04-09 14:03:47 +02:00
Alexandre Alapetite
de882dad43 Start 1.16.1-dev 2020-04-09 14:03:12 +02:00
Alexandre Alapetite
1821266035 Release 1.16.0
https://github.com/FreshRSS/FreshRSS/issues/2871
1.16.0
2020-04-09 12:30:16 +02:00
Alexandre Alapetite
847ad278a4 Fix BlueLagoon and Screwdriver hover title (#2884)
#fix https://github.com/FreshRSS/FreshRSS/issues/2755
Follow-up of
https://github.com/FreshRSS/FreshRSS/pull/2882#issuecomment-611136775

https://stackoverflow.com/questions/2837057/what-has-bigger-priority-opacity-or-z-index-in-browsers
2020-04-09 00:25:08 +02:00
Alexandre Alapetite
e00580cc36 Changelog 2020-04-08 20:59:01 +02:00
Alexandre Alapetite
f9e92a9286 Fix CSS hover long title (#2882)
* Fix CSS hover long title

#fix https://github.com/FreshRSS/FreshRSS/issues/2755

* Fix Ansum

* Fix Mapco
2020-04-08 20:52:15 +02:00
Alexandre Alapetite
0d235cbadd Swap shortcuts for mark all articles as read / mark previous articles as read (#2881)
* Swap shortcuts for mark all articles as read / mark previous articles as read

#fix https://github.com/FreshRSS/FreshRSS/issues/2865
Follow-up of https://github.com/FreshRSS/FreshRSS/pull/2843
* <kbd>⇧ Shift</kbd>+<kbd>R</kbd> to mark all articles as read;
* <kbd>Alt ⎇</kbd>+<kbd>r</kbd> to mark previous articles as read.

* i18n
2020-04-08 13:17:20 +02:00