Commit Graph

80 Commits

Author SHA1 Message Date
Alexandre Alapetite
6881d362b1 Detection of non-unique GUIDs (#1887)
* Detection of non-unique GUIDs

Some feeds are using GUIDs, but fail to make them unique.
Example: https://www.kbh-sprogcenter.dk/en/category/danish-break/feed/
This patch detects non-unique GUIDs, and disable GUIDs in that specific
case.

* Add state and log
2018-05-20 12:17:08 +02:00
ColonelMoutarde
a8ffde6263 add visibility "public" (#1849) 2018-05-19 13:16:51 +02:00
Alexandre Alapetite
b552abb332 JSON column for feeds (#1838)
* Draft of JSON column for feeds
https://github.com/FreshRSS/FreshRSS/issues/1654

* Add some per-feed options
  * Feed cURL timeout
  * Mark updated articles as read https://github.com/FreshRSS/FreshRSS/issues/891
  * Mark as read upon reception https://github.com/FreshRSS/FreshRSS/issues/1702
  * Ignore SSL (unsafe) https://github.com/FreshRSS/FreshRSS/issues/1811

* Try PHPCS workaround
While waiting for a better syntax support
2018-05-01 17:02:11 +02:00
perrinjerome
0c066cb428 Feed parsing: use author email when there's no author name (#1801)
This is especially useful because when author is given as
`<author>Author Name</author>` ( as in this example
https://cyber.harvard.edu/rss/rss.html#ltauthorgtSubelementOfLtitemgt ),
SimplePie will expose *Author Name* as `email`.
2018-02-28 20:08:32 +01:00
Alexis Degrugillier
7642d334f8 Replace "keep history" magic value by a constant (#1759)
I think the use of a magic value repeated many times in the code is prone to have some errors made by people not knowing its meaning. Using a constant is a bit more safe. Judging by some comments in the code, I am not the only one.
2018-01-02 23:53:35 +01:00
Alexis Degrugillier
8c2113f9e6 Add mute strategy configuration (#1750) 2018-01-01 20:34:06 +01:00
Alexandre Alapetite
e399bc4b92 Remove warning for CURLOPT_FOLLOWLOCATION with open_basedir (#1734)
For PHP 5.6.0- http://www.php.net/ChangeLog-5.php#5.6.0
https://bugs.php.net/bug.php?id=65646
https://github.com/FreshRSS/FreshRSS/pull/1733
https://github.com/FreshRSS/FreshRSS/pull/1657
https://github.com/FreshRSS/FreshRSS/issues/1655
2017-12-17 20:14:20 +01:00
Alexandre Alapetite
b1c317a253 Log rotation, use Minz_Log, new log constants
ADMIN_LOG, API_LOG, PSHB_LOG
2017-12-10 21:58:24 +01:00
Alexandre Alapetite
1eb19409b5 CURLOPT_FOLLOWLOCATION open_basedir bug (#1657)
CURLOPT_FOLLOWLOCATION cannot be activated when an open_basedir is set
https://github.com/FreshRSS/FreshRSS/issues/1655#issuecomment-334999448
https://stackoverflow.com/questions/6918623/curlopt-followlocation-cannot-be-activated
2017-10-08 17:26:43 +02:00
Alexandre Alapetite
4058ff3ff4 Remove SimplePie name from HTTP User-Agent string
https://github.com/FreshRSS/FreshRSS/issues/1622#issuecomment-334928486
https://github.com/FreshRSS/FreshRSS/issues/1627
https://github.com/FreshRSS/FreshRSS/issues/1607
2017-10-07 13:51:45 +02:00
Alexandre Alapetite
62d68f8c66 Quick fix PSHB encoding after Travis refactoring
https://github.com/FreshRSS/FreshRSS/pull/1619
Related to https://github.com/FreshRSS/FreshRSS/pull/1633
2017-09-24 12:16:41 +02:00
Alexandre Alapetite
2e8d8834c4 Quick fix small bug from 1619 (#1633)
https://github.com/FreshRSS/FreshRSS/pull/1619
2017-09-22 13:05:42 +02:00
Frans de Jonge
4e174ed9dd [ci] Add Travis (#1619)
* [ci] Add Travis

* Exclude some libs

* Semi-auto whitespace fixes

* line length in SQLite

* Exclude tests from line length

* Feed.php line length

* Feed.php: get rid of unnecessary concat

* Feed.php: line length

* bootstrap.php: no newline at end of file

* Allow concatenating across multiple lines

* Add Travis badge

* do-install line length

* update-or-create-user line length

* cli/create-user line length

* tests/app/Models/SearchTest.php fix indentation

* tests/app/Models/UserQueryTest.php fix indentation

* tests/app/Models/CategoryTest.php fix indentation

* [fix] PHP 5.3 on precise

* cli/do-install no spaces

* cli/list-users line length

* cli/reconfigure line length

* empty catch statements

* api/index line length nonsense

* spaces before semicolon

* app/Models/EntryDAO bunch of indentation

* extra blank lines

* spaces before comma in function call

* testing tabwidth

* increase to 10

* comment out tabwidth line

* try older phpcs version 3.0.0RC4

* line length exception for app/install.php

* proper spaces

* stray spaces in i18n

* Minz/ModelPdo line length

* Minz whitespace

* greader line length

* greader elseif placement

* app/Models/Feed.php spacing in function argument

* ignore php 5.3

* app/Models/ConfigurationSetter.php stray whitespace

* EntryDAOSQLite line length

* I vote for higher max line length =P

* ignore SQL

* remove classname complaint

* line length/more legible SQL

* ignore line length nonsense

* greader line length

* feedController issues

* uppercase TRUE, FALSE, NULL

* revert

* importExportController lowercase null

* Share.php default value not necessary because ! is_array () a few lines down

* CategoryDAO constants should be UPPERCASE

* EntryDAO reduce line length

* contentious autofix

* Allow failures on all versions of PHP except 7.1 because reasons
2017-09-22 12:13:46 +02:00
Alexandre Alapetite
18285d2729 Author HTML to text
https://github.com/FreshRSS/FreshRSS/issues/1590#issuecomment-313914174
https://github.com/FreshRSS/FreshRSS/pull/1592#issuecomment-320290049
2017-08-19 13:48:47 +02:00
Alexandre Alapetite
97fe573ace SimplePie: Do not generate hash instead of GUID
https://github.com/FreshRSS/FreshRSS/issues/1552
2017-05-28 02:02:58 +02:00
Alexandre Alapetite
77e698617d Fix download regression
https://github.com/FreshRSS/FreshRSS/issues/1236#issuecomment-299732610
2017-05-07 22:38:29 +02:00
Alexandre Alapetite
e9e6fc3483 Download icon 💾 for other MIME types
https://github.com/FreshRSS/FreshRSS/issues/1236#issuecomment-299627105
2017-05-07 17:00:46 +02:00
Alexandre Alapetite
535aa35ba7 PSHB better unsubscribe
Cases when a user is deleted, or when a feed is deleted.
Removed random key do reduce the risk of subscribing several times to
the same PSHB feed.
2017-04-10 19:09:21 +02:00
Alexandre Alapetite
271a1fdc89 Missing checkUsername and const patten
https://github.com/FreshRSS/FreshRSS/pull/1423

https://github.com/YunoHost-Apps/freshrss_ynh/issues/27#issuecomment-279792363
2017-02-25 12:39:08 +01:00
Alexandre Alapetite
e1f214e9e2 CLI list-users and create-user
https://github.com/FreshRSS/FreshRSS/issues/1095
https://github.com/FreshRSS/FreshRSS/issues/1090
2016-10-22 12:58:06 +02:00
Alexandre Alapetite
8a923aa8c7 Finalize cron refresh favicons 2016-10-12 21:36:00 +02:00
Alexandre Alapetite
e8d1a6dcc9 Cron refresh favicons
Related to
https://github.com/FreshRSS/FreshRSS/issues/1181
https://github.com/FreshRSS/FreshRSS/issues/1298
2016-10-12 15:47:04 +02:00
Alexandre Alapetite
6bc37cef47 W3C resource-priorities have been abandonned
https://github.com/FreshRSS/FreshRSS/issues/1222
2016-10-08 21:45:47 +02:00
Alexandre Alapetite
05cabe99ae Take better advantage of other users refresh 2016-10-05 00:39:54 +02:00
Alexandre Alapetite
85c8fba94f API add feed bug with PSHB 2016-09-25 00:34:49 +02:00
Alexandre Alapetite
324c83348c Refactor controller add feed 2016-09-24 23:29:49 +02:00
Alexandre Alapetite
abdf85094d Change style for podcast download
https://github.com/FreshRSS/FreshRSS/issues/1236
2016-09-04 17:05:10 +02:00
Alexandre Alapetite
f14cb04e8b 💾 in paragraph 2016-09-03 21:58:53 +02:00
Alexandre Alapetite
3b2b91e1f2 Download icon 💾 for podcasts
https://github.com/FreshRSS/FreshRSS/issues/1236
2016-09-03 21:46:43 +02:00
Alexandre Alapetite
ccecebc2b4 SimplePie error message XML PCRE
https://github.com/FreshRSS/FreshRSS/issues/1227
2016-08-28 16:35:54 +02:00
Alexandre Alapetite
1a0f11ee38 PSHB base_url bug
https://github.com/FreshRSS/FreshRSS/issues/1227
Bug if base_url does not end with /
2016-08-28 13:57:18 +02:00
Alexandre Alapetite
0915772fe6 PubSubHubbub unsubscribe request
https://github.com/FreshRSS/FreshRSS/issues/1058
2016-01-24 11:06:20 +01:00
Alexandre Alapetite
9e43937f8c PubSubHubbub prevent subscribing too often in case of error
https://github.com/FreshRSS/FreshRSS/issues/939
2015-08-04 12:36:00 +02:00
Alexandre Alapetite
694dfa1f8b PubSubHubbub: remove white list
The tests so far are good. Ready to test more broadly.
https://github.com/FreshRSS/FreshRSS/pull/831
https://github.com/FreshRSS/FreshRSS/issues/312
2015-05-23 16:37:08 +02:00
Alexandre Alapetite
001c713f03 PubSubHubbub better gestion of errors
Do not assume that PubSubHubbub works until the first successul push
https://github.com/FreshRSS/FreshRSS/issues/312#issuecomment-102706500
2015-05-17 22:06:11 +02:00
Alexandre Alapetite
3adab4b70f More PubSubHubbub
https://github.com/FreshRSS/FreshRSS/issues/312
Show whether PubSubHubbub is enabled in the Web interface of feed
configuration.
When PubSubHubbub is used, do not pull refresh so often (hard-coded to
max once per 24h for now).
Improved logic for lease renewal, and some detection of lease problems.
Updated read-me and changelog.
2015-05-16 13:05:43 +02:00
Alexandre Alapetite
0163564b9e Change some error messages 2015-05-15 17:58:56 +02:00
Alexandre Alapetite
c472569b38 First alpha of PubSubHubbub
https://github.com/FreshRSS/FreshRSS/issues/312
Using a white list limited to http://push-pub.appspot.com/feed for alpha
testing.
2015-05-15 15:34:51 +02:00
Alexandre Alapetite
256c8613a4 First draft of PubSubHubbub
https://github.com/FreshRSS/FreshRSS/issues/312
Requires setting base_url in config.php.
Currently using the filesystem (no change to the database)
2015-05-15 03:21:36 +02:00
Alexandre Alapetite
f3aef1e59b Merge branch 'Alkarex/Logging'
https://github.com/FreshRSS/FreshRSS/pull/815
2015-05-10 00:14:41 +02:00
Alexandre Alapetite
9934668444 SQL: more robust purge
https://github.com/FreshRSS/FreshRSS/issues/798
https://github.com/FreshRSS/FreshRSS/issues/493
2015-05-09 23:37:56 +02:00
Alexandre Alapetite
711530a512 SQL: detection of updates, and preparation for better burge
https://github.com/FreshRSS/FreshRSS/issues/798
https://github.com/FreshRSS/FreshRSS/issues/493
SQLite not yet tested. Only MySQL tested so far.
2015-04-04 22:39:31 +02:00
Alexandre Alapetite
ad9fe52f5a SimplePie sanitize URLs for syslog
https://github.com/FreshRSS/FreshRSS/issues/711
https://github.com/FreshRSS/FreshRSS/pull/715
2015-03-22 22:54:29 +01:00
Alexandre Alapetite
1a35e2271d SimplePie option to restaure syslog of HTTP requests
https://github.com/FreshRSS/FreshRSS/issues/711
2015-03-21 18:20:36 +01:00
Marien Fressinaud
8ff3e5363d Use url_remove_credentials to log URL
See https://github.com/FreshRSS/FreshRSS/issues/711
2015-01-29 10:57:11 +01:00
Marien Fressinaud
59ea9f2a3b Remove calls to syslog()
Temporary fix:

- Change syslog by Minz_Log::notice in most of the files
- Logs are stored in USERS_PATH/_/log.txt for actualize_script.php
- Simply comment syslog in SimplePie

See https://github.com/FreshRSS/FreshRSS/issues/711
2015-01-29 10:14:45 +01:00
Marien Fressinaud
d3a93ea290 BREAKING FEATURE: Remove general in config
General attribute has been removed from system config.
Now subattributes (e.g. environment, salt, title, etc.) are directly accessible.

YOU HAVE TO FIX YOUR ./data/config.php file!

- Remove the general array
- Values inside this array must be kept
- To see what it must look like, please have a look to ./data/config.default.php
  (but keep your values!!).

See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-06 18:53:36 +01:00
Marien Fressinaud
51a71ec4b9 New configuration system (not working yet)
- Use only Minz_Configuration
- register() method to load a new configuration file
- get() to get a configuration
- new exceptions related to configuration
- fix a list configuration calls to have FRSS working

Current problems to resolve:

- How to handle configuration param verifications (i.e. check auth_type
  is a value from none, http_auth, persona or form)
- We must use $conf = Minz_Configuration::get('system'); $general_conf = $conf->general;
  to access global system configuration which is quite annoying. How to change that?

See https://github.com/FreshRSS/FreshRSS/issues/730
2015-01-05 16:54:16 +01:00
Alexandre Alapetite
764946814f force_feed option
By adding #force_feed at the end of the URL of a feed sent with a wrong
content-type (mime)
https://github.com/FreshRSS/FreshRSS/issues/456
2014-11-12 23:28:47 +01:00
Alexandre Alapetite
00127f07c5 SimplePie: cache feeds with errors
Before the cache system was not used for feeds with errors, which was
problematic especially if several users have this feed.
Furthermore, there was no protection against repetitive refresh.

Bonus: slightly better performance by avoiding some superfluous
file_exists().

Warning: needs a bit of testing
https://github.com/marienfressinaud/FreshRSS/issues/681
2014-10-28 23:52:46 +01:00