Files
Ali GündoğarandAlexandre Alapetite a9a5856d0d PostgreSQL: make commitNewEntries resilient to duplicate keys (#9231)
* PostgreSQL: make commitNewEntries resilient to duplicate keys

Use ON CONFLICT DO NOTHING

References #1610 #1614

* Minimize diff

* Minimize diff 2

---------

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2026-08-26 12:20:16 +02:00

114 lines
3.4 KiB
PHP

<?php
declare(strict_types=1);
class FreshRSS_EntryDAOPGSQL extends FreshRSS_EntryDAOSQLite {
#[\Override]
public static function hasNativeHex(): bool {
return true;
}
#[\Override]
public static function sqlHexDecode(string $x): string {
return 'decode(' . $x . ", 'hex')";
}
#[\Override]
public static function sqlHexEncode(string $x): string {
return 'encode(' . $x . ", 'hex')";
}
#[\Override]
public static function sqlIgnoreConflict(string $sql): string {
return rtrim($sql, ' ;') . ' ON CONFLICT DO NOTHING';
}
#[\Override]
protected static function sqlLimitAll(): string {
// https://www.postgresql.org/docs/current/queries-limit.html
return 'ALL';
}
#[\Override]
public static function sqlRandom(): string {
return 'RANDOM()';
}
#[\Override]
protected static function sqlRegex(string $expression, string $regex, array &$values): string {
$matches = static::regexToSql($regex);
if (isset($matches['pattern'])) {
$replacements = [ // Convert some of the PCRE regex syntax to PostgreSQL
'\\b' => '\\y', // matches only at the beginning or end of a word (was: backspace)
'\\B' => '\\Y', // matches only at a point that is not the beginning or end of a word (was: backslash)
];
$matches['pattern'] = str_replace(array_keys($replacements), array_values($replacements), $matches['pattern']);
$matchType = $matches['matchType'] ?? '';
if (str_contains($matchType, 'm')) {
// newline-sensitive matching
$matches['pattern'] = '(?m)' . $matches['pattern'];
}
$values[] = $matches['pattern'];
if (str_contains($matchType, 'i')) {
// case-insensitive matching
return "{$expression} ~* ?";
} else {
// case-sensitive matching
return "{$expression} ~ ?";
}
}
return '';
}
#[\Override]
protected function registerSqlFunctions(string $sql): void {
// Nothing to do for PostgreSQL
}
/** @param array{0:string,1:int,2:string} $errorInfo */
#[\Override]
protected function autoUpdateDb(array $errorInfo): bool {
if (isset($errorInfo[0])) {
if ($errorInfo[0] === FreshRSS_DatabaseDAO::ER_BAD_FIELD_ERROR || $errorInfo[0] === FreshRSS_DatabaseDAOPGSQL::UNDEFINED_COLUMN) {
$errorLines = explode("\n", $errorInfo[2], 2); // The relevant column name is on the first line, other lines are noise
foreach (['attributes', 'lastUserModified', 'lastModified'] as $column) {
if (str_contains($errorLines[0], $column)) {
return $this->addColumn($column);
}
}
}
}
return false;
}
#[\Override]
public function commitNewEntries(): bool {
$sql = <<<'SQL'
DO $$
DECLARE
maxrank bigint := (SELECT MAX(id) FROM `_entrytmp`);
rank bigint := (SELECT maxrank - COUNT(*) FROM `_entrytmp`);
BEGIN
INSERT INTO `_entry`
(id, guid, title, author, content, link, date, `lastSeen`, hash, is_read, is_favorite, id_feed, tags, attributes)
(SELECT rank + row_number() OVER(ORDER BY etmp.date, etmp.id) AS id, guid, title, author, content,
link, date, `lastSeen`, hash, is_read, is_favorite, id_feed, tags, attributes
FROM `_entrytmp` AS etmp
ORDER BY etmp.date, etmp.id)
ON CONFLICT DO NOTHING;
DELETE FROM `_entrytmp` WHERE id <= maxrank;
END $$;
SQL;
$hadTransaction = $this->pdo->inTransaction();
if (!$hadTransaction) {
$this->pdo->beginTransaction();
}
$result = $this->pdo->exec($sql) !== false;
if (!$hadTransaction) {
$this->pdo->commit();
}
return $result;
}
}