mirror of
https://github.com/FreshRSS/FreshRSS.git
synced 2026-04-16 12:27:20 -04:00
* prefer feed.icon Closes #5518 Changes proposed in this pull request: - When a feed provides an icon URL (<image><url> in RSS 2.0/1.0, <atom:icon>/<atom:logo> in Atom, icon/favicon fields in JSON Feed), that URL is stored as a feedIconUrl attribute on the feed and used as the primary source for favicon downloads, instead of scraping the feed's website for <link rel="icon"> tags. - If the feed-provided icon URL fails to return a valid image, the existing fallback chain (website HTML favicon search → /favicon.ico) is preserved. Custom favicons uploaded by users always take priority and are never overridden. How to test the feature manually: 1. Add an RSS feed that includes a <image><url> element (e.g. an RSSHub feed: `https://rsshub.app/youtube/channel/UC2cRwTuSWxxEtrRnT4lrlQA`). After actualization, confirm the feed's favicon matches the avatar image from the feed, not the Bilibili site favicon. 2. Add an Atom feed containing <atom:icon> or <atom:logo> Confirm the feed icon is used. 3. Add a JSON Feed (spec: icon field). Confirm icon is preferred over favicon when both are present. 4. Temporarily point a feed's <image><url> to a broken URL. Confirm FreshRSS falls back to the website favicon silently. 5. Upload a custom favicon for a feed, then actualize it. Confirm the custom favicon is not replaced. <img width="470" height="317" alt="image" src="https://github.com/user-attachments/assets/17445154-d94c-44d6-b7e7-019bf24c5767" /> * fix(favicon): use htmlspecialchars_decode for feed image URL * Decode quotes as well * New function in our SimplePie fork https://github.com/FreshRSS/simplepie/pull/73 --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
134 lines
4.0 KiB
PHP
134 lines
4.0 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
const FAVICONS_DIR = DATA_PATH . '/favicons/';
|
|
const DEFAULT_FAVICON = PUBLIC_PATH . '/themes/icons/default_favicon.ico';
|
|
|
|
function isImgMime(string $content): bool {
|
|
//Based on https://github.com/ArthurHoaro/favicon/blob/3a4f93da9bb24915b21771eb7873a21bde26f5d1/src/Favicon/Favicon.php#L311-L319
|
|
if ($content == '') {
|
|
return false;
|
|
}
|
|
if (!extension_loaded('fileinfo')) {
|
|
return true;
|
|
}
|
|
$fInfo = finfo_open(FILEINFO_MIME_TYPE);
|
|
if ($fInfo === false) {
|
|
return true;
|
|
}
|
|
$content = finfo_buffer($fInfo, $content);
|
|
$isImage = str_contains($content ?: '', 'image');
|
|
return $isImage;
|
|
}
|
|
|
|
function faviconCachePath(string $url): string {
|
|
return CACHE_PATH . '/' . sha1($url) . '.ico';
|
|
}
|
|
|
|
function searchFavicon(string $url): string {
|
|
$url = trim($url);
|
|
if ($url === '') {
|
|
return '';
|
|
}
|
|
$dom = new DOMDocument();
|
|
['body' => $html, 'effective_url' => $effective_url, 'fail' => $fail] =
|
|
FreshRSS_http_Util::httpGet($url, cachePath: CACHE_PATH . '/' . sha1($url) . '.html', type: 'html');
|
|
if ($fail || $html === '' || !@$dom->loadHTML($html, LIBXML_NONET | LIBXML_NOERROR | LIBXML_NOWARNING)) {
|
|
return '';
|
|
}
|
|
|
|
$xpath = new DOMXPath($dom);
|
|
$links = $xpath->query('//link[@href][translate(@rel, "ABCDEFGHIJKLMNOPQRSTUVWXYZ", "abcdefghijklmnopqrstuvwxyz")="shortcut icon"'
|
|
. ' or translate(@rel, "ABCDEFGHIJKLMNOPQRSTUVWXYZ", "abcdefghijklmnopqrstuvwxyz")="icon"]');
|
|
if (!($links instanceof DOMNodeList)) {
|
|
return '';
|
|
}
|
|
|
|
// Use the base element for relative paths, if there is one
|
|
$baseElements = $xpath->query('//base[@href]');
|
|
$baseElement = ($baseElements !== false && $baseElements->length > 0) ? $baseElements->item(0) : null;
|
|
$baseUrl = ($baseElement instanceof DOMElement) ? $baseElement->getAttribute('href') : $effective_url;
|
|
|
|
foreach ($links as $link) {
|
|
if (!$link instanceof DOMElement) {
|
|
continue;
|
|
}
|
|
$href = trim($link->getAttribute('href'));
|
|
$urlParts = parse_url($effective_url);
|
|
|
|
// Handle protocol-relative URLs by adding the current URL's scheme
|
|
if (substr($href, 0, 2) === '//') {
|
|
$href = ($urlParts['scheme'] ?? 'https') . ':' . $href;
|
|
}
|
|
|
|
$href = \SimplePie\IRI::absolutize($baseUrl, $href);
|
|
if ($href == false) {
|
|
return '';
|
|
}
|
|
|
|
$iri = $href->get_iri();
|
|
if ($iri == false) {
|
|
return '';
|
|
}
|
|
$favicon = FreshRSS_http_Util::httpGet($iri, faviconCachePath($iri), 'ico', curl_options: [
|
|
CURLOPT_REFERER => $effective_url,
|
|
])['body'];
|
|
if (isImgMime($favicon)) {
|
|
return $favicon;
|
|
}
|
|
}
|
|
return '';
|
|
}
|
|
|
|
/**
|
|
* Downloads a favicon directly from a known image URL (e.g. from a feed's <image><url> or icon field).
|
|
* Returns false without any fallback if the URL does not point to a valid image.
|
|
*/
|
|
function download_favicon_from_image_url(string $imageUrl, string $dest): bool {
|
|
$imageUrl = trim($imageUrl);
|
|
if ($imageUrl === '') {
|
|
return false;
|
|
}
|
|
$favicon = FreshRSS_http_Util::httpGet($imageUrl, faviconCachePath($imageUrl), 'ico')['body'];
|
|
if (!isImgMime($favicon)) {
|
|
return false;
|
|
}
|
|
return file_put_contents($dest, $favicon) > 0;
|
|
}
|
|
|
|
function download_favicon(string $url, string $dest): bool {
|
|
$url = trim($url);
|
|
$favicon = searchFavicon($url);
|
|
if ($favicon == '') {
|
|
$rootUrl = preg_replace('%^(https?://[^/]+).*$%i', '$1/', $url) ?? $url;
|
|
if ($rootUrl != $url) {
|
|
$url = $rootUrl;
|
|
$favicon = searchFavicon($url);
|
|
}
|
|
if ($favicon == '') {
|
|
$link = $rootUrl . 'favicon.ico';
|
|
$favicon = FreshRSS_http_Util::httpGet($link, faviconCachePath($link), 'ico', curl_options: [
|
|
CURLOPT_REFERER => $url,
|
|
])['body'];
|
|
if (!isImgMime($favicon)) {
|
|
$favicon = '';
|
|
}
|
|
}
|
|
}
|
|
return ($favicon != '' && file_put_contents($dest, $favicon) > 0) ||
|
|
@copy(DEFAULT_FAVICON, $dest);
|
|
}
|
|
|
|
function contentType(string $ico): string {
|
|
$ico_content_type = 'image/x-icon';
|
|
if (function_exists('mime_content_type')) {
|
|
$ico_content_type = mime_content_type($ico) ?: $ico_content_type;
|
|
}
|
|
switch ($ico_content_type) {
|
|
case 'image/svg':
|
|
$ico_content_type = 'image/svg+xml';
|
|
break;
|
|
}
|
|
return $ico_content_type;
|
|
}
|