Files
IronFox/patches/enable-secret-settings.patch

191 lines
8.8 KiB
Diff

diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt
index 7f435ae784..1e4013c699 100644
--- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt
+++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt
@@ -18,7 +18,7 @@ object FeatureFlags {
* This feature does not only depend on this flag. It requires the AMO collection override to
* be enabled which is behind the Secret Settings.
* */
- val customExtensionCollectionFeature = Config.channel.isNightlyOrDebug || Config.channel.isBeta
+ val customExtensionCollectionFeature = true
/**
* Pull-to-refresh allows you to pull the web content down far enough to have the page to
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SecretSettingsFragment.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SecretSettingsFragment.kt
index aafe4dbe47..29a4401c65 100644
--- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SecretSettingsFragment.kt
+++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SecretSettingsFragment.kt
@@ -62,13 +62,13 @@ class SecretSettingsFragment : PreferenceFragmentCompat() {
}
requirePreference<SwitchPreference>(R.string.pref_key_toolbar_show_navigation_toolbar).apply {
- isVisible = Config.channel.isNightlyOrDebug
+ isVisible = true
isChecked = context.settings().navigationToolbarEnabled
onPreferenceChangeListener = SharedPreferenceUpdater()
}
requirePreference<SwitchPreference>(R.string.pref_key_enable_compose_top_sites).apply {
- isVisible = Config.channel.isNightlyOrDebug
+ isVisible = true
isChecked = context.settings().enableComposeTopSites
onPreferenceChangeListener = SharedPreferenceUpdater()
}
@@ -80,29 +80,31 @@ class SecretSettingsFragment : PreferenceFragmentCompat() {
}
requirePreference<SwitchPreference>(R.string.pref_key_enable_compose_logins).apply {
+ isVisible = true
isChecked = context.settings().enableComposeLogins
onPreferenceChangeListener = SharedPreferenceUpdater()
}
requirePreference<SwitchPreference>(R.string.pref_key_enable_compose_homepage).apply {
+ isVisible = true
isChecked = context.settings().enableComposeHomepage
onPreferenceChangeListener = SharedPreferenceUpdater()
}
requirePreference<SwitchPreference>(R.string.pref_key_enable_menu_redesign).apply {
- isVisible = Config.channel.isNightlyOrDebug
+ isVisible = true
isChecked = context.settings().enableMenuRedesign
onPreferenceChangeListener = SharedPreferenceUpdater()
}
requirePreference<SwitchPreference>(R.string.pref_key_enable_homepage_searchbar).apply {
- isVisible = Config.channel.isNightlyOrDebug
+ isVisible = true
isChecked = context.settings().enableHomepageSearchBar
onPreferenceChangeListener = SharedPreferenceUpdater()
}
requirePreference<SwitchPreference>(R.string.pref_key_enable_homepage_as_new_tab).apply {
- isVisible = Config.channel.isNightlyOrDebug
+ isVisible = true
isChecked = context.settings().enableHomepageAsNewTab
onPreferenceChangeListener = SharedPreferenceUpdater()
}
@@ -128,7 +130,7 @@ class SecretSettingsFragment : PreferenceFragmentCompat() {
}
requirePreference<SwitchPreference>(R.string.pref_key_enable_unified_trust_panel).apply {
- isVisible = Config.channel.isNightlyOrDebug
+ isVisible = true
isChecked = context.settings().enableUnifiedTrustPanel
onPreferenceChangeListener = SharedPreferenceUpdater()
}
@@ -231,7 +233,7 @@ class SecretSettingsFragment : PreferenceFragmentCompat() {
}
requirePreference<SwitchPreference>(R.string.pref_key_tab_strip).apply {
- isVisible = Config.channel.isNightlyOrDebug && !context.isTabStripEligible()
+ isVisible = true
isChecked = context.settings().tabStripEnabled
onPreferenceChangeListener = SharedPreferenceUpdater()
}
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/tabstrip/TabStripFeatureFlag.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/tabstrip/TabStripFeatureFlag.kt
index d60328df75..12dd091430 100644
--- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/tabstrip/TabStripFeatureFlag.kt
+++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/tabstrip/TabStripFeatureFlag.kt
@@ -20,8 +20,7 @@ fun Context.isTabStripEnabled(): Boolean =
/**
* Returns true for channels that have the tab strip enabled.
*/
-private fun ReleaseChannel.isTabStripChannel(): Boolean =
- isBeta || isNightlyOrDebug
+private fun ReleaseChannel.isTabStripChannel(): Boolean = true
/**
* Returns true if the the device has the prerequisites to enable the tab strip.
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt
index 8e271198b0..74944d94d1 100644
--- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt
+++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt
@@ -1998,25 +1998,23 @@ class Settings(private val appContext: Context) : PreferencesHolder {
*/
var enableComposeTopSites by booleanPreference(
key = appContext.getPreferenceKey(R.string.pref_key_enable_compose_top_sites),
- default = FeatureFlags.COMPOSE_TOP_SITES,
+ default = false,
)
/**
* Indicates if the Compose Homepage is enabled.
*/
- var enableComposeHomepage by lazyFeatureFlagPreference(
+ var enableComposeHomepage by booleanPreference(
key = appContext.getPreferenceKey(R.string.pref_key_enable_compose_homepage),
- default = { FxNimbus.features.composeHomepage.value().enabled },
- featureFlag = true,
+ default = false,
)
/**
* Indicates if the menu redesign is enabled.
*/
- var enableMenuRedesign by lazyFeatureFlagPreference(
+ var enableMenuRedesign by booleanPreference(
key = appContext.getPreferenceKey(R.string.pref_key_enable_menu_redesign),
- default = { FxNimbus.features.menuRedesign.value().enabled },
- featureFlag = true,
+ default = false,
)
/**
@@ -2024,16 +2022,15 @@ class Settings(private val appContext: Context) : PreferencesHolder {
*/
var enableHomepageAsNewTab by booleanPreference(
key = appContext.getPreferenceKey(R.string.pref_key_enable_homepage_as_new_tab),
- default = FeatureFlags.HOMEPAGE_AS_NEW_TAB,
+ default = false,
)
/**
* Indicates if the Homepage Search Bar is enabled.
*/
- var enableHomepageSearchBar by lazyFeatureFlagPreference(
+ var enableHomepageSearchBar by booleanPreference(
key = appContext.getPreferenceKey(R.string.pref_key_enable_homepage_searchbar),
- default = { FxNimbus.features.homepageSearchBar.value().enabled },
- featureFlag = true,
+ default = false,
)
/**
@@ -2041,7 +2038,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
*/
var enableUnifiedTrustPanel by booleanPreference(
key = appContext.getPreferenceKey(R.string.pref_key_enable_unified_trust_panel),
- default = FeatureFlags.UNIFIED_TRUST_PANEL,
+ default = false,
)
/**
@@ -2252,10 +2249,9 @@ class Settings(private val appContext: Context) : PreferencesHolder {
/**
* Indicates if the user is shown the new navigation toolbar.
*/
- var navigationToolbarEnabled by lazyFeatureFlagPreference(
+ var navigationToolbarEnabled by booleanPreference(
key = appContext.getPreferenceKey(R.string.pref_key_toolbar_show_navigation_toolbar),
- default = { FxNimbus.features.navigationToolbar.value().enabled },
- featureFlag = true,
+ default = false,
)
/**
@@ -2467,10 +2463,9 @@ class Settings(private val appContext: Context) : PreferencesHolder {
/**
* Indicates whether or not to show the tab strip.
*/
- var tabStripEnabled by lazyFeatureFlagPreference(
+ var tabStripEnabled by booleanPreference(
key = appContext.getPreferenceKey(R.string.pref_key_tab_strip),
- default = { FxNimbus.features.tabStrip.value().enabled },
- featureFlag = true,
+ default = false,
)
/**