mirror/Libation
1
0
Fork 0
mirror of https://github.com/rmcrackan/Libation.git synced 2026-06-02 12:56:52 -04:00
Code Issues Packages Projects Releases Wiki Activity

#1823 - Address full disk better. Fail clearly and early when possible, fail safely when space cannot be queried, and do not take down the UI or spam the user when the disk is full.

Browse Source
This commit is contained in:
rmcrackan
2026-05-18 09:20:51 -04:00
parent 9f1d4a383b
commit 77f518f8d3
13 changed files with 362 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
Source/LibationUiBase/ProcessQueue/ProcessQueueViewModel.cs
View File

@@ -73,8 +73,13 @@ public class ProcessQueueViewModel : ReactiveObject
private void Queue_CompletedCountChanged(object? sender, int e)
{
int errCount = Queue.Completed.Count(p => p.Result is ProcessBookResult.FailedAbort or ProcessBookResult.FailedSkip or ProcessBookResult.FailedRetry or ProcessBookResult.ValidationFail);
int completeCount = Queue.Completed.Count(p => p.Result is ProcessBookResult.Success);
var errCount = Queue.Completed.Count(p => p.Result
is ProcessBookResult.FailedAbort
or ProcessBookResult.FailedSkip
or ProcessBookResult.FailedRetry
or ProcessBookResult.ValidationFail
or ProcessBookResult.DiskFull);
var completeCount = Queue.Completed.Count(p => p.Result is ProcessBookResult.Success);
ErrorCount = errCount;
CompletedCount = completeCount;
@@ -127,7 +132,7 @@ public class ProcessQueueViewModel : ReactiveObject
return false;
}
public bool QueueDownloadDecrypt(IList<LibraryBook> libraryBooks, Configuration? config = null)
public async Task<bool> QueueDownloadDecryptAsync(IList<LibraryBook> libraryBooks, Configuration? config = null)
{
config ??= Configuration.Instance;
if (!IsBooksDirectoryValid(config))
@@ -182,6 +187,10 @@ public class ProcessQueueViewModel : ReactiveObject
if (toLiberate.Length > 0)
{
// May no-op when free space is unknown (common on UNC); see DiskSpaceBackupPreflight.
if (!await DiskSpaceBackupPreflight.ConfirmBulkBackupAsync(toLiberate.Length, config))
return false;
Serilog.Log.Logger.Information("Begin backup of {count} library books", toLiberate.Length);
AddDownloadDecrypt(toLiberate, config);
return true;
@@ -299,6 +308,7 @@ public class ProcessQueueViewModel : ReactiveObject
ProgressBarVisible = true;
var startingTime = DateTime.Now;
bool shownLicenseGuidanceMessage = false;
bool shownDiskFullMessage = false;
using var counterTimer = new System.Threading.Timer(_ => RunningTime = timeToStr(DateTime.Now - startingTime), null, 0, 500);
@@ -321,6 +331,20 @@ public class ProcessQueueViewModel : ReactiveObject
Queue.ClearCurrent();
else if (result == ProcessBookResult.FailedAbort)
Queue.ClearQueue();
// Stop the whole queue on first real disk-full write (local or network); do not retry hundreds of titles.
else if (result == ProcessBookResult.DiskFull)
{
if (!shownDiskFullMessage)
{
await MessageBoxBase.Show(
DiskFullUserMessage.BuildQueueStoppedBody(),
DiskFullUserMessage.DialogCaption,
MessageBoxButtons.OK,
MessageBoxIcon.Warning);
shownDiskFullMessage = true;
}
Queue.ClearQueue();
}
else if (result == ProcessBookResult.FailedSkip)
await nextBook.LibraryBook.UpdateBookStatusAsync(LiberatedStatus.Error);
else if (!shownLicenseGuidanceMessage