mirror/Libation
1
0 Fork 0
mirror of https://github.com/rmcrackan/Libation.git synced 2026-09-15 15:19:48 -04:00
Code Issues Packages Projects Releases Wiki Activity

Clear the review nits

Browse Source 
Deleted rather than documented: TrackedQueue's Current, Active,
ClearCurrent() and MoveNext(). The first three had no callers at all, and
MoveNext() had exactly one - the Avalonia design-mode preview, which now
builds its sample queue from TryDequeueNext and MarkCompleted, the same
calls the dispatch loop makes. The "legacy / kept for compatibility" labels
pointed at callers that stopped existing when the loop stopped being
sequential.

TrackedQueue.Current's doc comment cited the speed limit display as its
reason to exist, which stopped being true when the speed limit moved to
GetActive(). SpeedLimit itself now records why the sequential loop's
per-book read-back was dropped rather than leaving it unexplained: with
several books running there is no single book to read it back from, and
doing so would have whichever started last overwrite what the user typed.

Restored the UTF-8 BOMs on ProcessQueueViewModel.cs and
BadBookSessionContext.cs, and put back the eight "// " separators in the
WinForms designer that had been rewritten to "//". That file's diff is now
identical with and without whitespace, so everything left in it is a real
change.
This commit is contained in:
Allamagoosa committed 2026-08-20 17:13:30 -07:00
1 parent 1eddccbe63
commit f816ccf3e4
6 files changed
+65 -107
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

Source/LibationWinForms/ProcessQueue/ProcessQueueControl.Designer.cs
Generated
+16 -16
View File
@@ -171,9 +171,9 @@
this.panel1.Name = "panel1";
this.panel1.Size = new System.Drawing.Size(390, 52);
this.panel1.TabIndex = 2;
//
//
// queueSettingsTable
//
//
this.queueSettingsTable.ColumnCount = 3;
this.queueSettingsTable.ColumnStyles.Add(new System.Windows.Forms.ColumnStyle(System.Windows.Forms.SizeType.AutoSize));
this.queueSettingsTable.ColumnStyles.Add(new System.Windows.Forms.ColumnStyle(System.Windows.Forms.SizeType.Absolute, 70F));
@@ -193,9 +193,9 @@
this.queueSettingsTable.RowStyles.Add(new System.Windows.Forms.RowStyle(System.Windows.Forms.SizeType.Percent, 50F));
this.queueSettingsTable.Size = new System.Drawing.Size(220, 50);
this.queueSettingsTable.TabIndex = 9;
//
//
// autoScrollChk
//
//
this.autoScrollChk.Anchor = System.Windows.Forms.AnchorStyles.Left;
this.autoScrollChk.AutoSize = true;
this.autoScrollChk.Checked = true;
@@ -205,9 +205,9 @@
this.autoScrollChk.TabIndex = 6;
this.autoScrollChk.Text = "Auto-scroll";
this.autoScrollChk.UseVisualStyleBackColor = true;
//
//
// concurrencyLbl
//
//
this.concurrencyLbl.Anchor = System.Windows.Forms.AnchorStyles.Left | System.Windows.Forms.AnchorStyles.Right;
this.concurrencyLbl.AutoSize = false;
this.concurrencyLbl.Name = "concurrencyLbl";
@@ -215,16 +215,16 @@
this.concurrencyLbl.TextAlign = System.Drawing.ContentAlignment.MiddleRight;
this.concurrencyLbl.TabIndex = 7;
this.concurrencyLbl.Text = "At once:";
//
//
// concurrencyNum
//
//
this.concurrencyNum.Anchor = System.Windows.Forms.AnchorStyles.Left;
this.concurrencyNum.Name = "concurrencyNum";
this.concurrencyNum.Size = new System.Drawing.Size(84, 23);
this.concurrencyNum.TabIndex = 8;
//
//
// label1
//
//
this.label1.Anchor = System.Windows.Forms.AnchorStyles.Left | System.Windows.Forms.AnchorStyles.Right;
this.label1.AutoSize = false;
this.label1.Name = "label1";
@@ -232,9 +232,9 @@
this.label1.TextAlign = System.Drawing.ContentAlignment.MiddleRight;
this.label1.TabIndex = 5;
this.label1.Text = "DL Limit:";
//
//
// numericUpDown1
//
//
this.numericUpDown1.Anchor = System.Windows.Forms.AnchorStyles.Left;
this.numericUpDown1.DecimalPlaces = 1;
this.numericUpDown1.Increment = new decimal(new int[] {
@@ -260,9 +260,9 @@
0,
0});
this.numericUpDown1.ValueChanged += new System.EventHandler(this.numericUpDown1_ValueChanged);
//
//
// btnCleanFinished
//
//
this.btnCleanFinished.Dock = System.Windows.Forms.DockStyle.Right;
this.btnCleanFinished.Location = new System.Drawing.Point(298, 0);
this.btnCleanFinished.Name = "btnCleanFinished";
@@ -271,9 +271,9 @@
this.btnCleanFinished.Text = "Clear Finished";
this.btnCleanFinished.UseVisualStyleBackColor = true;
this.btnCleanFinished.Click += new System.EventHandler(this.btnClearFinished_Click);
//
//
// cancelAllBtn
//
//
this.cancelAllBtn.Dock = System.Windows.Forms.DockStyle.Left;
this.cancelAllBtn.Location = new System.Drawing.Point(0, 0);
this.cancelAllBtn.Name = "cancelAllBtn";