mirror of
https://github.com/rmcrackan/Libation.git
synced 2026-09-13 06:07:30 -04:00
Cursor Agentandrmcrackan
bb55fb40a3
Both grids restored the last good filter by recursing into the filter handler, which never terminated once the search index rather than the query was the problem: the restore fails the same way, and the retry uses the same filter. The user got an endless run of dialogs, each of them blaming a filter string that was fine. Only an empty last-good filter broke the loop, because that short-circuits before reaching the search engine. The fallback is now a bounded sequence -- last good filter, then no filter -- and the message distinguishes an index Libation cannot reach from a query it cannot parse. Only the first failure is reported, so restoring is quiet. A malformed query never surfaces as an IO-family exception, which QueryFailureShapeTests pins against the real engine, so a typo is never mistaken for index trouble or made to trigger a rebuild. Co-authored-by: rmcrackan <rmcrackan@gmail.com>
44 lines
1.8 KiB
C#
44 lines
1.8 KiB
C#
using LibationSearchEngine;
|
|
using System;
|
|
using System.IO;
|
|
using System.Threading;
|
|
|
|
namespace LibationUiBase;
|
|
|
|
/// <summary>
|
|
/// Shared copy for telling the user that Libation's search index needs to be deleted by hand.
|
|
/// Reached only after the automatic delete-and-rebuild has already failed.
|
|
/// </summary>
|
|
public static class SearchIndexRecovery
|
|
{
|
|
public const string Caption = "Search index needs attention";
|
|
|
|
public const string ManualRecoveryInstructions
|
|
= "Libation could not use its search index, and could not repair it automatically. "
|
|
+ "Your library itself is fine; only searching and filtering are affected.\n\n"
|
|
+ "To fix it by hand:\n"
|
|
+ "1. In Settings, click 'Open log folder'\n"
|
|
+ "2. Close Libation\n"
|
|
+ "3. Delete the SearchEngine folder you find there\n"
|
|
+ "4. Start Libation again";
|
|
|
|
/// <summary>
|
|
/// True when a search failed because the index could not be reached, rather than because the query was
|
|
/// malformed. A damaged index, a held write.lock and a permission problem all arrive as IO-family exceptions,
|
|
/// plus the cloud-sync debris that Lucene reports as an <see cref="ArgumentException"/>; a query Lucene cannot
|
|
/// parse arrives as none of those. Getting this backwards would send the user hunting for a typo in a query
|
|
/// that was fine.
|
|
/// </summary>
|
|
public static bool IsIndexUnavailable(Exception ex)
|
|
=> ex is IOException or UnauthorizedAccessException
|
|
|| SearchEngine.IsRecoverableCorruptIndexException(ex);
|
|
|
|
private static int notified;
|
|
|
|
/// <summary>
|
|
/// True the first time the index fails in this session, false afterwards. A damaged index fails on every
|
|
/// library change, and these steps only need following once.
|
|
/// </summary>
|
|
public static bool ShouldNotify() => Interlocked.Exchange(ref notified, 1) == 0;
|
|
}
|