mirror of
https://github.com/rmcrackan/Libation.git
synced 2026-09-13 06:07:30 -04:00
Cursor Agentandrmcrackan
6a6e1ce330
A storefront that no longer lists a title still answers a request for it: HTTP 200, total_results 1, and a product carrying an asin and a few always-returned flags. Nothing between the request and the file noticed, so a re-download replaced a metadata file written while the title was still listed - the only copy of that data - with the placeholder. Fetch the product before touching the destination, and leave the file alone when the product carries no title. Reported in issue #1947, where a Canada-only title produced {"asin":...,"asset_details":[],"is_preview_enabled":false,"is_vvab":false,"rating":{...}} against every other storefront. Co-authored-by: rmcrackan <rmcrackan@gmail.com>
74 lines
2.8 KiB
C#
74 lines
2.8 KiB
C#
using Microsoft.VisualStudio.TestTools.UnitTesting;
|
|
using Newtonsoft.Json.Linq;
|
|
|
|
namespace FileLiberator.Tests;
|
|
|
|
/// <summary>
|
|
/// Recognising the placeholder product Audible returns for a title its storefront no longer lists, so a
|
|
/// re-download of that title does not replace a real metadata file with the placeholder. Reported in
|
|
/// issue #1947.
|
|
/// </summary>
|
|
[TestClass]
|
|
public class CatalogMetadataTests
|
|
{
|
|
/// <summary>
|
|
/// Verbatim from <c>api.audible.com/1.0/catalog/products/?asins=B089T8FSK6&response_groups=<all></c>,
|
|
/// the response behind the empty metadata file in the report. The title itself is real and downloadable;
|
|
/// it is only listed in the Canadian storefront, so every other one answers with this.
|
|
/// </summary>
|
|
private const string DelistedProduct = """
|
|
{
|
|
"asin": "B089T8FSK6",
|
|
"asset_details": [],
|
|
"is_preview_enabled": false,
|
|
"is_vvab": false,
|
|
"rating": {
|
|
"num_reviews": 0,
|
|
"overall_distribution": { "average_rating": 0.0, "display_stars": 0.0, "num_ratings": 0 },
|
|
"performance_distribution": { "average_rating": 0.0, "display_stars": 0.0, "num_ratings": 0 },
|
|
"story_distribution": { "average_rating": 0.0, "display_stars": 0.0, "num_ratings": 0 }
|
|
}
|
|
}
|
|
""";
|
|
|
|
/// <summary>The same asin from the one storefront that still lists it, trimmed to the fields that matter here.</summary>
|
|
private const string ListedProduct = """
|
|
{
|
|
"asin": "B089T8FSK6",
|
|
"asset_details": [],
|
|
"authors": [ { "asin": "B002BMEJ9I", "name": "David D. Friedman" } ],
|
|
"content_type": "Product",
|
|
"is_vvab": false,
|
|
"publisher_name": "David Friedman",
|
|
"release_date": "2020-06-10",
|
|
"runtime_length_min": 610,
|
|
"subtitle": "Technology and Freedom in an Uncertain World",
|
|
"title": "Future Imperfect"
|
|
}
|
|
""";
|
|
|
|
[TestMethod]
|
|
public void A_delisted_titles_placeholder_product_is_empty()
|
|
=> Assert.IsTrue(DownloadDecryptBook.CatalogProductIsEmpty(JObject.Parse(DelistedProduct)));
|
|
|
|
[TestMethod]
|
|
public void A_product_the_storefront_still_lists_is_not_empty()
|
|
=> Assert.IsFalse(DownloadDecryptBook.CatalogProductIsEmpty(JObject.Parse(ListedProduct)));
|
|
|
|
[TestMethod]
|
|
public void A_product_with_nothing_at_all_is_empty()
|
|
=> Assert.IsTrue(DownloadDecryptBook.CatalogProductIsEmpty(JObject.Parse("""{ "asin": "B089T8FSK6" }""")));
|
|
|
|
[TestMethod]
|
|
public void A_title_of_whitespace_counts_as_no_title()
|
|
=> Assert.IsTrue(DownloadDecryptBook.CatalogProductIsEmpty(JObject.Parse("""{ "asin": "B089T8FSK6", "title": " " }""")));
|
|
|
|
/// <summary>
|
|
/// A product carrying nothing but its title is thin, but it is data Audible sent and the user asked for.
|
|
/// The guard only rejects the placeholder.
|
|
/// </summary>
|
|
[TestMethod]
|
|
public void A_product_with_only_a_title_is_kept()
|
|
=> Assert.IsFalse(DownloadDecryptBook.CatalogProductIsEmpty(JObject.Parse("""{ "asin": "B089T8FSK6", "title": "Future Imperfect" }""")));
|
|
}
|