mirror of
https://github.com/rmcrackan/Libation.git
synced 2026-09-12 21:57:19 -04:00
Cursor Agentandrmcrackan
099b01af14
The previous check read the OneDrive environment variables and matched path prefixes, so it missed Dropbox, Google Drive and iCloud, and had its own guesswork to get wrong. Every sync engine that serves files on demand registers a sync root with the Cloud Files API, and CfGetSyncRootInfoByPath answers directly whether a path sits under one. That covers every provider without naming any of them, and it replaces the environment lookups, path canonicalisation and prefix matching rather than adding to them. Asking for the provider info class also gets the provider's own name, so the message can say Dropbox rather than a generic phrase. The buffers are plain byte arrays read by hand: nothing here can be verified away from Windows, so there is no marshalling to get subtly wrong. Detection cannot produce a false positive now, since the answer is Windows' rather than an inference from a folder name. The warning still appears only in the incomplete-upgrade message, where something has already failed, so a folder someone deliberately keeps fully downloaded never prompts anything. Co-authored-by: rmcrackan <rmcrackan@gmail.com>
59 lines
2.2 KiB
C#
59 lines
2.2 KiB
C#
using Microsoft.VisualStudio.TestTools.UnitTesting;
|
|
using System;
|
|
using System.IO;
|
|
|
|
namespace LibationFileManager.Tests;
|
|
|
|
[TestClass]
|
|
public class CloudSyncedFoldersTests
|
|
{
|
|
// Sync roots are a Windows concept and the answer comes from cldapi.dll, so there is nothing
|
|
// here for CI on Linux to verify beyond the guards. The Windows path needs a machine with a
|
|
// sync client installed, which CI does not have either.
|
|
[TestMethod]
|
|
public void Nothing_is_synced_off_windows()
|
|
{
|
|
if (OperatingSystem.IsWindows())
|
|
Assert.Inconclusive("Skipped because the OS is Windows, where a real sync root may exist.");
|
|
|
|
var status = CloudSyncedFolders.GetSyncStatus(Path.GetTempPath());
|
|
|
|
Assert.IsFalse(status.IsSynced);
|
|
Assert.IsNull(status.ProviderName);
|
|
}
|
|
|
|
[TestMethod]
|
|
[DataRow(null)]
|
|
[DataRow("")]
|
|
[DataRow(" ")]
|
|
public void A_missing_path_is_not_synced(string? path)
|
|
=> Assert.IsFalse(CloudSyncedFolders.GetSyncStatus(path).IsSynced);
|
|
|
|
[TestMethod]
|
|
public void The_description_names_the_provider_when_windows_reported_one()
|
|
=> Assert.AreEqual("OneDrive", new CloudSyncStatus(true, "OneDrive").Description);
|
|
|
|
// Windows reports the fact of syncing through one info class and the provider name through
|
|
// another, so the name can be missing while the folder really is synced.
|
|
[TestMethod]
|
|
[DataRow(null)]
|
|
[DataRow("")]
|
|
public void The_description_falls_back_when_no_provider_name_came_back(string? providerName)
|
|
=> Assert.AreEqual("a cloud sync folder", new CloudSyncStatus(true, providerName).Description);
|
|
|
|
[TestMethod]
|
|
public void An_unsynced_install_adds_nothing_to_the_upgrade_failure_message()
|
|
=> Assert.AreEqual(string.Empty, StartupAssemblyBootstrap.DescribeCloudSyncedInstall(CloudSyncStatus.NotSynced));
|
|
|
|
// The paragraph carries its own blank lines so the message around it reads the same either way.
|
|
[TestMethod]
|
|
public void A_synced_install_names_the_provider_and_keeps_its_own_spacing()
|
|
{
|
|
var paragraph = StartupAssemblyBootstrap.DescribeCloudSyncedInstall(new CloudSyncStatus(true, "Dropbox"));
|
|
|
|
StringAssert.Contains(paragraph, "inside Dropbox.");
|
|
StringAssert.StartsWith(paragraph, Environment.NewLine);
|
|
StringAssert.EndsWith(paragraph, Environment.NewLine);
|
|
}
|
|
}
|