mirror of
https://github.com/rmcrackan/Libation.git
synced 2026-09-13 06:07:30 -04:00
Cursor Agentandrmcrackan
612ec05b19
When Libation cannot install an upgrade itself - a portable or AppImage install, a Linux build with no package-manager symlink, macOS outside /Applications - the prompt is a notice with a download link, and Chardonnay relabels its button from "Yes" to "OK" to say so. The button still closed with DialogResult.OK, which MainWindow and the About window both read as "yes, install it", so acknowledging the notice downloaded the release and ran the auto-upgrader anyway. That could only fail, and it failed loudly: an "Upgrade Failed" error box in answer to dismissing a notice. The button now closes with Cancel when there was no upgrade on offer, so the answer matches the question. Classic already did the equivalent, hiding its Yes button and relabelling No. UpgraderBase gets the matching guard. It already refused to install under Windows Application Control on the grounds that a UI ignoring CapUpgrade must not be able to start an upgrade that leaves Libation unable to start; that reasoning covers every capped upgrade, not just the Windows one, so the stop is now keyed on CapUpgrade itself via MayInstallUpgrade. Co-authored-by: rmcrackan <rmcrackan@gmail.com>