From 3de62576097114b6a012ee85e6e64c4714e16733 Mon Sep 17 00:00:00 2001 From: Ettore Di Giacinto Date: Sat, 26 Sep 2026 15:41:24 +0000 Subject: [PATCH] fix(failover): satisfy lint on the manager package errcheck flagged two side-effect-only m.Plan calls in tests, and unused flagged close(), which Task 5's probe scheduler wires in. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Ettore Di Giacinto --- core/services/failover/manager.go | 1 + core/services/failover/manager_test.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/core/services/failover/manager.go b/core/services/failover/manager.go index b38ec9a49..c52aa2b7d 100644 --- a/core/services/failover/manager.go +++ b/core/services/failover/manager.go @@ -575,6 +575,7 @@ func (m *Manager) emitLocked(ev Event) { } } +//nolint:unused // wired by the Task 5 probe scheduler's Stop, which owns the manager's lifecycle func (m *Manager) close() { m.mu.Lock() defer m.mu.Unlock() diff --git a/core/services/failover/manager_test.go b/core/services/failover/manager_test.go index 0ea98c2a0..f10a04f2c 100644 --- a/core/services/failover/manager_test.go +++ b/core/services/failover/manager_test.go @@ -88,7 +88,7 @@ var _ = Describe("Manager", func() { }) It("fails back only after recovery probes and min_dwell", func() { - m.Plan("chain") + _, _ = m.Plan("chain") m.ReportFailure("a", errBoom) for i := 0; i < 3; i++ { m.ReportSuccess("a") // a real success counts like a passed inference probe @@ -158,7 +158,7 @@ var _ = Describe("Manager", func() { }) It("marks a removed target missing and leaves it out of plans", func() { - m.Plan("chain") + _, _ = m.Plan("chain") src.Delete("a") m.Sync() st, _ := m.ChainStatus("chain")