From 6108ba69fa0c23accff7833f9895def274df6559 Mon Sep 17 00:00:00 2001 From: mudler-agent Date: Fri, 23 Oct 2026 12:27:29 +0200 Subject: [PATCH] fix(ci): make master green after the library merge (#12855) The library change added InstallLibraryBackend to the LocalAIClient interface, but the stub in the MCP endpoint test was not updated. The mcp test package no longer compiled, which failed golangci-lint and stopped the Ginkgo run in tests-linux and tests-apple. The same change added the official_libraries setting, so the Settings page now shows 55 settings plus the three branding images. Update the count the grouping spec expects from 57 to 58. Assisted-by: Claude:claude-sonnet-5-5 [Claude Code] Signed-off-by: Ettore Di Giacinto Co-authored-by: Ettore Di Giacinto --- core/http/endpoints/mcp/localai_assistant_test.go | 4 ++++ core/http/react-ui/e2e/settings-page.spec.js | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/core/http/endpoints/mcp/localai_assistant_test.go b/core/http/endpoints/mcp/localai_assistant_test.go index 3e539ce7d..36407565b 100644 --- a/core/http/endpoints/mcp/localai_assistant_test.go +++ b/core/http/endpoints/mcp/localai_assistant_test.go @@ -71,6 +71,10 @@ func (stubClient) ListKnownBackends(_ context.Context) ([]schema.KnownBackend, e return []schema.KnownBackend{}, nil } +func (stubClient) InstallLibraryBackend(_ context.Context, _ localaitools.InstallLibraryBackendRequest) (*localaitools.InstallLibraryBackendResult, error) { + return &localaitools.InstallLibraryBackendResult{Status: "installed", Name: "stub-backend"}, nil +} + func (stubClient) InstallBackend(_ context.Context, _ localaitools.InstallBackendRequest) (string, error) { return "stub-backend-job", nil } diff --git a/core/http/react-ui/e2e/settings-page.spec.js b/core/http/react-ui/e2e/settings-page.spec.js index 7780141c7..985f4c119 100644 --- a/core/http/react-ui/e2e/settings-page.spec.js +++ b/core/http/react-ui/e2e/settings-page.spec.js @@ -34,9 +34,9 @@ test.describe('Settings: groups and search', () => { seen.add(key) } } - // 54 settings plus the three branding images. - expect(seen.size).toBe(57) - await expect(page.getByLabel(/Search all 57 settings/)).toBeVisible() + // 55 settings plus the three branding images. + expect(seen.size).toBe(58) + await expect(page.getByLabel(/Search all 58 settings/)).toBeVisible() }) test('a group lists its settings, and the memory group shows memory use now', async ({ page }) => {