From 6eb187dab005af79bba7252fd8d7d518684cbc7d Mon Sep 17 00:00:00 2001 From: Ettore Di Giacinto Date: Tue, 3 Nov 2026 14:33:23 +0000 Subject: [PATCH] test(ui): allow the GitHub service names in the provider strings test The GitHub add-on made "GitHub" a provider name, so the test flagged three strings that name the service itself: the OAuth sign-in button, the footer link to the project repository and the "GitHub releases" package source in the egress registries hint. None of them names the add-on, so add narrow, reasoned allow-list entries for exactly those keys. Assisted-by: Claude:claude-sonnet-5-5 node npm --- core/http/react-ui/tests/unit/provider-strings-allowlist.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/core/http/react-ui/tests/unit/provider-strings-allowlist.json b/core/http/react-ui/tests/unit/provider-strings-allowlist.json index ce41da669b..ae7e2a67c3 100644 --- a/core/http/react-ui/tests/unit/provider-strings-allowlist.json +++ b/core/http/react-ui/tests/unit/provider-strings-allowlist.json @@ -3,12 +3,15 @@ "admin:settingsTools.labels.web_search": "the web (the internet) as a noun: the label of the built-in search tool", "admin:usage.sources.ribbonAria": "Web UI: the browser interface as a source of API traffic", "admin:usage.sources.webUI": "Web UI: the browser interface as a source of API traffic", + "auth:login.signInWithGitHub": "GitHub as the OAuth identity service a person signs in with; the service, not the GitHub add-on", "chat:steps.verb.websearch": "the web (the internet) as a noun: the verb of a search step", "chats:connectorsPage.noAddonHint": "Telegram is named as an example of a platform a connector carries; content, not a provider", "chats:conversionPage.intro": "names the legacy Telegram connectors that the one-time conversion migrated; content", + "chats:egress.presetHint.registries": "GitHub releases as a package source the registries preset allows; the service host, not the GitHub add-on", "chats:mcpPage.family": "Telegram and Slack are examples of messaging platforms; content, not a provider", "chats:tools.builtin.web": "the name of the built-in Web tool group of the Tools menu", "collections:sources.title": "web sources of a collection: pages fetched from the internet", + "nav:footer.github": "the footer link to the project's GitHub repository; the service, not the GitHub add-on", "pages:subtitle": "a sandbox as the isolated frame a page runs in; not the Sandbox add-on", "pages:viewer.sandboxShared": "a sandbox as the isolated frame a page runs in; not the Sandbox add-on", "settings:chats_web_allow_private.label": "the web (the internet) as a noun: web pages the built-in fetch tool may read",