mirror/LocalAI
1
0
Fork 0
mirror of https://github.com/mudler/LocalAI.git synced 2026-06-27 01:47:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore(vllm): derive the darwin vLLM version, drop the second pin

Browse Source 
Follow-up: VLLM_VERSION was still a hardcoded string duplicating what
VLLM_METAL_VERSION already determines. Derive it at install time from
vllm-metal's own installer (vllm_v=) at the pinned tag - one source of truth,
no second value to drift. The bumper now touches only VLLM_METAL_VERSION;
the derivation is immutable per tag, so builds stay reproducible.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Assisted-by: Claude:opus-4.8 [Claude Code]
This commit is contained in:
Ettore Di Giacinto
2026-06-24 20:25:07 +00:00
parent 7743a0abc0
commit af7d0e8b40
2 changed files with 29 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
.github/bump_vllm_metal.sh vendored
View File

@@ -1,13 +1,11 @@
#!/bin/bash
# Bump the vllm-metal pins in the vLLM backend's darwin (Apple Silicon) install
# path. The macOS/Metal build (backend/python/vllm/install.sh, Darwin branch)
# installs vllm-metal, which is version-locked to a specific vLLM source release.
# Two values must move together:
# VLLM_METAL_VERSION -> the vllm-metal GitHub release tag (its prebuilt wheel)
# VLLM_VERSION -> the vLLM source version that release builds against
# vllm-metal declares the latter in its OWN install.sh as `vllm_v="X.Y.Z"`. This
# script reads both from vllm-metal's latest release and rewrites them atomically
# -- mirroring bump_vllm_wheel.sh, which does the same for the Linux cu130 wheel.
# Bump the single vllm-metal pin (VLLM_METAL_VERSION) in the vLLM backend's
# darwin (Apple Silicon) install path. The macOS/Metal build
# (backend/python/vllm/install.sh, Darwin branch) installs vllm-metal, which is
# version-locked to a specific vLLM source release. install.sh derives that vLLM
# version at build time from vllm-metal's own installer (`vllm_v=`) at the pinned
# tag, so there is only ONE value to bump here -- mirroring bump_vllm_wheel.sh,
# which bumps the Linux cu130 wheel pin.
#
# This deliberately tracks vllm-project/vllm-metal, NOT vllm-project/vllm: the
# darwin build can only use the exact vLLM version vllm-metal supports, so it may
@@ -42,11 +40,11 @@ set +e
CURRENT_TAG=$(grep -oE 'VLLM_METAL_VERSION="[^"]*"' "$FILE" | head -1 | cut -d'"' -f2)
set -e
# Rewrite both pins. peter-evans/create-pull-request opens no PR on a clean tree,
# so a no-op rewrite (already current) is safe.
# Rewrite the single pin. install.sh derives VLLM_VERSION from this tag at build
# time, so there is nothing else to touch. peter-evans/create-pull-request opens
# no PR on a clean tree, so a no-op rewrite (already current) is safe.
sed -i "$FILE" \
-e "s|VLLM_METAL_VERSION=\"[^\"]*\"|VLLM_METAL_VERSION=\"$LATEST_TAG\"|" \
-e "s|VLLM_VERSION=\"[^\"]*\"|VLLM_VERSION=\"$NEW_VLLM_VERSION\"|"
-e "s|VLLM_METAL_VERSION=\"[^\"]*\"|VLLM_METAL_VERSION=\"$LATEST_TAG\"|"
if [ -z "$CURRENT_TAG" ]; then
echo "Could not find VLLM_METAL_VERSION=\"...\" in $FILE." >&2