Files
mudler-agentandEttore Di Giacinto e45dc5e9f7 feat(addons): installable add-ons foundation and the Tables add-on (#12702)
* feat(addons): add the add-on runtime, navigation and first-party add-ons

Add the add-on runtime to LocalAI: manifests, the host operation broker,
admin gating by account role, the add-on UI bundle builder and the SDK
for add-on pages. Move the navigation to Chat, Models, Add-ons and
Settings, with pinned add-ons in the sidebar and an Add-ons drawer.

Ship the first-party add-ons (voice, face, fine-tuning, quantization) as
packages for linux/amd64, linux/arm64 and darwin/arm64. Intel macOS
(darwin/amd64) is enabled in the platform files.

Squashed from the review branch. The tree is unchanged; the pre-squash
history is kept on a local backup branch.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(gosec): tighten file modes and annotate false positives

Write job state, configs and imported models with mode 0600, clean
the paths that are read from disk, and mark the route tables, the
header name and the retry jitter as reviewed false positives.

Assisted-by: Claude Code:claude-sonnet-5-5 gosec
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): keep API keys off recovery mutations and same-site cookies

POST /api/addons/dispatch forwarded the recovery and update
mutations to the owner for any administrator key, which skipped the
browser-session rule of their own routes. Refuse those actions
there. Also apply the same-origin rule to the legacy token cookie,
not only the session cookie, because the global CSRF check lets
same-site requests through.

Do not fail the start of LocalAI when an add-on library cannot be
refreshed; log it and keep the installed add-ons up.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): refuse a reinstall that would migrate retained data unbacked

An upgrade takes a verified backup before the new package migrates
the data. A reinstall over retained data has no running generation
to stop, so the new package would migrate it without one. Refuse a
reinstall whose data format differs from the retained one.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): release the manager lock while a release is fetched

Submit held the state lock across the catalog lookup and the package
download, so the apps list and status reads stalled for the whole
install. Serialize Submit and Reconcile with their own lock and drop
the state lock around the fetch only.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): kill an add-on only after three missed health probes

One slow 100 ms probe killed a busy add-on and dropped the work it
was serving. Require three misses in a row.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(ui): move settings under the operate hub

The Operate hub already has Settings as a tab, so the sidebar no longer shows a separate Settings entry. The /app/settings route stays, and the hub tab still reaches it. The navigation test now expects Chat, Models and Add-ons as the primary items.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): accept same-host browser requests that carry no fetch metadata

Browsers do not send Sec-Fetch-* headers over plain HTTP on an address
that is not localhost, so every add-on request from a LAN address was
refused as cross-site. Keep refusing a Sec-Fetch-Site value other than
same-origin. When the header is absent, accept the request only if its
Origin, or failing that its Referer, names the same host and port as
the request.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): show the server's reason when an add-on request is refused

A 403 or 400 answer showed a generic message and hid the reason in the
response body, so a refusal by the browser guard could not be told from
a missing permission. Show error.message from the body as the server
sent it, and keep the generic text when the body has none.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): run the add-on owner in the normal binary

The owner was only enabled when an embedding host set the add-on config,
so a normal run answered every add-on request as unavailable.

Add --addons-enabled (default true) and --addons-ownership-mode
(default named-user, or local-owner; anything else stops startup).
The node is its own owner: state lives under the data path, and the
carrier uses loopback keys made at each start and kept in memory.
--addons-enabled=false turns the owner off completely.

Named-user mode needs the account database. With authentication off
the owner stays off and a warning says how to use local-owner.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): keep the loopback owner address stable across restarts

The single-node loopback transport took a new ephemeral port at each
start. The owner stores its address in its identity file and refuses to
start when the address differs, so every start after the first failed
with "invalid addon owner configuration".

Choose the port once, keep it in the add-on state root (loopback-port,
mode 0600) and reuse it. If the port is taken at a later start, stop
with an error that names the port and --addons-enabled=false, because
another port would break the identity check. The keys and certificate
stay in memory.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): let add-on pages keep the host modules they were written against

A page written for the web UI imports React, the router, i18next and a
few shared components. The add-on builder refuses a bundle that holds a
host file, so moving such a page into an add-on meant rewriting it.

Add a compat mode to the shared builder. It answers those imports from a
directory of stand-ins that read the SDK, bundles the dynamic import of
the page code into the one output file, and collects the style sheets the
page imports. A relative import that is not in the add-on's own source
resolves to the file at the same path under the compat directory.

Widen the SDK for these pages, without a version change: more host
components (spinner, modal, lightbox, model picker) and hooks (models,
resources, voice profiles, operations, MCP client), a style on icons,
the icon names the pages draw, sdk.navigation.openApp to open a page of
the app (only addresses under /app, and the way back as the only state)
and sdk.portal. The shell passes the query string to the page.

The stand-ins cover the router (the tab in the path, the model in the
query), the translator over the host locale files, the core API calls
through sdk.core.fetch, and byte copies of the pure helpers, with tests
that keep the copies equal to the originals.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): ship Studio and Talk as add-ons instead of built-in pages

Studio and Talk were compiled into the web bundle and always listed in
the Add-ons drawer. They are add-ons now, like Voice, Face, fine-tuning
and quantization: a person installs and removes them, the drawer lists
them only while they are installed, and they are packaged the same way.

Move the pages, their components, hooks and helpers into addons/studio
and addons/talk. Each has a manifest, a UI bundle, a release platform
matrix and a catalog template, and is built by the compat mode of the
shared builder. The core API stays where it is: the pages call it with
the signed-in person's session. The history keeps its browser storage
keys. The unit tests of the moved helpers move with them.

In the core, drop the two pages, the Create group of the sidebar (Chat
joins Home and Models in the old layout), the built-in catalog entries
(the catalog is empty) and the talk locale namespace. The old addresses
(/app/studio, /app/talk and the generator links) redirect to the add-on
pages, with the model as ?model=. The Home /studio command is offered
only while the Studio add-on is installed and opens it.

The release workflow and its tests now list seven add-ons.

Assisted-by: Claude Code:claude-sonnet-5-5 go node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): run the Studio and Talk specs against the add-on bundles

The pages are add-ons now, so a spec that draws one installs the real
built bundle first: the apps list names it and its module and style
sheet are served from the build output, the way the add-on owner serves
them. studio-addon.js holds that helper, and the Studio and Talk
fixtures call it.

Update the specs for the new addresses (/app/addons/studio/studio, the
model as ?model=), the session permission the add-on route needs, the
legacy redirects, the Home /studio command that appears only while the
add-on is installed, and the sidebar without a Create group.

Add specs for the add-ons themselves: every tab draws with no script
error, the shell titles the page once, the old addresses say so when the
add-on is not installed, a button of the page reaches a core page with
the way back, and the drawer lists both only after they are installed.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): centre the icon of a built-in tile in its icon box

The drawer drew the icon of a built-in tile (Studio's palette was one)
in a bare 40px box. Only the placeholder box was laid out as a centred
grid with the 20px size, so the real icon sat in the top-left corner at
the size of the page text.

Give the built-in tile the same classes as the placeholder box, and
check in a browser that the icon is centred.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* docs(addons): describe Studio and Talk as add-ons

Replace the built-in list (now empty) with the Studio and Talk add-on
sections, the new targets of the old links, the Home command, and the
seven packaged add-ons. Describe the SDK additions the pages use:
components, hooks, icons, openApp and portal. Say on the Studio page
that it is installed from the drawer.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): click the shell title in the Studio slash-key spec

The add-on shell titles the page, and the Studio overview no longer draws
a second title, but the generator tabs keep theirs, so a bare h1 locator
matched two elements. Click the first, which is the shell's.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): read the loopback port file through os.Root

The persisted port file was read with a path built from the add-on
root, which gosec reports as a file inclusion through a variable. Open
it through os.Root so the name cannot leave the root, even by a
symbolic link, and require a regular file with no group or other
access. A looser file now fails closed instead of being trusted.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): expect Settings under the Operate hub, not the sidebar

Settings moved out of the sidebar into the Operate hub. The navigation
spec still expected a sidebar link. Assert that the sidebar has no
Settings entry, and that the Operate hub opens Settings as a tab.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): drop Settings from the 404 places

Settings is a tab of the Operate hub and not a destination of its own,
so the 404 page does not list it. Assert that it is absent.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): drive the media history and TTS specs through the Studio add-on

The image, video, sound and speech generators are pages of the Studio
add-on now, and the old addresses redirect to it. Install the add-on
with the Studio fixtures, open its pages and use its compose card, so
the specs run against the page that exists.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): count the first-run steps, not every list item

The recommended models are a list inside the second step, so counting
all list items read 3 only while the models were still loading. Count
the step elements, which does not depend on the load order.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): fail the node refresh by state, not by call count

The spec served the list to the first request and failed the rest. The
first request is not always the one from the page, so the page could
get the failure first and show no list. Serve the list until the page
shows it, then fail the refreshes.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): default to local-owner when auth is off

A server without authentication has no accounts, so named-user left
the add-on owner off. Resolve the unset mode in one place: local-owner
when authentication is off, named-user when it is on. A flag or
environment value still wins, and an unknown value is still refused.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): register an official add-on library by default

Add gallery/addons/index.yaml, a YAML index of the four first-party
add-ons (fine-tuning, quantization, voice, face) in the library format.
The entries come from addonpkg catalog over locally built linux/amd64
packages, so the digests pin those images.

On the first start, when the owner has no sources.json, register the
raw GitHub URL of that index on master as the "official" library and
write the file. The file is then the record: a library the admin
removes stays removed, and an existing file is never changed.
--addons-official-library=false skips the default.

Assisted-by: Claude Code:claude-sonnet-5-5 go node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* docs(addons): document the ownership default and the official library

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): list Studio and Talk in the first-party index

Add the Studio and Talk entries to gallery/addons/index.yaml next to
the four existing ones. They come from addonpkg catalog over locally
built linux/amd64 packages, so the digests pin those images.

Assisted-by: Claude Code:claude-sonnet-5-5 go node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): expect Studio and Talk in the official index

The official index now lists six add-ons. Update the test that
decodes it so it accepts Studio and Talk.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): add a real icon to each first-party add-on

Each icon is a 256 by 256 PNG: a rounded square in one colour of the
UI kit palette with a white outline glyph from the kit sprite. Fine-tuning
uses sliders, quantization layers, voice waveform, face user, studio
palette, talk phone and tables database. They were rendered with headless
Chrome from the sprite paths.

Assisted-by: Claude Code:claude-sonnet-5-5 chrome
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): ship a committed icon.png instead of the generated square

The shared UI builder and the Tables builder copy ui/icon.png from the
add-on source tree to the package unchanged when the file exists. They
write the generated placeholder only when it does not. Add a fixture with
an icon and a test for both cases.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): list the tables add-on in the first-party index

Add the Tables entry to gallery/addons/index.yaml next to the six
existing ones. It comes from addonpkg catalog over a locally built
linux/amd64 package, so the digest pins that image. The official index
test now expects seven add-ons.

Assisted-by: Claude Code:claude-sonnet-5-5 go node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): make the Voice add-on one page with tabs

The Voice add-on had four pages: recognition, library, create and
speech, and the drawer listed two of them. It now has one page, "voice",
and one drawer entry. Recognition, Library, Text to speech and From a
recording are tabs of that page, drawn with the same tab strip the
recognition page already used. The tab is the first path segment
(voice/library), as in the Studio add-on, and the form that adds a voice
is a view of the Library tab (voice/library/new).

The old page names stay declared in the manifest. Each one redirects to
its tab and keeps the query string, so saved links still open.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(ui): send the old voice routes to the Voice tabs

/app/voice, /app/voice-library and /app/voice-library/new now open the
matching tab of the Voice add-on page while the add-on is installed and
running, and the core pages otherwise. The moved-page helper compares
the first segment of the target with the declared pages, so a target
can name a tab. The docs and the navigation spec list the new addresses.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): cover the Voice tabs and the old page redirects

The add-on unit tests render the tabs instead of the four pages. The
Playwright spec checks the tab strip, the address of each tab, the
missing Library tab for a member, and that the old page addresses of the
add-on redirect to their tab with the query string kept. The migration
table test follows the new targets.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(studio): keep the model menu inside a narrow screen

The Home model picker sizes its menu from the viewport, and assumes the
picker sits at the page gutter. In the Studio composer card the field is
further in, so on a 390px screen the menu of the Sound expansion picker
ended 7px past the right edge. Size the menu from the field it opens
under instead.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): build the add-on bundles once for the whole run

Each worker built the Studio and Talk bundles into the same dist
directory, and the build empties that directory first. A worker that
started, or restarted after a failure, removed the files another worker
was serving, so a Studio spec saw "the style sheet of the add-on could
not be loaded". Build once in a global setup before the workers start.
A run without the setup still builds per worker.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): register the worker when the add-node spec says so

The mocked roster added the worker on the third read of /api/nodes. The
shell and the page both read it, and which one asks first depends on
load, so the page could take the new worker as part of the roster it
opened with and never show it as found. The worker now joins after the
page shows it is listening.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): hold the gallery answer until the skeleton is seen

The spec delayed the answer by a fixed 800 ms and then looked for the
skeleton. The assertion polls at growing intervals, so on a slow machine
it could step over that window. The answer now waits until the skeleton
has been seen, and the spec then checks that the skeleton goes away.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): give the PDF tag the time the other PDF specs have

pdf.js and its worker load on first use. The other specs in this file
wait up to ten seconds for the result of that load. The first one waited
five, and missed the tag on a busy machine.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): build the Face and Fine-tuning bundles in the global setup

The navigation spec serves the built Fine-tuning bundle, but nothing
built it, so two specs failed on a fresh checkout when the dist folder
was missing. The spec also built the Face bundle in a hook that every
worker runs, and a build rewrites the folder the other workers serve.

The global setup now builds Studio, Talk, Face and Fine-tuning once,
before the workers start. The spec builds the two bundles itself only
when it runs without the global setup.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): fix the Home answers in the stale pin spec

The spec asserts that the page shows no alert. The Home page raises its
own alert when the model list fails or a staging operation has failed,
and both answers come from the shared test server. A slow reply or a
failed install left there counted as an alert about the pin.

The spec now fixes both answers, so the alert count tells only about the
pin. The assertions are unchanged.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): read the server address in the add-node spec from the page

The spec expected the register address to carry port 8089, so it failed
on any other port. It now expects the origin the page was opened from.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): give the navigation routes spec its own catalog

No page is built in today, so the catalog is empty and the three specs
that expect the studio and talk entries failed on the list and on the
pin seed. They passed only while Studio and Talk were built in.

The spec now sets a catalog of two ungated entries for each example and
restores the old one afterwards. The assertions are unchanged.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(cli): report a failed write of the MLX hostfile

The tunnel callback ignored the error of os.WriteFile and set the
hostfile variable even when the file was not written. It now logs the
error and leaves the variable alone.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): discard the close error of the held listener

errcheck flags the deferred Close of the listener that keeps the port
busy. The test has no use for that error, so the defer drops it
explicitly.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): move the add-on tool tests to Ginkgo

The fine-tuning, quantization and add-on host library tests used
t.Errorf, t.Fatal and t.Run, which the forbidigo rule rejects. They now
use Describe, It and Gomega, with a suite bootstrap in each package. The
cases and the assertions are the same.

The tables in the host client and the tool schema tests keep one entry
per case.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): move the host operation tests to Ginkgo

The hostops tests used the testing package calls that forbidigo rejects.
They now run as Ginkgo specs under one suite bootstrap. Every check and
every per-operation case is kept.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): move the pin store tests to Ginkgo

The pin service, file store, sweep and shared store contract tests used
the testing package calls that forbidigo rejects. The store contract is
now a function that registers its specs for each store, so the file
store, the memory-only store and the database store run the same cases.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): move the remaining add-on tests to Ginkgo

The built-in catalog, tool arguments, loopback carrier, host operation
contract, packaging, application, config, CLI and endpoint tests used
the testing package calls that forbidigo rejects. They now run as Ginkgo
specs. The endpoint tests also drop the unchecked Close errors that
errcheck reports when the auth tag is on.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): wait for the targeted Reinstall button before the install click

The "generic deletion blocks targeted install at confirmation" spec
dispatches a popstate to set the target node, then clicks Reinstall with
a script click. The click can run before the targeted page has rendered
or while the button is still disabled, so no install request is sent and
the poll on the install count times out. It failed 1 run in 10 with two
workers and on every retry in CI.

The spec now waits for the button to be enabled first. The assertions
are unchanged.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* chore(addons): refresh the voice package digest in the first-party index

The Voice add-on became one page with tabs and got a new icon, so the
digest in gallery/addons/index.yaml no longer matched the build. Render
the entry again with addonpkg catalog over a locally built linux/amd64
package; the main page is now voice. The other entries are unchanged.

Assisted-by: Claude Code:claude-sonnet-5-5 go node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): wait for the target node's Reinstall button after the popstate

The "generic deletion blocks targeted install at confirmation" spec
dispatches a popstate to set the target node, then waits for a button
named Reinstall and clicks it. Until React renders the targeted page,
the page still draws the generic Reinstall button. It is enabled and has
the same name, so the wait passed on it, the click started a global
install, and no node install request was sent. The poll on the install
count timed out with the confirm dialog still open.

With the CPU throttled to 8x, the spec failed on 20 of 20 runs, and the
button it clicked had the title "Reinstall". The spec now waits for the
button titled "Reinstall on <node>". With the throttle it passes 30 of
30 runs. The assertions are unchanged.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): give the Studio hand-off spec a budget for the cold bundle load

The "a result made through a hand-off records which result it came from"
spec opens the Studio add-on straight from an address, twice. Each is a
cold load: the page shows "Loading" until the add-on module has run, and
the next assertion had the default five seconds. The load takes about
two seconds on an idle run and seven to ten under CPU load, so the spec
failed on a loaded machine with the hand-off note not yet drawn.

With the CPU throttled to 6x and eight busy loops running, it failed on
21 of 30 runs. The first assertion after each load now waits up to 20
seconds, and the spec then passed 30 of 30 under the same load. The
assertions are unchanged.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): carry the identity page styles in the Face add-on

The Face page is drawn with the shared identity views, but its style sheet
held only the clip and error rules. The page, card, model list, known-faces
table, enrol sheet and distance scale classes had no rules. They looked
right only when the host had already loaded the style sheet of its own
Faces page, which a visit through the add-on drawer does not do. Opened
that way, the cards had no gap, the model list showed bullets, and the
install buttons ran into the names.

The Face sheet now holds the same identity rules as the core sheet, so the
page looks the same whichever way it is opened.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): scope the narrow-screen identity rules of the Voice add-on

The rules for narrow screens (single-column pairs, smaller tool padding,
compact rank rows) were copied into the Voice style sheet without their
media query, so they applied at every width. They now sit in a
max-width 720px query, and the reduced-motion rule in its own query, as in
the core sheet.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): drop the repeated title from the Voice and Face pages

The add-on shell already titles the page, so the recognition pages showed the name twice: "Voice" above "Voices", "Face" above "Faces". Keep the supporting line and the model picker, as the Studio page does, and remove the unused title strings.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(ui): replace the Pinned sidebar section with an Apps entry

The sidebar no longer lists pinned add-ons. It shows one Apps entry that
opens the add-ons drawer, with a Show all link below it that opens the
same drawer. Pins are used from the drawer, where a pinned tile keeps
its pin and move buttons. The server pins API is unchanged.

Remove the PinnedNav component and its locale title, rename the
items.addons label to Apps, and update the e2e specs and the add-ons
documentation to match.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): assert the single shell title on the Voice and Face pages

The add-on shell now shows the one title, "Voice" or "Face", and the page no longer repeats it. The tests still looked for the h1 "Voices" and "Faces". Assert that the add-on page has exactly one h1 and that it is the shell title. The core pages keep their own "Voices" and "Faces" titles.

Assisted-by: Claude Code:claude-sonnet-5-5 playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): drop the repeated title from the Voice Library and Text to speech pages

The add-on shell already titles the page "Voice", so these two tabs showed a second heading below it ("Speech voices", "Speak text"). Keep the supporting line, as the Studio and recognition pages do, and remove the unused title strings. The e2e spec now checks that each tab has exactly one h1, the shell title.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(ui): list pinned apps under Apps in the sidebar

A pinned app now shows as an indented child of the Apps entry, with its icon and title, in pin order. Show all stays the last child. The pins come from GET /api/addons/pins through the navigation context, and the apps from the add-on registry, which the drawer feeds on every list read, so the links follow the drawer. A pin without an installed app is not drawn, nothing extra shows when no app is pinned, and the children are hidden when the sidebar is collapsed to the rail.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* docs(addons): say that pinned apps are listed under Apps in the sidebar

The sidebar lists the pinned apps between Apps and Show all, in pin order. The pins section and the navigation section said that pins do not appear in the sidebar.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): remove the Show all link under Apps in the sidebar

The link repeated the Apps entry, which opens the same drawer, and looked redundant when no app was pinned. Apps is now the only add-on entry; pinned apps still list under it in pin order. The link, its locale key and the style comment are gone, and the e2e spec and the add-ons docs now say that Apps is the only entry.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(ui): show a first-run card on Apps when nothing is installed

An administrator who opens Apps with no add-on installed now sees a
short card with three steps: choose a library, browse and install,
start the add-on. Its button opens the Browse tab. The card is hidden
once an add-on is installed and for anyone who cannot install.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): hide the pinned apps in the icon rail

When the window is narrower than 1024 px the sidebar shrinks to the icon rail by CSS alone, without the collapsed class. The pinned app links were still drawn there, with the indent meant for the full sidebar, so their icons sat to the right of the rail and were cut off. Hide the pinned app links in both rail states. The Apps entry keeps its centred icon. The e2e spec checks that the rail shows no pinned app and that every icon is centred at 1280 px collapsed and at 1000 px.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): stop the backend redirect test racing the installed list

The test reads the redirected URL right after the path changes. The
Backends page then loads the installed list and drops a selected backend
that is not installed, so the backend parameter was sometimes already gone
when the test read it. The mock server has no llama-cpp, and about 15 of
40 repeated runs failed on the backend assertion. The redirect itself was
correct, including show_all.

Serve the selected backend in the installed list, so the page keeps the
selection and the assertions stay as strict as before.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): accept a same-host Referer or Origin for human confirmation

Browsers send no Sec-Fetch-* headers over plain HTTP on an address that
is not localhost, so creating a resource from a LAN address failed with
"Creating a resource requires your own browser session".

When Sec-Fetch-Site is present it must still be same-origin with an
empty destination, as before. When it is absent, Origin or, failing
that, Referer must name the request host and port. A destination or
mode that is present must still be the expected one. This matches the
rule in BrowserProtection. The credential, token cookie, API key and
tool-context checks are unchanged.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): keep hub entries off the Apps route in the sidebar

The Build hub still owned /app/addons through its legacy Add-ons tab,
so the sidebar lit both Apps and Build on the Apps page. A tab whose
gate is closed now owns no route when the sidebar asks, so only the
Apps entry is active there. The hubs keep their own routes, and the
legacy navigation still gives /app/addons to the Build hub.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(ui): label the pin control on app tiles and in the detail view

The pin was a small icon-only button and hard to find. Each app tile now
shows a button reading Pin, or Pinned with a filled pin, and the detail
view has the same control in its header. Both toggle the same stored pin.

The Apps grid lists pinned apps first, in pin order, then the others.
The sidebar list and the server pins API are unchanged.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): check the Voice From a recording tab has one title

The Library and Text to speech tabs already assert that the add-on shell
title is the only h1. Do the same for the From a recording tab, so a
heading added there later fails the navigation spec.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): stop the add-on shell drawing a title over add-on pages

The app decides what its page shows. The shell drew the add-on name as a
header above every add-on page, so an add-on could not choose its own
title. The shell now draws no header on a live, loading or frozen
add-on page; each add-on titles its own pages. The unavailable and
missing-page states keep the name, because no add-on page is drawn there.

The runtime and shell specs now check that the shell adds no page title.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): let each add-on draw its own page title

The shell no longer titles add-on pages, so each add-on draws one h1 per
page. Voice titles its tabs "Voices" (Recognition and From a recording),
"Speech voices" (Library) and "Speak text" (Text to speech); "Add a speech
voice" already had its own. Face draws "Faces", Studio "Studio" and Talk
"Talk". Tables promotes the database list and database name from h2 to h1.
Fine-tuning and Quantization already drew a title.

The add-on unit tests and the navigation and Studio specs now assert
exactly one h1 per page, with the page's own title.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): add a kind to library entries and read unknown kinds tolerantly

A library entry now has an optional kind: addon (the default when it is
absent), backend or model. Every index written before kinds existed stays
valid and its entries are add-ons.

A reader keeps the entries of the kinds it knows and skips the others
without reading their fields, so a newer kind never makes an older host
refuse the whole index. The refresh result and the library state report
how many entries were skipped and of which kinds, and the refresh logs a
warning. A kind that is not a plain kind name still makes the index
malformed. Search lists add-ons unless the caller asks for a kind, and
Resolve returns add-ons only, so an add-on install cannot be pointed at
a backend image.

A library policy may name the signer with an anchored identityRegex
instead of an exact identity, so builds from master and from tags both
verify. An add-on install refuses a policy that carries one.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(backends): install a backend from a library entry

A library can now list backends. An entry of kind backend names the
image of the backend gallery by digest, and POST /backends/library/install
installs it on the local node. The gallery stays the source of truth and
its install path is the one used: the library resolves the entry, takes
the signature policy from the library, pins the image by digest and calls
the same install as the gallery. Installing a name that came from a
gallery, another library or by hand is refused and changes nothing.

The signature policy of a backend library names the signer with an
anchored identityRegex, so images signed by the merge workflow on master
and on tags both verify. A pattern that is not anchored is refused.

An install is bounded by a size limit per kind: add-ons keep 512 MiB and
a backend image defaults to 8 GiB, set with --addons-backend-max-bytes.
The limit reads the manifest after the signature check and before any
layer is fetched. The metadata of an installed backend records the
library it came from.

scripts/backends/cmd/backendcatalog renders entries from
backend/index.yaml and pins them against the registry. The pilot is the
CPU build of local-store, in gallery/backends/index.yaml. The library is
registered on the first start only with --addons-backend-library, which
is off by default.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(ui): show the kind of library entries and install backends from them

The Browse tab lists the entries of every kind this host reads and marks
each one as an add-on or a backend. A backend installs through the
backend route and not through the add-on lifecycle: the confirmation
says that the backend gallery is not changed and that a backend runs
native code, and a refusal of the host, such as a name installed from
another origin, is shown with its own reason. The details give the kind,
the alias and the signer pattern.

The library editor can name the signer with a pattern. Without this a
save would drop the pattern of a backend library. The Libraries tab
reports the entries a refresh skipped because their kind is not read.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* docs(addons): describe backends in the library

Document the entry kinds, how a reader skips a kind it does not know,
the backend entry format, the signer identity pattern, the install
route, the size limit of each kind, the pilot library and the command
that renders it. The backend page links to it.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(mcp): install a backend from a library entry

The backend library route installs a backend from an add-on library
entry, and the admin REST surface and the MCP catalog must stay in step.
Add the install_library_backend tool with an in-process and an HTTP
client, the route map entry, the safety-rule listing and a skill recipe.

Listing library entries stays on the add-on routes, which the assistant
does not expose, so no list tool is added.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): carry the add-on library keys in every locale

The add-on library and backend library strings existed only in English,
so the other locales had no value for them. Add the missing keys of the
addons namespace to de, es, id, it, ko, pt-BR and zh-CN. The values are
the English text until a translation is contributed.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* Revert "feat(mcp): install a backend from a library entry"

This reverts commit 7493cff727.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* Revert "docs(addons): describe backends in the library"

This reverts commit 57816ed7e6.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* Revert "feat(ui): show the kind of library entries and install backends from them"

This reverts commit 49b2b151b7.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* Revert "feat(backends): install a backend from a library entry"

This reverts commit 1d8d3e3421.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* Revert "feat(addons): add a kind to library entries and read unknown kinds tolerantly"

This reverts commit 484813f856.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(ui): drop the backend library keys from the locales

Revert the part of 39f77ae29 that added strings for backend libraries:
the kind labels, the backend install texts, the signer identity pattern
and the skipped entries notice. The add-on library keys stay.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(ui): add an add-ons control to the chat header

Add-on tools were on or off only through the /addons command, with a toast
and no state a person could see. The chat header now has an Add-ons button
in the style of the MCP dropdown. It lists each running add-on that ships
tools with a switch, and a badge shows how many are on.

The chat keeps the ids that are on (addonToolIds) next to the older
boolean, and both are saved with the chat. A chat that has only the boolean
means every add-on. The request sends addon_tools alone when every add-on is
on, and adds addon_tool_ids when only some are. /addons turns all on or all
off and uses the same state.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): let a chat request name the add-ons whose tools it uses

addon_tools=true still offers the tools of every add-on the caller may use.
A new addon_tool_ids metadata key, a comma-separated list of add-on ids,
narrows that to some add-ons. The list counts only with the opt-in, and a
list that names nothing offers no tool rather than all of them.

The executor drops the tools of add-ons that are not listed and refuses a
call to one as an unknown tool, so a model cannot reach a tool the person
turned off. Both keys are consumed so they do not reach the backend.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): cover the per-add-on tool list and the chat header control

Go tests cover the list form (the list filters the tools offered and the
calls allowed) and the unchanged boolean form. Unit tests cover the chat
add-on rules. Playwright specs cover the header control: listing only
add-ons that ship tools, toggling each one, the count, /addons in step with
the switches, and the request metadata.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): check each add-on page has one title when not enabled

The shell names an add-on only where the add-on page cannot mount (not
enabled, failed, no UI, bundle not loaded, no such page). Once the page
mounts it draws its own title, including when it says it is not enabled
on this server, and the shell draws none. The shell code already works
this way; this change states the rule beside the unavailable state and
pins it in the specs.

The shell spec now expects exactly one title in the unavailable states.
The navigation spec checks the Face page without a face model (the
add-on title only) and the Face page of a stopped add-on (the shell
title only).

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(addons): upgrade add-ons on their own when the setting is on

A new auto_upgrade_addons setting (flag LOCALAI_AUTO_UPGRADE_ADDONS,
default off) lets the owner upgrade an installed add-on when its library
lists a newer version. It follows the backend setting: a startup flag, a
runtime setting, and the same schedule as the backend update check (a
first pass shortly after start, then every six hours).

Each pass fetches the library of every installed add-on, and for each
available update builds the same pinned upgrade command an administrator
sends and runs it through the same lifecycle path. The channel rules, the
signer identity, the digest checks, the SDK compatibility check and the
backup before the upgrade all apply unchanged. The only difference is the
gate: the owner acts on its own setting, so no administrator is asked.
A refused or failed upgrade changes nothing and is logged; a candidate
that failed is not retried until the library lists another digest.

With the setting off, nothing runs and upgrades stay manual.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(ui): add the Upgrade add-ons automatically toggle to Settings

The toggle sits beside Upgrade backends automatically and is off by
default. It saves the auto_upgrade_addons runtime setting. The English
locale gets the label key, and the Settings test fixture lists the new
field.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): cover the automatic upgrade setting and document it

The setting defaults to off in the config, the runtime settings and the
flag, and is read back from the saved settings file. With it on, a real
owner upgrades an installed add-on through the manager; with it off,
nothing changes, and a change of the setting at run time takes effect on
the next pass. The manager specs show the upgrade goes through the same
pinned path as the manual one, and that a corrupted package, a failed
signature policy, an incompatible release, a missing update checker and
a caller who is not an administrator each leave the installed version in
place. The new specs are added to the lifecycle case inventory.

The add-ons page describes the setting, its schedule and its default.

Assisted-by: Claude Code:claude-sonnet-5-5
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* refactor(addons): name the library entry identifier id

The library entry of an add-on used addonId while the shared envelope
and the model entries use id. Release now has the field ID, written as
id, and every writer emits it: the index encoder, the package workflow
templates, the catalog generator and gallery/addons/index.yaml. The
digests in the index did not change.

DecodeIndex still reads addonId as a legacy alias for one release, so
an existing library and a library served by an older tool keep
working. An entry that holds both names is refused. The Apps UI reads
id and falls back to addonId.

Assisted-by: Claude Code:claude-sonnet-5-5 go node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(addons): use the id field in the auto-upgrade test release

The auto-upgrade test arrived after the identifier rename and still
named the release field AddonID, so the application tests did not
build.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(addons): annotate the auto-upgrade actor label for gosec

The actor label looks like a credential to gosec G101. It is a fixed name for upgrades the owner starts itself.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* fix(schema): persist the per-chat add-on tool fields

The chat header persists addonTools and addonToolIds, but Conversation had no fields for them, so the server dropped them on save. Add both and update the generated swagger files by hand because swag is not installed here.

Assisted-by: Claude Code:claude-sonnet-5-5 go
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): count the add-ons auto-upgrade setting in the settings groups

The setting sits in the Backends and galleries group, once. The page now lists 54 settings plus the three branding images, so the spec expects 57.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): pause the fake clock ahead of now in the clear-all spec

The fake clock runs from install, so pausing at the current time failed with 'Cannot fast-forward to the past' on a slow runner. The save itself is synchronous and was not lost.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* test(ui): hold the Studio capabilities reply longer in the skeleton spec

800 ms was shorter than a slow runner needs to render the page, so the skeleton was gone before the check. The product shows it.

Assisted-by: Claude Code:claude-sonnet-5-5 node playwright
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* feat(i18n): add the French add-ons locale

Master added the fr locale after this branch forked. The add-ons unit test requires every locale to carry the add-ons namespace, so fr needs its own addons.json.

Assisted-by: Claude Code:claude-sonnet-5-5 node
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

---------

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
2026-10-22 17:57:19 +02:00

1392 lines
46 KiB
Go

// SPDX-License-Identifier: MIT
// Package proposalflow is a pure model of the add-on proposal execution flow:
// Propose, Confirm, Cancel, execute, outcome-unknown handling and receipt
// lookup, plus the add-on hold and generation changes. It is the spec of that
// flow. It has no clock, does no I/O and starts no goroutine: time and I/O
// enter as events, and the reducer returns effects as data.
//
// The model describes ONE proposal. The environment (admission decisions, the
// runtime client, the hold, the generation) speaks to the proposal through
// events. A thin shell that owns the real clock, store and runtime executes
// the effects and feeds the answers back as events.
//
// This file holds the state, event and effect types and the reducer. The
// traces (traces.go) and the invariant search (explore.go) import it.
package proposalflow
import "fmt"
// MaxLookups bounds the automatic receipt lookups of one unknown outcome. The
// implementation bounds them by a time window; the model uses a count so the
// state space stays finite. After the bound only an explicit lookup or the
// owner's resolution remains.
const MaxLookups = 2
// Role is the role an actor holds on the resource, as the host sees it now.
type Role int
// Roles, lowest first. The order is the rank.
const (
RoleNone Role = iota
RoleViewer
RoleEditor
RoleOwner
)
func (r Role) String() string {
switch r {
case RoleNone:
return "none"
case RoleViewer:
return "viewer"
case RoleEditor:
return "editor"
case RoleOwner:
return "owner"
}
return fmt.Sprintf("role(%d)", int(r))
}
// ToolKind is the kind the add-on declared for a tool. The host derives the
// action of a proposal from it and from nothing the caller sends.
type ToolKind int
// Tool kinds. KindUndeclared is a tool the installed add-on does not declare.
const (
KindUndeclared ToolKind = iota
KindRead
KindWrite
KindSchema
)
func (k ToolKind) String() string {
switch k {
case KindUndeclared:
return "undeclared"
case KindRead:
return "read"
case KindWrite:
return "write"
case KindSchema:
return "schema"
}
return fmt.Sprintf("kind(%d)", int(k))
}
// Action is the host authority a proposal runs under.
type Action int
// Actions of a proposal. ActionNone is what a read or undeclared tool maps to:
// it is never a proposal.
const (
ActionNone Action = iota
ActionWrite
ActionSchema
)
func (a Action) String() string {
switch a {
case ActionNone:
return "none"
case ActionWrite:
return "write"
case ActionSchema:
return "schema"
}
return fmt.Sprintf("action(%d)", int(a))
}
// ActionOf derives the action from the tool kind. It is the only place an
// action comes from.
func ActionOf(k ToolKind) Action {
switch k {
case KindWrite:
return ActionWrite
case KindSchema:
return ActionSchema
case KindUndeclared, KindRead:
return ActionNone
}
return ActionNone
}
// Required is the least role that may run the action. ActionNone needs a role
// nobody holds below owner, so it never passes for a lower one.
func (a Action) Required() Role {
switch a {
case ActionWrite:
return RoleEditor
case ActionSchema:
return RoleOwner
case ActionNone:
return RoleOwner
}
return RoleOwner
}
// Prop is what every stored situation of a proposal carries. There is no
// Action field: it is derived from Kind, so a proposal cannot hold an action
// that disagrees with its tool.
type Prop struct {
ID string
Proposer string
ProposerRole Role
Kind ToolKind
// Gen is the add-on generation the preview was made against.
Gen int
// ExpiresAt is a number on the clock the shell supplies in events.
ExpiresAt int64
}
// Action is the action derived from the tool kind.
func (p Prop) Action() Action { return ActionOf(p.Kind) }
// ---------------------------------------------------------------- states
// State is a tagged union: one constructor per situation. The marker method
// limits the set to this package; a test checks that AllStates lists them all.
type State interface {
isState()
// Name is the constructor name.
Name() string
// Durable is the stored lifecycle state the situation maps to, or "" when
// nothing is stored.
Durable() string
}
// Unproposed is the start: nothing is stored.
type Unproposed struct{}
// Refused is a proposal the host refused at Propose. Nothing is stored.
type Refused struct{ Why RefuseWhy }
// Pending is a stored proposal that waits for a human decision.
type Pending struct{ P Prop }
// Admitting is a confirmed proposal that waits for the admission decision of
// the resource (role recheck, hold, writer slot, blocking outcome, runtime
// generation). Nothing is sent to the add-on and nothing is persisted yet.
type Admitting struct {
P Prop
By string
}
// ExecPrepared is the durable executing state with NOTHING sent to the add-on
// yet. Leaving it by a definite not-sent answer is safe and retryable.
type ExecPrepared struct{ P Prop }
// ExecSent is the executing state after the request may have reached the
// add-on. From here the outcome is only ever known by evidence.
type ExecSent struct{ P Prop }
// OutcomeUnknown is a sent apply with no evidence, with automatic receipt
// lookups remaining. It blocks conflicting writes on the resource.
type OutcomeUnknown struct {
P Prop
Lookups int
}
// UnknownManual is an unresolved outcome whose automatic lookups ran out. It
// still blocks writes. An explicit lookup or the owner's resolution leaves it.
type UnknownManual struct{ P Prop }
// Abandoned is an unresolved outcome the resource owner stopped waiting for.
// It no longer blocks writes. A late receipt is still recorded.
type Abandoned struct{ P Prop }
// Applied is a proposal with a committed receipt. Terminal.
type Applied struct{ P Prop }
// Rejected is a proposal the add-on definitely did not apply: it refused the
// request, answered a conflict, or recorded a rejected receipt. Terminal.
type Rejected struct {
P Prop
Why RejectWhy
}
// NotApplied is a sent proposal that a receipt lookup proved never committed.
// Terminal.
type NotApplied struct{ P Prop }
// Cancelled is a proposal that never ran. Terminal.
type Cancelled struct {
P Prop
Why CancelWhy
}
// Expired is a proposal that reached its expiry unconfirmed. Terminal.
type Expired struct{ P Prop }
// Stale is a proposal whose add-on generation moved, so what the human saw is
// not what would run. Terminal.
type Stale struct{ P Prop }
// Dropped is an abandoned proposal removed after retention. Terminal.
type Dropped struct{ P Prop }
func (Unproposed) isState() {}
func (Refused) isState() {}
func (Pending) isState() {}
func (Admitting) isState() {}
func (ExecPrepared) isState() {}
func (ExecSent) isState() {}
func (OutcomeUnknown) isState() {}
func (UnknownManual) isState() {}
func (Abandoned) isState() {}
func (Applied) isState() {}
func (Rejected) isState() {}
func (NotApplied) isState() {}
func (Cancelled) isState() {}
func (Expired) isState() {}
func (Stale) isState() {}
func (Dropped) isState() {}
func (Unproposed) Name() string { return "Unproposed" }
func (Refused) Name() string { return "Refused" }
func (Pending) Name() string { return "Pending" }
func (Admitting) Name() string { return "Admitting" }
func (ExecPrepared) Name() string { return "ExecPrepared" }
func (ExecSent) Name() string { return "ExecSent" }
func (OutcomeUnknown) Name() string { return "OutcomeUnknown" }
func (UnknownManual) Name() string { return "UnknownManual" }
func (Abandoned) Name() string { return "Abandoned" }
func (Applied) Name() string { return "Applied" }
func (Rejected) Name() string { return "Rejected" }
func (NotApplied) Name() string { return "NotApplied" }
func (Cancelled) Name() string { return "Cancelled" }
func (Expired) Name() string { return "Expired" }
func (Stale) Name() string { return "Stale" }
func (Dropped) Name() string { return "Dropped" }
// Durable names are the gateway.ProposalState values of the implementation.
// Several constructors share one: the model is finer than the stored state.
func (Unproposed) Durable() string { return "" }
func (Refused) Durable() string { return "" }
func (Pending) Durable() string { return "pending" }
func (Admitting) Durable() string { return "pending" }
func (ExecPrepared) Durable() string { return "executing" }
func (ExecSent) Durable() string { return "executing" }
func (OutcomeUnknown) Durable() string { return "outcome-unknown" }
func (UnknownManual) Durable() string { return "outcome-unknown" }
func (Abandoned) Durable() string { return "abandoned-unknown" }
func (Applied) Durable() string { return "applied" }
func (Rejected) Durable() string { return "rejected" }
func (NotApplied) Durable() string { return "rejected" }
func (Cancelled) Durable() string { return "cancelled" }
func (Expired) Durable() string { return "expired" }
func (Stale) Durable() string { return "rejected" }
func (Dropped) Durable() string { return "" }
// AllStates lists one value of every constructor. A test compares it with the
// types that declare isState, so a new constructor cannot be forgotten.
func AllStates() []State {
return []State{
Unproposed{}, Refused{}, Pending{}, Admitting{}, ExecPrepared{}, ExecSent{}, OutcomeUnknown{},
UnknownManual{}, Abandoned{}, Applied{}, Rejected{}, NotApplied{}, Cancelled{}, Expired{}, Stale{}, Dropped{},
}
}
// RefuseWhy says why Propose refused.
type RefuseWhy int
// Refusal reasons of Propose.
const (
RefuseUndeclaredTool RefuseWhy = iota + 1
RefuseNotAMutation
RefuseInsufficientRole
RefuseStaleGeneration
)
func (w RefuseWhy) String() string {
switch w {
case RefuseUndeclaredTool:
return "undeclared-tool"
case RefuseNotAMutation:
return "not-a-mutation"
case RefuseInsufficientRole:
return "insufficient-role"
case RefuseStaleGeneration:
return "stale-generation"
}
return fmt.Sprintf("refuse(%d)", int(w))
}
// RejectWhy says why the add-on definitely did not apply.
type RejectWhy int
// Rejection reasons.
const (
RejectReceipt RejectWhy = iota + 1
RejectRefused
RejectConflict
)
func (w RejectWhy) String() string {
switch w {
case RejectReceipt:
return "rejected-receipt"
case RejectRefused:
return "addon-refused"
case RejectConflict:
return "revision-conflict"
}
return fmt.Sprintf("reject(%d)", int(w))
}
// CancelWhy says why a proposal was cancelled.
type CancelWhy int
// Cancellation reasons.
const (
CancelByProposer CancelWhy = iota + 1
CancelByHold
CancelByAuthority
)
func (w CancelWhy) String() string {
switch w {
case CancelByProposer:
return "proposer"
case CancelByHold:
return "hold"
case CancelByAuthority:
return "authority-lowered"
}
return fmt.Sprintf("cancel(%d)", int(w))
}
// ---------------------------------------------------------------- events
// Event is the complete input vocabulary. Time enters as numbers in Now
// fields; the reducer only compares them.
type Event interface {
isEvent()
Name() string
}
// Propose asks to store a proposal. Tool is the kind the installed add-on
// declared for the named tool (KindUndeclared when it declared none). Claimed
// is the action the caller wrote in the request: the model carries it only to
// show it is never used.
type Propose struct {
ID string
Actor string
Role Role
Tool ToolKind
Claimed Action
Gen int
RuntimeGen int
ExpiresAt int64
Now int64
// Held is true while a backup, upgrade or restore holds the add-on.
Held bool
// Blocked is true while another operation on the resource is unresolved.
Blocked bool
}
// Confirm is a confirmation from a host confirmation surface. Role is the
// actor's live role. Human says the credential stands for a human. DigestOK
// says the named digest equals the stored one.
type Confirm struct {
Actor string
Role Role
Human bool
DigestOK bool
Now int64
}
// Cancel withdraws the proposal.
type Cancel struct{ Actor string }
// Tick delivers the clock. It is how expiry is noticed without a sweep call.
type Tick struct{ Now int64 }
// AdmitGranted is the admission decision "go": the writer slot is held, the
// role and identity were rechecked, no other outcome blocks, and the add-on
// runtime of RuntimeGen is ready.
type AdmitGranted struct {
Now int64
RuntimeGen int
}
// AdmitRefused is an admission decision "no", before anything was persisted
// or sent.
type AdmitRefused struct{ Cause AdmitCause }
// SendStarted says the runtime client passed its local gates (not withdrawn, a
// free slot, a valid envelope) and the request is now on the wire. It is the
// moment from which the add-on may have received the operation.
type SendStarted struct{}
// NotSent says the runtime client refused the dispatch before the request left
// the host. The add-on cannot have seen it.
type NotSent struct{ Cause NotSentCause }
// ApplyResult is the end of the apply call, after the request was sent.
type ApplyResult struct{ Outcome ApplyOutcome }
// LookupDue is the retry timer of the receipt lookup.
type LookupDue struct{}
// ReceiptResult is the answer of a receipt lookup.
type ReceiptResult struct{ Answer ReceiptAnswer }
// OwnerResolve is the resource owner stopping the wait for an unresolved
// outcome. Reason says a non-empty reason was given. Held is true while the
// add-on is held.
type OwnerResolve struct {
Role Role
Human bool
Reason bool
Held bool
}
// HoldAcquired is HoldAddon: new admissions stop and admitted work is
// cancelled.
type HoldAcquired struct{}
// HoldReleased lifts the hold.
type HoldReleased struct{}
// GenerationChanged says the add-on moved to another generation.
type GenerationChanged struct{ New int }
// AuthorityLowered says the proposer lost the authority the action needs.
type AuthorityLowered struct{}
// Restart is the owner process starting again after a stop or crash. Volatile
// facts are gone; stored state remains.
type Restart struct{}
// RetentionElapsed says an abandoned outcome passed its retention.
type RetentionElapsed struct{}
func (Propose) isEvent() {}
func (Confirm) isEvent() {}
func (Cancel) isEvent() {}
func (Tick) isEvent() {}
func (AdmitGranted) isEvent() {}
func (AdmitRefused) isEvent() {}
func (SendStarted) isEvent() {}
func (NotSent) isEvent() {}
func (ApplyResult) isEvent() {}
func (LookupDue) isEvent() {}
func (ReceiptResult) isEvent() {}
func (OwnerResolve) isEvent() {}
func (HoldAcquired) isEvent() {}
func (HoldReleased) isEvent() {}
func (GenerationChanged) isEvent() {}
func (AuthorityLowered) isEvent() {}
func (Restart) isEvent() {}
func (RetentionElapsed) isEvent() {}
func (Propose) Name() string { return "Propose" }
func (Confirm) Name() string { return "Confirm" }
func (Cancel) Name() string { return "Cancel" }
func (Tick) Name() string { return "Tick" }
func (AdmitGranted) Name() string { return "AdmitGranted" }
func (AdmitRefused) Name() string { return "AdmitRefused" }
func (SendStarted) Name() string { return "SendStarted" }
func (NotSent) Name() string { return "NotSent" }
func (ApplyResult) Name() string { return "ApplyResult" }
func (LookupDue) Name() string { return "LookupDue" }
func (ReceiptResult) Name() string { return "ReceiptResult" }
func (OwnerResolve) Name() string { return "OwnerResolve" }
func (HoldAcquired) Name() string { return "HoldAcquired" }
func (HoldReleased) Name() string { return "HoldReleased" }
func (GenerationChanged) Name() string { return "GenerationChanged" }
func (AuthorityLowered) Name() string { return "AuthorityLowered" }
func (Restart) Name() string { return "Restart" }
func (RetentionElapsed) Name() string { return "RetentionElapsed" }
// AllEvents lists one value of every event type, for the coverage tests.
func AllEvents() []Event {
return []Event{
Propose{}, Confirm{}, Cancel{}, Tick{}, AdmitGranted{}, AdmitRefused{}, SendStarted{}, NotSent{},
ApplyResult{}, LookupDue{}, ReceiptResult{}, OwnerResolve{}, HoldAcquired{}, HoldReleased{},
GenerationChanged{}, AuthorityLowered{}, Restart{}, RetentionElapsed{},
}
}
// AdmitCause is why an admission said no.
type AdmitCause int
// Admission refusal causes. All of them happen before anything is persisted
// or sent, so none of them can leave an unknown outcome.
const (
CauseHeld AdmitCause = iota + 1
CauseForbidden
CauseUnavailable
CauseBlocked
CauseCaller
)
func (c AdmitCause) String() string {
switch c {
case CauseHeld:
return "held"
case CauseForbidden:
return "forbidden"
case CauseUnavailable:
return "unavailable"
case CauseBlocked:
return "blocked"
case CauseCaller:
return "caller-gone"
}
return fmt.Sprintf("cause(%d)", int(c))
}
// NotSentCause is why the runtime client did not send.
type NotSentCause int
// Causes of a definite not-sent answer. Slots, Invalid and Withdrawn are
// retryable. Hold and Authority are cancellations that arrived before the
// send. Superseded means the generation moved.
const (
NotSentSlots NotSentCause = iota + 1
NotSentInvalid
NotSentWithdrawn
NotSentHold
NotSentAuthority
NotSentSuperseded
)
func (c NotSentCause) String() string {
switch c {
case NotSentSlots:
return "no-free-slot"
case NotSentInvalid:
return "invalid-envelope"
case NotSentWithdrawn:
return "withdrawn"
case NotSentHold:
return "hold"
case NotSentAuthority:
return "authority-lowered"
case NotSentSuperseded:
return "superseded"
}
return fmt.Sprintf("notsent(%d)", int(c))
}
// ApplyOutcome is how the apply call ended once the request was sent.
type ApplyOutcome int
// Apply outcomes. Committed, Rejected, Refused and Conflict are answers of the
// add-on. Unsettled, TransportError and Timeout give no evidence.
const (
ApplyCommitted ApplyOutcome = iota + 1
ApplyRejected
ApplyRefused
ApplyConflict
ApplyUnsettled
ApplyTransportError
ApplyTimeout
)
func (o ApplyOutcome) String() string {
switch o {
case ApplyCommitted:
return "committed"
case ApplyRejected:
return "rejected"
case ApplyRefused:
return "refused"
case ApplyConflict:
return "conflict"
case ApplyUnsettled:
return "unsettled"
case ApplyTransportError:
return "transport-error"
case ApplyTimeout:
return "timeout"
}
return fmt.Sprintf("apply(%d)", int(o))
}
// ReceiptAnswer is the answer of a receipt lookup.
type ReceiptAnswer int
// Receipt answers. NotCommitted is a definite answer: the add-on promises the
// operation never commits. The implementation has no such answer today. A
// missing receipt, a pending receipt and a failed lookup are all Unsettled.
const (
ReceiptCommitted ReceiptAnswer = iota + 1
ReceiptRejected
ReceiptNotCommitted
ReceiptUnsettled
)
func (a ReceiptAnswer) String() string {
switch a {
case ReceiptCommitted:
return "committed"
case ReceiptRejected:
return "rejected"
case ReceiptNotCommitted:
return "not-committed"
case ReceiptUnsettled:
return "unsettled"
}
return fmt.Sprintf("receipt(%d)", int(a))
}
// ---------------------------------------------------------------- effects
// Effect is data the shell executes. The reducer never executes one.
type Effect interface {
isEffect()
// String is a short stable form, used by tests and the viewer.
String() string
}
// Reply answers the caller of the event.
type Reply struct{ Code ReplyCode }
// Persist writes the durable lifecycle state before anything else happens.
type Persist struct{ To string }
// Admit asks for the admission decision under the action.
type Admit struct{ Action Action }
// Dispatch hands the stored operation to the runtime client, once.
type Dispatch struct{}
// CancelDispatch asks the shell to stop a dispatch that has not started. The
// shell answers with NotSent or, if it was too late, SendStarted.
type CancelDispatch struct{ Why NotSentCause }
// CancelSend aborts the context of a request that is on the wire. The call
// then ends with an ApplyResult.
type CancelSend struct{}
// LookupReceipt asks the add-on for the receipt of the operation. Read only.
type LookupReceipt struct{}
// Alarm reports a broken contract between shell and model.
type Alarm struct{ Msg string }
func (Reply) isEffect() {}
func (Persist) isEffect() {}
func (Admit) isEffect() {}
func (Dispatch) isEffect() {}
func (CancelDispatch) isEffect() {}
func (CancelSend) isEffect() {}
func (LookupReceipt) isEffect() {}
func (Alarm) isEffect() {}
func (e Reply) String() string { return "reply:" + string(e.Code) }
func (e Persist) String() string { return "persist:" + e.To }
func (e Admit) String() string { return "admit:" + e.Action.String() }
func (Dispatch) String() string { return "dispatch" }
func (e CancelDispatch) String() string { return "cancel-dispatch:" + e.Why.String() }
func (CancelSend) String() string { return "cancel-send" }
func (LookupReceipt) String() string { return "lookup-receipt" }
func (e Alarm) String() string { return "alarm:" + e.Msg }
// ReplyCode is the answer the caller gets.
type ReplyCode string
// Reply codes.
const (
ReplyCreated ReplyCode = "created"
ReplyExisting ReplyCode = "existing"
ReplyForbidden ReplyCode = "forbidden"
ReplyClosed ReplyCode = "closed"
ReplyExpired ReplyCode = "expired"
ReplyChanged ReplyCode = "changed"
ReplyBusy ReplyCode = "busy"
ReplyUnavailable ReplyCode = "unavailable"
ReplyBlocked ReplyCode = "blocked"
ReplyStale ReplyCode = "stale"
ReplyApplied ReplyCode = "applied"
ReplyRejected ReplyCode = "rejected"
ReplyUnknown ReplyCode = "outcome-unknown"
ReplyCancelled ReplyCode = "cancelled"
ReplyResolved ReplyCode = "resolved"
ReplyRefused ReplyCode = "refused"
)
// ---------------------------------------------------------------- rules
// RuleKind separates real transitions from ignored pairs.
type RuleKind string
// Rule kinds.
const (
KindTransition RuleKind = "transition"
KindIgnored RuleKind = "ignored"
KindViolation RuleKind = "violation"
)
// Rule documents one rule id. The reducer returns only ids that are listed.
type Rule struct {
ID string
Kind RuleKind
Text string
}
// Rules is the rule table. A test checks that the reducer returns only these
// ids and that the traces plus the search fire every one of them.
var Rules = []Rule{
{"R1", KindTransition, "Propose while the add-on is held: nothing stored, reply unavailable, retryable"},
{"R2", KindTransition, "Propose with a tool the add-on did not declare: Refused"},
{"R3", KindTransition, "Propose with a read tool: Refused, a read is never a proposal"},
{"R4", KindTransition, "Propose where the actor's role is below what the derived action needs: Refused (an editor cannot propose a schema tool)"},
{"R5", KindTransition, "Propose against a generation that is not the runtime's: Refused"},
{"R6", KindTransition, "Propose while another outcome on the resource is unresolved: nothing stored, reply blocked"},
{"R7", KindTransition, "Propose with no usable expiry: nothing stored, reply unavailable"},
{"R8", KindTransition, "Propose stored: Pending. The action comes from the tool kind"},
{"R9", KindTransition, "Propose repeated for a stored proposal: the stored proposal is returned, nothing changes"},
{"R10", KindTransition, "Confirm by another user than the proposer: forbidden, no change"},
{"R11", KindTransition, "Confirm from a credential that is not a human surface: forbidden, no change"},
{"R12", KindTransition, "Confirm whose digest is not the stored one: changed, no change"},
{"R13", KindTransition, "Confirm after expiry: Expired"},
{"R14", KindTransition, "Confirm whose live role no longer covers the derived action: forbidden, stays Pending"},
{"R15", KindTransition, "Confirm accepted: Admitting, ask for the admission decision"},
{"R16", KindTransition, "Confirm while a confirmation is being admitted: busy, no change"},
{"R17", KindTransition, "Confirm of an executing or unresolved proposal: look the receipt up, never apply again"},
{"R18", KindTransition, "Confirm of an Applied proposal: the stored answer, nothing runs"},
{"R19", KindTransition, "Confirm of a Rejected, NotApplied or Stale proposal: the stored answer, nothing runs"},
{"R20", KindTransition, "Confirm of a Cancelled or Dropped proposal: closed, nothing runs"},
{"R21", KindTransition, "Confirm of an Expired proposal: expired, nothing runs"},
{"R22", KindTransition, "Any caller request for a proposal that was never stored: forbidden"},
{"R23", KindTransition, "Cancel by another user than the proposer: forbidden, no change"},
{"R24", KindTransition, "Cancel of a Pending proposal: Cancelled"},
{"R25", KindTransition, "Cancel while a confirmation is in admission: Cancelled, the late admission answer finds it closed"},
{"R26", KindTransition, "Cancel of a proposal that is not pending: closed, no change"},
{"R27", KindTransition, "Cancel of a Cancelled proposal: the same answer again"},
{"R28", KindTransition, "Tick past expiry of a Pending or Admitting proposal: Expired"},
{"R29", KindTransition, "Admission refused (held, forbidden, unavailable, blocked, caller gone): back to Pending, retryable. Nothing was persisted or sent"},
{"R30", KindTransition, "Admission granted after expiry: Expired"},
{"R31", KindTransition, "Admission granted for another generation than the proposal's: Stale"},
{"R32", KindTransition, "Admission granted: ExecPrepared, persist executing, then dispatch once"},
{"R33", KindTransition, "SendStarted: ExecSent. From here an error is not proof of anything"},
{"R34", KindTransition, "NotSent for a retryable cause (no slot, invalid envelope, withdrawn): back to Pending. The add-on never saw it"},
{"R35", KindTransition, "NotSent because a hold or lowered authority cancelled the dispatch: Cancelled"},
{"R36", KindTransition, "NotSent because the generation moved: Stale"},
{"R37", KindTransition, "Apply answered committed: Applied"},
{"R38", KindTransition, "Apply answered rejected, refused or conflict: Rejected, the add-on definitely did not apply"},
{"R39", KindTransition, "Apply ended with no evidence (unsettled, transport error, timeout) after a send: OutcomeUnknown"},
{"R40", KindTransition, "Receipt lookup says committed: Applied"},
{"R41", KindTransition, "Receipt lookup says rejected: Rejected"},
{"R42", KindTransition, "Receipt lookup says not-committed: NotApplied"},
{"R43", KindTransition, "Receipt lookup unsettled with lookups left: stay OutcomeUnknown, count it"},
{"R44", KindTransition, "Receipt lookup unsettled and the bound reached: UnknownManual"},
{"R45", KindTransition, "Lookup timer fired for an unresolved or abandoned outcome: look the receipt up"},
{"R46", KindTransition, "Owner resolution from a non-owner, a non-human credential or without a reason: forbidden"},
{"R47", KindTransition, "Owner resolution while the add-on is held: unavailable, no change"},
{"R48", KindTransition, "Owner resolution of an unresolved outcome: Abandoned, one last lookup"},
{"R49", KindTransition, "Owner resolution of a proposal that is not unresolved: closed, no change"},
{"R50", KindTransition, "Owner resolution of a settled or abandoned proposal: the stored answer"},
{"R51", KindTransition, "Hold on a Pending or Admitting proposal: Cancelled"},
{"R52", KindTransition, "Hold on a prepared dispatch: ask the shell to cancel it, wait for NotSent or SendStarted"},
{"R53", KindTransition, "Hold on a sent request: abort its context and wait for the apply result"},
{"R54", KindTransition, "Proposer's authority lowered on a Pending or Admitting proposal: Cancelled"},
{"R55", KindTransition, "Proposer's authority lowered on a prepared dispatch: ask the shell to cancel it"},
{"R56", KindTransition, "Proposer's authority lowered on a sent request: abort its context and wait"},
{"R57", KindTransition, "Generation changed under a Pending or Admitting proposal: Stale"},
{"R58", KindTransition, "Generation changed under a prepared dispatch: ask the shell to cancel it"},
{"R59", KindTransition, "Restart while a confirmation is in admission: Pending, admission is volatile"},
{"R60", KindTransition, "Restart with an executing proposal: OutcomeUnknown, a crash may have followed the send"},
{"R61", KindTransition, "Retention elapsed for an abandoned outcome: Dropped"},
{"I1", KindIgnored, "no proposal is stored yet, so the event has nothing to act on"},
{"I2", KindIgnored, "the proposal is closed (terminal): the event changes nothing"},
{"I3", KindIgnored, "late or out-of-order reply for an operation that is not executing: no new information, no change"},
{"I4", KindIgnored, "environment fact with no effect on this situation (hold released, lifted hold, nothing to retry)"},
{"I5", KindIgnored, "the answer carries no new evidence: the outcome stays as it is"},
{"I6", KindIgnored, "the live call decides: its own result moves the proposal"},
{"I7", KindIgnored, "the automatic lookups are over or not due; only an explicit lookup or resolution remains"},
{"I8", KindIgnored, "the time has not reached expiry"},
{"I9", KindIgnored, "the stored state already is what the event would make it"},
{"I10", KindIgnored, "the generation moved but this situation is decided by the result of its own call or lookup"},
{"V1", KindViolation, "SendStarted with no prepared dispatch: the shell broke its contract, raise an alarm and change nothing"},
}
// RuleByID finds a rule.
func RuleByID(id string) (Rule, bool) {
for _, r := range Rules {
if r.ID == id {
return r, true
}
}
return Rule{}, false
}
// ---------------------------------------------------------------- reducer
// Reduce is the model. It is pure: the same state and event give the same
// state, effects and rule id. It panics only on a state or event type this
// package does not declare, which the type system already forbids outside it.
func Reduce(s State, e Event) (State, []Effect, string) {
switch st := s.(type) {
case Unproposed:
return reduceUnproposed(st, e)
case Refused:
return reduceRefused(st, e)
case Pending:
return reducePending(st, e)
case Admitting:
return reduceAdmitting(st, e)
case ExecPrepared:
return reducePrepared(st, e)
case ExecSent:
return reduceSent(st, e)
case OutcomeUnknown:
return reduceUnknown(st, e)
case UnknownManual:
return reduceManual(st, e)
case Abandoned:
return reduceAbandoned(st, e)
case Applied:
return reduceClosed(st, st.P, e)
case Rejected:
return reduceClosed(st, st.P, e)
case NotApplied:
return reduceClosed(st, st.P, e)
case Cancelled:
return reduceClosed(st, st.P, e)
case Expired:
return reduceClosed(st, st.P, e)
case Stale:
return reduceClosed(st, st.P, e)
case Dropped:
return reduceClosed(st, st.P, e)
}
panic(fmt.Sprintf("proposalflow: unknown state %T", s))
}
// move enters next and persists its durable state first, so a crash after it
// always leaves something the recovery can find.
func move(next State, rule string, fx ...Effect) (State, []Effect, string) {
out := []Effect{}
if d := next.Durable(); d != "" {
out = append(out, Persist{To: d})
}
return next, append(out, fx...), rule
}
// stay returns the given state and effects without persisting. It is for
// unchanged states and for moves between constructors that share one durable
// state (Pending and Admitting, ExecPrepared and ExecSent).
func stay(s State, rule string, fx ...Effect) (State, []Effect, string) {
return s, fx, rule
}
// ignore keeps the state and marks the pair ignored under a reason id.
func ignore(s State, rule string) (State, []Effect, string) { return s, nil, rule }
func reply(c ReplyCode) Effect { return Reply{Code: c} }
func unhandled(s State, e Event) string {
return fmt.Sprintf("proposalflow: %s has no case for %T", s.Name(), e)
}
// violation is V1: SendStarted outside a prepared dispatch.
func violation(s State) (State, []Effect, string) {
return stay(s, "V1", Alarm{Msg: "send started with no prepared dispatch in " + s.Name()})
}
// ---- Unproposed
func reduceUnproposed(s Unproposed, e Event) (State, []Effect, string) {
switch ev := e.(type) {
case Propose:
action := ActionOf(ev.Tool)
switch {
case ev.Held:
return stay(s, "R1", reply(ReplyUnavailable))
case ev.Tool == KindUndeclared:
return move(Refused{Why: RefuseUndeclaredTool}, "R2", reply(ReplyRefused))
case ev.Tool == KindRead:
return move(Refused{Why: RefuseNotAMutation}, "R3", reply(ReplyRefused))
case ev.Role.rank() < action.Required().rank():
// The claimed action is never read: only the tool kind decides.
return move(Refused{Why: RefuseInsufficientRole}, "R4", reply(ReplyForbidden))
case ev.Gen != ev.RuntimeGen:
return move(Refused{Why: RefuseStaleGeneration}, "R5", reply(ReplyStale))
case ev.Blocked:
return stay(s, "R6", reply(ReplyBlocked))
case ev.ExpiresAt <= ev.Now:
return stay(s, "R7", reply(ReplyUnavailable))
}
p := Prop{ID: ev.ID, Proposer: ev.Actor, ProposerRole: ev.Role, Kind: ev.Tool, Gen: ev.Gen, ExpiresAt: ev.ExpiresAt}
return move(Pending{P: p}, "R8", reply(ReplyCreated))
case Confirm, Cancel, OwnerResolve:
return stay(s, "R22", reply(ReplyForbidden))
case Tick, AdmitGranted, AdmitRefused, NotSent, ApplyResult, LookupDue, ReceiptResult, HoldAcquired,
HoldReleased, GenerationChanged, AuthorityLowered, Restart, RetentionElapsed:
return ignore(s, "I1")
case SendStarted:
return violation(s)
}
panic(unhandled(s, e))
}
// rank makes Role comparable without relying on the integer order in callers.
func (r Role) rank() int { return int(r) }
// ---- Refused
func reduceRefused(s Refused, e Event) (State, []Effect, string) {
switch e.(type) {
case Propose:
return stay(s, "R9", reply(ReplyExisting))
case Confirm, Cancel, OwnerResolve:
return stay(s, "R22", reply(ReplyForbidden))
case Tick, AdmitGranted, AdmitRefused, NotSent, ApplyResult, LookupDue, ReceiptResult, HoldAcquired,
HoldReleased, GenerationChanged, AuthorityLowered, Restart, RetentionElapsed:
return ignore(s, "I1")
case SendStarted:
return violation(s)
}
panic(unhandled(s, e))
}
// ---- Pending
func reducePending(s Pending, e Event) (State, []Effect, string) {
p := s.P
switch ev := e.(type) {
case Propose:
return stay(s, "R9", reply(ReplyExisting))
case Confirm:
switch {
case !ev.Human:
return stay(s, "R11", reply(ReplyForbidden))
case ev.Actor != p.Proposer:
return stay(s, "R10", reply(ReplyForbidden))
case !ev.DigestOK:
return stay(s, "R12", reply(ReplyChanged))
case ev.Now >= p.ExpiresAt:
return move(Expired{P: p}, "R13", reply(ReplyExpired))
case ev.Role.rank() < p.Action().Required().rank():
return stay(s, "R14", reply(ReplyForbidden))
}
return stay(Admitting{P: p, By: ev.Actor}, "R15", Admit{Action: p.Action()})
case Cancel:
if ev.Actor != p.Proposer {
return stay(s, "R23", reply(ReplyForbidden))
}
return move(Cancelled{P: p, Why: CancelByProposer}, "R24", reply(ReplyCancelled))
case Tick:
if ev.Now >= p.ExpiresAt {
return move(Expired{P: p}, "R28")
}
return ignore(s, "I8")
case OwnerResolve:
return stay(s, "R49", reply(ReplyClosed))
case HoldAcquired:
return move(Cancelled{P: p, Why: CancelByHold}, "R51")
case AuthorityLowered:
return move(Cancelled{P: p, Why: CancelByAuthority}, "R54")
case GenerationChanged:
return move(Stale{P: p}, "R57")
case Restart:
return ignore(s, "I9")
case AdmitGranted, AdmitRefused, NotSent, ApplyResult, LookupDue, ReceiptResult:
return ignore(s, "I3")
case HoldReleased, RetentionElapsed:
return ignore(s, "I4")
case SendStarted:
return violation(s)
}
panic(unhandled(s, e))
}
// ---- Admitting
func reduceAdmitting(s Admitting, e Event) (State, []Effect, string) {
p := s.P
switch ev := e.(type) {
case Propose:
return stay(s, "R9", reply(ReplyExisting))
case Confirm:
return stay(s, "R16", reply(ReplyBusy))
case Cancel:
if ev.Actor != p.Proposer {
return stay(s, "R23", reply(ReplyForbidden))
}
return move(Cancelled{P: p, Why: CancelByProposer}, "R25", reply(ReplyCancelled))
case Tick:
if ev.Now >= p.ExpiresAt {
return move(Expired{P: p}, "R28")
}
return ignore(s, "I8")
case AdmitRefused:
return stay(Pending{P: p}, "R29", reply(admitReply(ev.Cause)))
case AdmitGranted:
switch {
case ev.Now >= p.ExpiresAt:
return move(Expired{P: p}, "R30", reply(ReplyExpired))
case ev.RuntimeGen != p.Gen:
return move(Stale{P: p}, "R31", reply(ReplyStale))
}
// The executing state is durable before the add-on sees anything.
return move(ExecPrepared{P: p}, "R32", Dispatch{})
case OwnerResolve:
return stay(s, "R49", reply(ReplyClosed))
case HoldAcquired:
return move(Cancelled{P: p, Why: CancelByHold}, "R51")
case AuthorityLowered:
return move(Cancelled{P: p, Why: CancelByAuthority}, "R54")
case GenerationChanged:
return move(Stale{P: p}, "R57")
case Restart:
return stay(Pending{P: p}, "R59")
case NotSent, ApplyResult, LookupDue, ReceiptResult:
return ignore(s, "I3")
case HoldReleased, RetentionElapsed:
return ignore(s, "I4")
case SendStarted:
return violation(s)
}
panic(unhandled(s, e))
}
func admitReply(c AdmitCause) ReplyCode {
switch c {
case CauseForbidden:
return ReplyForbidden
case CauseBlocked:
return ReplyBlocked
case CauseHeld, CauseUnavailable, CauseCaller:
return ReplyUnavailable
}
return ReplyUnavailable
}
// ---- evidence shared by every situation that was sent
// evidence applies the answers that settle a sent proposal. It reports false
// when the event is not evidence.
func evidence(p Prop, e Event) (State, []Effect, string, bool) {
switch ev := e.(type) {
case ApplyResult:
switch ev.Outcome {
case ApplyCommitted:
s, fx, r := move(Applied{P: p}, "R37", reply(ReplyApplied))
return s, fx, r, true
case ApplyRejected:
s, fx, r := move(Rejected{P: p, Why: RejectReceipt}, "R38", reply(ReplyRejected))
return s, fx, r, true
case ApplyRefused:
s, fx, r := move(Rejected{P: p, Why: RejectRefused}, "R38", reply(ReplyRejected))
return s, fx, r, true
case ApplyConflict:
s, fx, r := move(Rejected{P: p, Why: RejectConflict}, "R38", reply(ReplyRejected))
return s, fx, r, true
case ApplyUnsettled, ApplyTransportError, ApplyTimeout:
return nil, nil, "", false
}
case ReceiptResult:
switch ev.Answer {
case ReceiptCommitted:
s, fx, r := move(Applied{P: p}, "R40")
return s, fx, r, true
case ReceiptRejected:
s, fx, r := move(Rejected{P: p, Why: RejectReceipt}, "R41")
return s, fx, r, true
case ReceiptNotCommitted:
s, fx, r := move(NotApplied{P: p}, "R42")
return s, fx, r, true
case ReceiptUnsettled:
return nil, nil, "", false
}
}
return nil, nil, "", false
}
// ---- ExecPrepared
func reducePrepared(s ExecPrepared, e Event) (State, []Effect, string) {
p := s.P
switch ev := e.(type) {
case SendStarted:
return stay(ExecSent{P: p}, "R33")
case NotSent:
switch ev.Cause {
case NotSentSlots, NotSentInvalid, NotSentWithdrawn:
// Finding (a): a refusal before the send is retryable. It must not
// become an unknown outcome.
return move(Pending{P: p}, "R34", reply(ReplyUnavailable))
case NotSentHold:
return move(Cancelled{P: p, Why: CancelByHold}, "R35", reply(ReplyCancelled))
case NotSentAuthority:
return move(Cancelled{P: p, Why: CancelByAuthority}, "R35", reply(ReplyCancelled))
case NotSentSuperseded:
return move(Stale{P: p}, "R36", reply(ReplyStale))
}
panic(unhandled(s, e))
case ApplyResult:
if st, fx, r, ok := evidence(p, e); ok {
return st, fx, r
}
return move(OutcomeUnknown{P: p}, "R39", reply(ReplyUnknown))
case ReceiptResult:
if st, fx, r, ok := evidence(p, e); ok {
return st, fx, r
}
return ignore(s, "I5")
case Propose:
return stay(s, "R9", reply(ReplyExisting))
case Confirm:
return stay(s, "R17", LookupReceipt{}, reply(ReplyUnknown))
case Cancel:
return stay(s, "R26", reply(ReplyClosed))
case OwnerResolve:
return stay(s, "R49", reply(ReplyClosed))
case HoldAcquired:
return stay(s, "R52", CancelDispatch{Why: NotSentHold})
case AuthorityLowered:
return stay(s, "R55", CancelDispatch{Why: NotSentAuthority})
case GenerationChanged:
return stay(s, "R58", CancelDispatch{Why: NotSentSuperseded})
case Restart:
return move(OutcomeUnknown{P: p}, "R60")
case Tick:
return ignore(s, "I8")
case AdmitGranted, AdmitRefused:
return ignore(s, "I3")
case LookupDue:
return ignore(s, "I6")
case HoldReleased, RetentionElapsed:
return ignore(s, "I4")
}
panic(unhandled(s, e))
}
// ---- ExecSent
func reduceSent(s ExecSent, e Event) (State, []Effect, string) {
p := s.P
switch e.(type) {
case ApplyResult:
if st, fx, r, ok := evidence(p, e); ok {
return st, fx, r
}
return move(OutcomeUnknown{P: p}, "R39", reply(ReplyUnknown))
case ReceiptResult:
if st, fx, r, ok := evidence(p, e); ok {
return st, fx, r
}
return ignore(s, "I5")
case Propose:
return stay(s, "R9", reply(ReplyExisting))
case Confirm:
return stay(s, "R17", LookupReceipt{}, reply(ReplyUnknown))
case Cancel:
return stay(s, "R26", reply(ReplyClosed))
case OwnerResolve:
return stay(s, "R49", reply(ReplyClosed))
case HoldAcquired:
return stay(s, "R53", CancelSend{})
case AuthorityLowered:
return stay(s, "R56", CancelSend{})
case Restart:
return move(OutcomeUnknown{P: p}, "R60")
case GenerationChanged:
return ignore(s, "I10")
case Tick:
return ignore(s, "I8")
case AdmitGranted, AdmitRefused, NotSent:
return ignore(s, "I3")
case LookupDue:
return ignore(s, "I6")
case SendStarted:
return ignore(s, "I9")
case HoldReleased, RetentionElapsed:
return ignore(s, "I4")
}
panic(unhandled(s, e))
}
// ---- OutcomeUnknown
func reduceUnknown(s OutcomeUnknown, e Event) (State, []Effect, string) {
p := s.P
switch ev := e.(type) {
case ApplyResult:
if st, fx, r, ok := evidence(p, e); ok {
return st, fx, r
}
return ignore(s, "I5")
case ReceiptResult:
if st, fx, r, ok := evidence(p, e); ok {
return st, fx, r
}
n := s.Lookups + 1
if n >= MaxLookups {
return move(UnknownManual{P: p}, "R44")
}
return move(OutcomeUnknown{P: p, Lookups: n}, "R43")
case LookupDue:
return stay(s, "R45", LookupReceipt{})
case Confirm:
return stay(s, "R17", LookupReceipt{}, reply(ReplyUnknown))
case OwnerResolve:
return resolve(s, p, ev)
case Propose:
return stay(s, "R9", reply(ReplyExisting))
case Cancel:
return stay(s, "R26", reply(ReplyClosed))
case GenerationChanged:
return ignore(s, "I10")
case Restart:
return ignore(s, "I9")
case Tick:
return ignore(s, "I8")
case AdmitGranted, AdmitRefused, NotSent:
return ignore(s, "I3")
case HoldAcquired, HoldReleased, AuthorityLowered, RetentionElapsed:
return ignore(s, "I4")
case SendStarted:
return violation(s)
}
panic(unhandled(s, e))
}
// resolve is the owner's resolution of an unresolved outcome.
func resolve(s State, p Prop, ev OwnerResolve) (State, []Effect, string) {
switch {
case ev.Role != RoleOwner || !ev.Human || !ev.Reason:
return stay(s, "R46", reply(ReplyForbidden))
case ev.Held:
return stay(s, "R47", reply(ReplyUnavailable))
}
// One last lookup runs first: a final receipt that arrives afterwards
// still settles the abandoned outcome.
return move(Abandoned{P: p}, "R48", LookupReceipt{}, reply(ReplyResolved))
}
// ---- UnknownManual
func reduceManual(s UnknownManual, e Event) (State, []Effect, string) {
p := s.P
switch ev := e.(type) {
case ApplyResult:
if st, fx, r, ok := evidence(p, e); ok {
return st, fx, r
}
return ignore(s, "I5")
case ReceiptResult:
if st, fx, r, ok := evidence(p, e); ok {
return st, fx, r
}
return ignore(s, "I5")
case LookupDue:
return ignore(s, "I7")
case Confirm:
return stay(s, "R17", LookupReceipt{}, reply(ReplyUnknown))
case OwnerResolve:
return resolve(s, p, ev)
case Propose:
return stay(s, "R9", reply(ReplyExisting))
case Cancel:
return stay(s, "R26", reply(ReplyClosed))
case GenerationChanged:
return ignore(s, "I10")
case Restart:
return ignore(s, "I9")
case Tick:
return ignore(s, "I8")
case AdmitGranted, AdmitRefused, NotSent:
return ignore(s, "I3")
case HoldAcquired, HoldReleased, AuthorityLowered, RetentionElapsed:
return ignore(s, "I4")
case SendStarted:
return violation(s)
}
panic(unhandled(s, e))
}
// ---- Abandoned
func reduceAbandoned(s Abandoned, e Event) (State, []Effect, string) {
p := s.P
switch e.(type) {
case ApplyResult:
if st, fx, r, ok := evidence(p, e); ok {
return st, fx, r
}
return ignore(s, "I5")
case ReceiptResult:
if st, fx, r, ok := evidence(p, e); ok {
return st, fx, r
}
return ignore(s, "I5")
case LookupDue:
return stay(s, "R45", LookupReceipt{})
case RetentionElapsed:
return move(Dropped{P: p}, "R61")
case Confirm:
return stay(s, "R17", LookupReceipt{}, reply(ReplyUnknown))
case OwnerResolve:
return stay(s, "R50", reply(ReplyResolved))
case Propose:
return stay(s, "R9", reply(ReplyExisting))
case Cancel:
return stay(s, "R26", reply(ReplyClosed))
case GenerationChanged:
return ignore(s, "I10")
case Restart:
return ignore(s, "I9")
case Tick:
return ignore(s, "I8")
case AdmitGranted, AdmitRefused, NotSent:
return ignore(s, "I3")
case HoldAcquired, HoldReleased, AuthorityLowered:
return ignore(s, "I4")
case SendStarted:
return violation(s)
}
panic(unhandled(s, e))
}
// ---- terminal situations
// reduceClosed handles every closed proposal. The stored answer depends on
// which closed state it is; everything else is ignored with a reason.
func reduceClosed(s State, p Prop, e Event) (State, []Effect, string) {
switch e.(type) {
case Propose:
return stay(s, "R9", reply(ReplyExisting))
case Confirm:
switch s.(type) {
case Applied:
return stay(s, "R18", reply(ReplyApplied))
case Rejected, NotApplied, Stale:
return stay(s, "R19", reply(ReplyRejected))
case Cancelled, Dropped:
return stay(s, "R20", reply(ReplyClosed))
case Expired:
return stay(s, "R21", reply(ReplyExpired))
}
panic(unhandled(s, e))
case Cancel:
if _, ok := s.(Cancelled); ok {
return stay(s, "R27", reply(ReplyCancelled))
}
return stay(s, "R26", reply(ReplyClosed))
case OwnerResolve:
switch s.(type) {
case Applied, Rejected, NotApplied, Stale:
return stay(s, "R50", reply(ReplyResolved))
case Cancelled, Expired, Dropped:
return stay(s, "R49", reply(ReplyClosed))
}
panic(unhandled(s, e))
case AdmitGranted, AdmitRefused, NotSent, ApplyResult, ReceiptResult:
return ignore(s, "I3")
case Tick, LookupDue, RetentionElapsed, Restart:
return ignore(s, "I2")
case HoldAcquired, HoldReleased, GenerationChanged, AuthorityLowered:
return ignore(s, "I2")
case SendStarted:
return violation(s)
}
panic(unhandled(s, e))
}