Files
LocalAI/core/http/static_cache_test.go
mudler's LocalAI [bot] ff299df453 perf(http): gzip responses, cache hashed assets, bound the trace endpoints (#11056)
Three measured HTTP-layer regressions on a live deployment, fixed together
because they all shape the bytes on the wire.

1. No compression. The server sent no Content-Encoding regardless of what
   the client asked for, confirmed with curl straight at 127.0.0.1:8080 so
   it was not an ingress artefact. Adds gzip middleware, on by default and
   configurable via LOCALAI_DISABLE_HTTP_COMPRESSION and
   LOCALAI_HTTP_COMPRESSION_MIN_LENGTH (default 1024 bytes so tiny bodies
   are not wastefully wrapped). Streaming routes are skipped explicitly:
   an SSE Accept header, a WebSocket upgrade, and the completion / SSE /
   log-tail path prefixes, because whether a completion request streams is
   decided by the request body, which the middleware runs too early to see.
   Already-compressed formats (woff2, png, mp4, ...) are skipped too; gzip
   made those marginally larger. Measured over the embedded React build:
   JS+CSS 2815 KB raw to 808 KB gzipped (3.48x).

2. No cache headers on content-hashed assets. Vite hashes the filenames,
   so a given /assets/ URL can never change content, yet they shipped with
   no Cache-Control, ETag or Last-Modified, and the browser re-fetched the
   whole bundle on every navigation with no conditional request available.
   /assets/* now carries public, max-age=31536000, immutable. index.html
   stays no-cache so a deploy is picked up, and the unhashed locale JSONs
   get a short TTL rather than the immutable one.

3. Unbounded trace endpoints. /api/traces returned 21,033,606 bytes in
   4.65s and /api/backend-traces 3,471,682 bytes in 1.50s, and the admin
   UI polls both every few seconds. The ring buffer holds up to 1024
   entries, each embedding full input_text payloads. Both list endpoints
   now take limit / offset / full, default to 50 entries, and strip the
   heavy fields (request and response bodies plus headers for API traces,
   body and data for backend traces) unless full=true. Every trace gets a
   process-lifetime ID and GET /api/traces/{id} and
   /api/backend-traces/{id} serve the full record, which is what the UI
   fetches when a row is expanded. The list body stays a JSON array;
   paging metadata rides in X-Total-Count, X-Trace-Offset and
   X-Trace-Limit. Reproducing the live shape in a test, the polled payload
   goes from 21,131,097 bytes to 7,201 bytes.


Assisted-by: Claude:claude-opus-4-8 [Claude Code]

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
2026-07-22 22:51:25 +02:00

147 lines
4.2 KiB
Go

package http_test
import (
"context"
"io"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"strings"
"github.com/labstack/echo/v4"
"github.com/mudler/LocalAI/core/application"
"github.com/mudler/LocalAI/core/config"
. "github.com/mudler/LocalAI/core/http"
"github.com/mudler/LocalAI/pkg/system"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
)
// Vite content-hashes the React bundle filenames, so a given /assets/ URL can
// never change content. Serving those without Cache-Control meant the browser
// re-downloaded the whole ~1.8 MB bundle on every navigation, with not even a
// conditional request available to turn it into a 304. index.html carries the
// hashed filenames, so it must stay uncached or a deploy would never be
// picked up.
var _ = Describe("Static asset caching", Ordered, func() {
var (
app *echo.Echo
tmpdir string
cancel context.CancelFunc
asset string
)
BeforeAll(func() {
var err error
tmpdir, err = os.MkdirTemp("", "static-cache-")
Expect(err).ToNot(HaveOccurred())
modelDir := filepath.Join(tmpdir, "models")
Expect(os.Mkdir(modelDir, 0750)).To(Succeed())
bDir := filepath.Join(tmpdir, "backends")
Expect(os.Mkdir(bDir, 0750)).To(Succeed())
var c context.Context
c, cancel = context.WithCancel(context.Background())
systemState, err := system.GetSystemState(
system.WithBackendPath(bDir),
system.WithModelPath(modelDir),
)
Expect(err).ToNot(HaveOccurred())
appInst, err := application.New(
config.WithContext(c),
config.WithSystemState(systemState),
)
Expect(err).ToNot(HaveOccurred())
app, err = API(appInst)
Expect(err).ToNot(HaveOccurred())
// Pick a real filename out of the embedded build so the spec exercises
// the same handler path a browser would hit.
asset = firstEmbeddedAsset(app)
Expect(asset).ToNot(BeEmpty(), "the embedded React build must contain at least one asset")
})
AfterAll(func() {
cancel()
Expect(os.RemoveAll(tmpdir)).To(Succeed())
})
do := func(path string, headers map[string]string) *httptest.ResponseRecorder {
req := httptest.NewRequest(http.MethodGet, path, nil)
for k, v := range headers {
req.Header.Set(k, v)
}
rec := httptest.NewRecorder()
app.ServeHTTP(rec, req)
return rec
}
It("serves content-hashed assets as immutable for a year", func() {
rec := do("/assets/"+asset, nil)
Expect(rec.Code).To(Equal(http.StatusOK))
cc := rec.Header().Get("Cache-Control")
Expect(cc).To(ContainSubstring("public"))
Expect(cc).To(ContainSubstring("max-age=31536000"))
Expect(cc).To(ContainSubstring("immutable"))
})
It("keeps index.html uncached so a deploy is picked up", func() {
rec := do("/app", nil)
Expect(rec.Code).To(Equal(http.StatusOK))
Expect(rec.Header().Get("Cache-Control")).To(Equal("no-cache"))
})
It("does not mark the unhashed locale files immutable", func() {
rec := do("/locales/en/common.json", nil)
if rec.Code == http.StatusOK {
Expect(rec.Header().Get("Cache-Control")).ToNot(ContainSubstring("immutable"))
}
})
It("gzips the asset when the client accepts it", func() {
plain := do("/assets/"+asset, nil)
gzipped := do("/assets/"+asset, map[string]string{"Accept-Encoding": "gzip"})
Expect(gzipped.Code).To(Equal(http.StatusOK))
// Small assets fall below the compression threshold; only assert the
// shrink when the middleware actually engaged.
if gzipped.Header().Get("Content-Encoding") == "gzip" {
Expect(gzipped.Body.Len()).To(BeNumerically("<", plain.Body.Len()))
}
Expect(plain.Header().Get("Content-Encoding")).To(BeEmpty())
})
})
// firstEmbeddedAsset asks the running app for the asset listing indirectly:
// the SPA index references its own bundles, so parsing it yields a filename
// that is guaranteed to exist in the embedded build.
func firstEmbeddedAsset(app *echo.Echo) string {
req := httptest.NewRequest(http.MethodGet, "/app", nil)
rec := httptest.NewRecorder()
app.ServeHTTP(rec, req)
body, err := io.ReadAll(rec.Body)
if err != nil {
return ""
}
const marker = "/assets/"
idx := strings.Index(string(body), marker)
if idx < 0 {
return ""
}
rest := string(body)[idx+len(marker):]
end := strings.IndexAny(rest, `"'`)
if end < 0 {
return ""
}
return rest[:end]
}