mirror of
https://github.com/mudler/LocalAI.git
synced 2026-05-17 13:10:23 -04:00
* refactor(transcription): propagate request ctx through ModelTranscription* Replaces context.Background() with the HTTP request ctx so client disconnects start cancelling the gRPC call. No backend-side abort wiring yet — that comes in a later commit. Pure plumbing. Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(cli): pass ctx to backend.ModelTranscription Follow-up toe65d3e1fwhich threaded ctx through ModelTranscription but missed the CLI caller. CLI commands have no request-scoped ctx, so context.Background() is correct here. Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(audio): propagate request ctx into TTS, sound-gen, audio-transform Same ctx-plumbing pattern applied to the rest of the audio path. CLI callers use context.Background() since there is no request scope; HTTP callers use c.Request().Context(). Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(backend): propagate request ctx into biometric, detection, rerank, diarization paths Replaces remaining context.Background() sites in core/backend with the caller's ctx. After this commit, every core/backend/*.go entry point threads the request ctx end-to-end to the gRPC client. Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * refactor(grpc): plumb ctx through AIModel.AudioTranscription{,Stream} Adds context.Context as first parameter to the AIModel interface methods that wrap whisper-style transcription. Server-side gRPC handler now forwards the per-RPC ctx (server-streaming uses stream.Context()). Whisper, Voxtral, vibevoice-cpp, and sherpa-onnx accept the parameter; none uses it yet — the actual cancellation primitive lands in the next commit so this is pure plumbing. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(whisper): add abort_callback hook in the C++ bridge Installs a std::atomic<int> flag, wires it into whisper_full_params.abort_callback, and exposes a set_abort(int) C symbol so Go can flip the flag from a goroutine watching the request context. transcribe() now distinguishes abort (return 2) from real whisper_full failure (return 1). Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(whisper): register set_abort symbol in the purego loader Adds the Go-side binding for the new C export so the next commit can call CppSetAbort(1) from a watcher goroutine on ctx.Done(). Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(whisper): honor ctx cancellation and return codes.Canceled A watcher goroutine watches ctx.Done() during AudioTranscription and calls CppSetAbort(1) on cancel. whisper_full sees abort_callback return true at the next compute graph step, returns non-zero, and the bridge returns 2 -> AudioTranscription maps that to codes.Canceled. Adds an opt-in test (gated on WHISPER_MODEL_PATH / WHISPER_AUDIO_PATH) that asserts cancellation latency under 5s and proves the abort flag resets cleanly so the next transcription succeeds. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(whisper): join the cancel watcher goroutine before returning Follow-up to85edf9d2. The previous commit used `defer close(done)` and called the watcher "joined synchronously" — but close() only signals, it does not block until the goroutine exits. That left a window where a late CppSetAbort(1) from a cancelled call could land on the next call, after its C-side g_abort reset but before whisper_full() began polling the abort callback, corrupting the second transcription. Switch to a sync.WaitGroup join so wg.Wait() blocks until the watcher has actually returned from its select. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(whisper): short-circuit pre-cancelled ctx in AudioTranscription If ctx is already Done() at entry, return codes.Canceled immediately instead of running the full transcription. The C-side g_abort reset happens at the start of transcribe() and would otherwise overwrite a watcher-set abort flag from an already-cancelled ctx, producing a spurious successful transcription on a request the client has already abandoned. Assisted-by: Claude:claude-haiku-4-5 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(tests/distributed): update testLLM mock for new AudioTranscription signature Phase B (93c48e19) added context.Context to AIModel.AudioTranscription but missed the testLLM mock in tests/e2e/distributed. CI golangci-lint caught it: *testLLM did not implement grpc.AIModel because the method signature lacked the ctx parameter, which broke the distributed test suite compilation and cascaded through every backend-build job that runs `go build ./...`. Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * test(whisper): port cancellation test to Ginkgo/Gomega Project policy (.agents/coding-style.md, enforced by golangci-lint forbidigo) is that all Go tests must use Ginkgo v2 + Gomega — no stdlib testing patterns (t.Skip, t.Fatalf, etc.). Convert the cancellation test to a Describe/It block with Skip(...) for env gating and Expect/HaveOccurred for assertions. Same coverage: cancel mid-flight returns codes.Canceled within 5s and a follow-up transcription succeeds, proving the C-side g_abort flag resets cleanly. Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
159 lines
4.5 KiB
Go
159 lines
4.5 KiB
Go
package backend
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sort"
|
|
|
|
"github.com/mudler/LocalAI/core/config"
|
|
"github.com/mudler/LocalAI/core/schema"
|
|
|
|
grpcPkg "github.com/mudler/LocalAI/pkg/grpc"
|
|
"github.com/mudler/LocalAI/pkg/grpc/proto"
|
|
"github.com/mudler/LocalAI/pkg/model"
|
|
)
|
|
|
|
// DiarizationRequest carries the diarization-specific knobs the HTTP
|
|
// layer collects. Speaker hints (NumSpeakers / MinSpeakers / MaxSpeakers)
|
|
// and clustering knobs are optional — backends ignore the ones they
|
|
// don't act on. IncludeText only matters for backends that emit
|
|
// per-segment transcripts as a by-product (e.g. vibevoice.cpp).
|
|
type DiarizationRequest struct {
|
|
Audio string
|
|
Language string
|
|
NumSpeakers int32
|
|
MinSpeakers int32
|
|
MaxSpeakers int32
|
|
ClusteringThreshold float32
|
|
MinDurationOn float32
|
|
MinDurationOff float32
|
|
IncludeText bool
|
|
}
|
|
|
|
func (r *DiarizationRequest) toProto(threads uint32) *proto.DiarizeRequest {
|
|
return &proto.DiarizeRequest{
|
|
Dst: r.Audio,
|
|
Threads: threads,
|
|
Language: r.Language,
|
|
NumSpeakers: r.NumSpeakers,
|
|
MinSpeakers: r.MinSpeakers,
|
|
MaxSpeakers: r.MaxSpeakers,
|
|
ClusteringThreshold: r.ClusteringThreshold,
|
|
MinDurationOn: r.MinDurationOn,
|
|
MinDurationOff: r.MinDurationOff,
|
|
IncludeText: r.IncludeText,
|
|
}
|
|
}
|
|
|
|
func loadDiarizationModel(ml *model.ModelLoader, modelConfig config.ModelConfig, appConfig *config.ApplicationConfig) (grpcPkg.Backend, error) {
|
|
if modelConfig.Backend == "" {
|
|
return nil, fmt.Errorf("diarization: model %q has no backend set; supported backends include vibevoice-cpp and sherpa-onnx", modelConfig.Name)
|
|
}
|
|
opts := ModelOptions(modelConfig, appConfig)
|
|
m, err := ml.Load(opts...)
|
|
if err != nil {
|
|
recordModelLoadFailure(appConfig, modelConfig.Name, modelConfig.Backend, err, nil)
|
|
return nil, err
|
|
}
|
|
if m == nil {
|
|
return nil, fmt.Errorf("could not load diarization model")
|
|
}
|
|
return m, nil
|
|
}
|
|
|
|
// ModelDiarization runs the Diarize RPC against the configured backend
|
|
// and returns a normalized schema.DiarizationResult.
|
|
func ModelDiarization(ctx context.Context, req DiarizationRequest, ml *model.ModelLoader, modelConfig config.ModelConfig, appConfig *config.ApplicationConfig) (*schema.DiarizationResult, error) {
|
|
m, err := loadDiarizationModel(ml, modelConfig, appConfig)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
threads := uint32(0)
|
|
if modelConfig.Threads != nil {
|
|
threads = uint32(*modelConfig.Threads)
|
|
}
|
|
|
|
r, err := m.Diarize(ctx, req.toProto(threads))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return diarizationResultFromProto(r), nil
|
|
}
|
|
|
|
// diarizationResultFromProto normalizes backend speaker labels to
|
|
// "SPEAKER_NN" — the convention pyannote/RTTM tooling expects — while
|
|
// keeping the original label available via the Speaker field. Each
|
|
// distinct backend label gets its own normalized id, in first-seen order.
|
|
func diarizationResultFromProto(r *proto.DiarizeResponse) *schema.DiarizationResult {
|
|
if r == nil {
|
|
return &schema.DiarizationResult{Segments: []schema.DiarizationSegment{}}
|
|
}
|
|
|
|
out := &schema.DiarizationResult{
|
|
Task: "diarize",
|
|
Duration: float64(r.Duration),
|
|
Language: r.Language,
|
|
Segments: make([]schema.DiarizationSegment, 0, len(r.Segments)),
|
|
}
|
|
|
|
type speakerStats struct {
|
|
idx int
|
|
duration float64
|
|
segments int
|
|
}
|
|
stats := map[string]*speakerStats{}
|
|
order := []string{}
|
|
|
|
for i, s := range r.Segments {
|
|
if s == nil {
|
|
continue
|
|
}
|
|
raw := s.Speaker
|
|
if raw == "" {
|
|
raw = "0"
|
|
}
|
|
st, ok := stats[raw]
|
|
if !ok {
|
|
st = &speakerStats{idx: len(order)}
|
|
stats[raw] = st
|
|
order = append(order, raw)
|
|
}
|
|
dur := float64(s.End) - float64(s.Start)
|
|
if dur > 0 {
|
|
st.duration += dur
|
|
}
|
|
st.segments++
|
|
|
|
out.Segments = append(out.Segments, schema.DiarizationSegment{
|
|
Id: i,
|
|
Speaker: fmt.Sprintf("SPEAKER_%02d", st.idx),
|
|
Label: raw,
|
|
Start: float64(s.Start),
|
|
End: float64(s.End),
|
|
Text: s.Text,
|
|
})
|
|
}
|
|
|
|
out.NumSpeakers = len(order)
|
|
if out.NumSpeakers == 0 && r.NumSpeakers > 0 {
|
|
out.NumSpeakers = int(r.NumSpeakers)
|
|
}
|
|
|
|
out.Speakers = make([]schema.DiarizationSpeaker, 0, len(order))
|
|
for _, raw := range order {
|
|
st := stats[raw]
|
|
out.Speakers = append(out.Speakers, schema.DiarizationSpeaker{
|
|
Id: fmt.Sprintf("SPEAKER_%02d", st.idx),
|
|
Label: raw,
|
|
TotalSpeechDuration: st.duration,
|
|
SegmentCount: st.segments,
|
|
})
|
|
}
|
|
sort.SliceStable(out.Speakers, func(i, j int) bool {
|
|
return out.Speakers[i].Id < out.Speakers[j].Id
|
|
})
|
|
|
|
return out
|
|
}
|