mirror of
https://github.com/mudler/LocalAI.git
synced 2026-11-08 13:33:26 -05:00
Ettore Di Giacinto
1834d4fd72
No release ever shipped add-ons, so there is no installed base on api 1.
The manifest must now declare api {"min": 2, "max": 2}; a manifest with
api 1, no api or a wider range is refused with a message that names the
range.
Every field that was gated on api 2 is now part of the contract, so the
Min*API constants and their gates are gone, and so are HostAPIMin and
the apiMin host field. Three older-manifest shims go with them: the
resource listing the host implied for one add-on, the legacyArgs hint
for arguments an older version of a tool took, and the tests that
checked the gates. All shipped manifests and the test fixtures declare
api 2.
Assisted-by: Claude:claude-sonnet-5-5 go test
61 lines
2.6 KiB
Go
61 lines
2.6 KiB
Go
// SPDX-License-Identifier: MIT
|
|
package contract
|
|
|
|
import (
|
|
"encoding/json"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("Slots served by skills", func() {
|
|
host := func() HostCompatibility {
|
|
h := compatible()
|
|
h.SDK = 0
|
|
return h
|
|
}
|
|
manifestWith := func(defs ...SkillDefinition) Manifest {
|
|
m, err := ParseManifest(fixture())
|
|
Expect(err).NotTo(HaveOccurred())
|
|
m.Capabilities.SkillDefinitions = defs
|
|
return m
|
|
}
|
|
odt := SkillDefinition{Name: "odt", Shadows: "odt", Slot: &SlotDefinition{Kind: SlotKindDocuments, Extensions: []string{".odt"}, Words: []string{"odt", "opendocument"}, Library: "odfpy"}}
|
|
|
|
It("reads the default slots from data", func() {
|
|
Expect(ReplaceableSkills).To(ConsistOf("xlsx", "docx", "pptx", "pdf"))
|
|
s, ok := DefaultSlot("docx")
|
|
Expect(ok).To(BeTrue())
|
|
Expect(s.Extensions).To(Equal([]string{".docx"}))
|
|
Expect(s.Library).To(Equal("python-docx"))
|
|
})
|
|
|
|
It("lets an add-on declare a slot the contract has never heard of", func() {
|
|
Expect(ValidateManifest(manifestWith(odt), host())).To(Succeed())
|
|
Expect(ShadowedSkills([]SkillDefinition{odt})).To(Equal([]string{"odt"}))
|
|
Expect(SlotsOf([]SkillDefinition{odt})[0].Library).To(Equal("odfpy"))
|
|
Expect(IsolatedSkills([]ToolDefinition{{Name: "run", Kind: ToolKindAction, Shadows: "bash", InputSchema: json.RawMessage(`{"type":"object","properties":{"command":{"type":"string"}},"required":["command"],"additionalProperties":false}`)}}, []SkillDefinition{odt})).To(Equal([]string{"odt"}))
|
|
})
|
|
|
|
It("keeps a skill that shadows a default slot and declares nothing working", func() {
|
|
d := SkillDefinition{Name: "docx", Shadows: "docx"}
|
|
Expect(ValidateManifest(manifestWith(d), host())).To(Succeed())
|
|
Expect(SlotsOf([]SkillDefinition{d})[0].Library).To(Equal("python-docx"))
|
|
})
|
|
|
|
It("refuses a shadow of an unknown slot without a declaration, and bad declarations", func() {
|
|
Expect(validateSkillDefinitions("sample", []SkillDefinition{{Name: "odt", Shadows: "odt"}})).NotTo(Succeed())
|
|
Expect(validateSkillDefinitions("sample", []SkillDefinition{{Name: "sample", Slot: odt.Slot}})).NotTo(Succeed())
|
|
Expect(validateSkillDefinitions("sample", []SkillDefinition{{Name: "writing-skills", Shadows: "writing-skills", Slot: odt.Slot}})).NotTo(Succeed())
|
|
for _, bad := range []*SlotDefinition{
|
|
{Kind: "games"},
|
|
{Kind: SlotKindDocuments, Extensions: []string{"odt"}},
|
|
{Kind: SlotKindDocuments, Extensions: []string{".ODT"}},
|
|
{Kind: SlotKindDocuments, Words: []string{"<b>"}},
|
|
{Kind: SlotKindDocuments, Library: "<x>"},
|
|
} {
|
|
Expect(validateSkillDefinitions("sample", []SkillDefinition{{Name: "odt", Shadows: "odt", Slot: bad}})).NotTo(Succeed())
|
|
}
|
|
})
|
|
})
|